D9249: forward socket error string to KTcpSocket

2017-12-08 Thread Martin Koller 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:84f290a2659d: forward socket error string to KTcpSocket 
(authored by mkoller).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9249?vs=23638=23648

REVISION DETAIL
  https://phabricator.kde.org/D9249

AFFECTED FILES
  src/core/ktcpsocket.cpp

To: mkoller, dfaure
Cc: #frameworks

D9249: forward socket error string to KTcpSocket

2017-12-08 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9249

To: mkoller, dfaure
Cc: #frameworks

D9249: forward socket error string to KTcpSocket

2017-12-08 Thread Martin Koller 
mkoller created this revision.
mkoller added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  KTcpSocket is a QIODevice, internally using a Qt socket - however it does not 
set the error string of itself when the internal socket signals some error 
condition.
  
  The original problem I had with this was the PIM maildispatcher -  in the 
lack of any error string - just showing an error number when notifying the 
user. But a "Failed to transport message. 3" does not really say much to the 
user.
  
  Now at least I get "Failed to transport message. Host not found"

TEST PLAN
  using maildispatcher sending mail to an unknown host

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D9249

AFFECTED FILES
  src/core/ktcpsocket.cpp

To: mkoller, dfaure
Cc: #frameworks