D9480: Add cmake function 'kdbusaddons_generate_dbus_service_file'

2018-01-04 Thread Ralf Habacker 
This revision was automatically updated to reflect the committed changes.
Closed by commit R271:76aba6882ae3: Add cmake function 
kdbusaddons_generate_dbus_service_file (authored by habacker).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D9480?vs=24564=24738#toc

REPOSITORY
  R271 KDBusAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9480?vs=24564=24738

REVISION DETAIL
  https://phabricator.kde.org/D9480

AFFECTED FILES
  CMakeLists.txt
  KF5DBusAddonsConfig.cmake.in
  KF5DBusAddonsMacros.cmake
  KF5dbus.service.in

To: habacker, dfaure, kfunk
Cc: cgiboudeaux, #frameworks

D9480: Add cmake function 'kdbusaddons_generate_dbus_service_file'

2018-01-04 Thread David Faure 
dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R271 KDBusAddons

BRANCH
  arcpatch-D9480

REVISION DETAIL
  https://phabricator.kde.org/D9480

To: habacker, dfaure, kfunk
Cc: cgiboudeaux, #frameworks

D9480: Add cmake function 'kdbusaddons_generate_dbus_service_file'

2018-01-02 Thread Ralf Habacker 
habacker marked 6 inline comments as done.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D9480

To: habacker, dfaure, kfunk
Cc: cgiboudeaux, #frameworks

D9480: Add cmake function 'kdbusaddons_generate_dbus_service_file'

2018-01-02 Thread Ralf Habacker 
habacker updated this revision to Diff 24564.
habacker added a comment.


  - fixed doc
  - check if absolute path on unix
  - use cmake variable KDE_INSTALL_FULL_BINDIR
  - renamed service file template

REPOSITORY
  R271 KDBusAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9480?vs=24309=24564

BRANCH
  arcpatch-D9480

REVISION DETAIL
  https://phabricator.kde.org/D9480

AFFECTED FILES
  CMakeLists.txt
  KF5DBusAddonsConfig.cmake.in
  KF5DBusAddonsMacros.cmake
  KF5dbus.service.in

To: habacker, dfaure, kfunk
Cc: cgiboudeaux, #frameworks

D9480: Add cmake function 'kdbusaddons_generate_dbus_service_file'

2018-01-02 Thread David Faure 
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> CMakeLists.txt:63
> +   "KF5DBusAddonsMacros.cmake"
> +   "dbus.service.in"
>  DESTINATION "${CMAKECONFIG_INSTALL_DIR}"

This file name should be prefixed with kf5 or something, to avoid possible 
clashes.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D9480

To: habacker, dfaure, kfunk
Cc: cgiboudeaux, #frameworks

D9480: Add cmake function 'kdbusaddons_generate_dbus_service_file'

2017-12-22 Thread Christophe Giboudeaux 
cgiboudeaux added inline comments.

INLINE COMMENTS

> KF5DBusAddonsMacros.cmake:4
> +#
> +# kdbusaddons_generate_dbus_service_file(executable name path)
> +#

kdbusaddons_generate_dbus_service_file(EXECUTABLE NAME PATH) to improve the 
readability.

Please also document each parameter.

> KF5DBusAddonsMacros.cmake:6
> +#
> +# This function generates a dbus service file and installs it
> +# into the specified destination.

D-Bus

> KF5DBusAddonsMacros.cmake:9
> +#
> +# On Windows the path is not used because dbus service executables
> +# are always installed in the same directory as dbus-daemon.

D-Bus

> KF5DBusAddonsMacros.cmake:14
> +#
> +#  kdbusaddons_generate_dbus_service_file(kded5 org.kde.kded5 
> ${CMAKE_INSTALL_PATH}/bin)
> +#

${KDE_INSTALL_FULL_BINDIR}

> KF5DBusAddonsMacros.cmake:23
> +else()
> +set(EXEC ${_path}/${_executable})
> +endif()

You don't check whether _path is absolute. This shall return an error.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D9480

To: habacker, dfaure, kfunk
Cc: cgiboudeaux, #frameworks

D9480: Add cmake function 'kdbusaddons_generate_dbus_service_file'

2017-12-22 Thread Ralf Habacker 
habacker added a reviewer: kfunk.

REPOSITORY
  R271 KDBusAddons

REVISION DETAIL
  https://phabricator.kde.org/D9480

To: habacker, dfaure, kfunk
Cc: #frameworks

D9480: Add cmake function 'kdbusaddons_generate_dbus_service_file'

2017-12-22 Thread Ralf Habacker 
habacker created this revision.
habacker added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.

REVISION SUMMARY
  This function is added to hide platform-specific implementation details
  when creating dbus service files.

TEST PLAN
  - compiled and installed on unix
  - build patched kded sorce with this support
  - Files on windows are created as expected

REPOSITORY
  R271 KDBusAddons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9480

AFFECTED FILES
  CMakeLists.txt
  KF5DBusAddonsConfig.cmake.in
  KF5DBusAddonsMacros.cmake
  dbus.service.in

To: habacker, dfaure
Cc: #frameworks