Re: Exporting KFilePlaceEditDialog
On Sun, Feb 19, 2017 at 6:51 PM, Albert Astals Cid wrote: > El diumenge, 19 de febrer de 2017, a les 13:02:24 CET, Elvis Angelaccio va > escriure: >> Hi, >> currently KFilePlaceEditDialog is not exported by kfilewidgets. As I >> understand it, it's supposed to be used only through KFilePlacesView >> (that's what gwenview and konqueror do). >> >> However, Dolphin is using its own implementation of >> KFilePlacesModel/KFilePlacesView. This is why Dolphin has its own >> dialog to edit places, which is exactly the same as >> KFilePlaceEditDialog but with more bugs, e.g. see [1]. >> >> Could we make KFilePlaceEditDialog a public class? I don't really see >> downsides in doing this. We reduce code duplication (by killing the >> buggy Dolphin dialog) and Dolphin can still use its own model/view >> places stuff (I tested it localy and seems to work). > > The other option is improving KFilePlacesModel/KFilePlacesView so that Dolphin > can use it. > > Without knowing about them (which i don't) can't say what's better. > > Do you know what is stopping Dolphin using KFilePlacesModel/KFilePlacesView ? The timeline:/ and search:/ urls mostly. There is also a grouping feature but I'm not sure how that works. Though I agree that in the long-term it would be better to improve the upstream KFilePlacesModel/View... > > Cheers, > Albert > >> >> Cheers, >> Elvis >> >> [1]: https://bugs.kde.org/show_bug.cgi?id=376619 > >
Re: Exporting KFilePlaceEditDialog
El diumenge, 19 de febrer de 2017, a les 13:02:24 CET, Elvis Angelaccio va escriure: > Hi, > currently KFilePlaceEditDialog is not exported by kfilewidgets. As I > understand it, it's supposed to be used only through KFilePlacesView > (that's what gwenview and konqueror do). > > However, Dolphin is using its own implementation of > KFilePlacesModel/KFilePlacesView. This is why Dolphin has its own > dialog to edit places, which is exactly the same as > KFilePlaceEditDialog but with more bugs, e.g. see [1]. > > Could we make KFilePlaceEditDialog a public class? I don't really see > downsides in doing this. We reduce code duplication (by killing the > buggy Dolphin dialog) and Dolphin can still use its own model/view > places stuff (I tested it localy and seems to work). The other option is improving KFilePlacesModel/KFilePlacesView so that Dolphin can use it. Without knowing about them (which i don't) can't say what's better. Do you know what is stopping Dolphin using KFilePlacesModel/KFilePlacesView ? Cheers, Albert > > Cheers, > Elvis > > [1]: https://bugs.kde.org/show_bug.cgi?id=376619
Exporting KFilePlaceEditDialog
Hi, currently KFilePlaceEditDialog is not exported by kfilewidgets. As I understand it, it's supposed to be used only through KFilePlacesView (that's what gwenview and konqueror do). However, Dolphin is using its own implementation of KFilePlacesModel/KFilePlacesView. This is why Dolphin has its own dialog to edit places, which is exactly the same as KFilePlaceEditDialog but with more bugs, e.g. see [1]. Could we make KFilePlaceEditDialog a public class? I don't really see downsides in doing this. We reduce code duplication (by killing the buggy Dolphin dialog) and Dolphin can still use its own model/view places stuff (I tested it localy and seems to work). Cheers, Elvis [1]: https://bugs.kde.org/show_bug.cgi?id=376619
