Re: KDE Telepathy has an unreleased dependency
El Divendres, 27 de febrer de 2015, a les 12:36:21, Martin Klapetek va escriure: On Fri, Feb 27, 2015 at 2:07 AM, Albert Astals Cid aa...@kde.org wrote: So we still need a KPeople release, which is still in playground so noone has properly reviewed it, and you want to speed-turn it into a frameworks in 1 day. Do you actually have anyone to review it in such notice? At least sanitize the headers? It was requested on February 13th for KPeople to be reviewed and joined frameworks for 5.8. Today the 2 weeks review period is over so if there are no outstanding issues it should be moved today. The only issue is that the release won't be available for the first two betas while we could simply release KPeople a bit sooner so KDE Telepathy would be in the betas. This feels like rush, rush and rush. KDE Applications schedule has been set for months, I've sent various reminders about the freeze dates, and yet, here we are, post freeze with unresolved issues, why are we doing this now and not last week? I've started the discussion about moving it on February 3rd. There's about 15 repos and about 3000 dependencies. I'm sorry if I managed to miss one while trying to fix everything for the release (and mind you that the number of KTp developers pretty much reduced to one). I'm sorry that nobody caught this in the review period for about a month. We're clearly all just people with just enough free time. More reason to start the move eariler than at the last minute, but that's something unfixable now, maybe you can have it in mind for the next time :) If you feel like it should not be part of KDE Apps 15.04, fine, just say so and I'll request a move of everything back. I just want to make sure we don't rush stuff and we get bad reviews and comments because we rushed at the last minute. You tell me it's good, I believe you. Albert Cheers ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KDE Telepathy has an unreleased dependency
On Fri, Feb 27, 2015 at 2:07 AM, Albert Astals Cid aa...@kde.org wrote: So we still need a KPeople release, which is still in playground so noone has properly reviewed it, and you want to speed-turn it into a frameworks in 1 day. Do you actually have anyone to review it in such notice? At least sanitize the headers? It was requested on February 13th for KPeople to be reviewed and joined frameworks for 5.8. Today the 2 weeks review period is over so if there are no outstanding issues it should be moved today. The only issue is that the release won't be available for the first two betas while we could simply release KPeople a bit sooner so KDE Telepathy would be in the betas. This feels like rush, rush and rush. KDE Applications schedule has been set for months, I've sent various reminders about the freeze dates, and yet, here we are, post freeze with unresolved issues, why are we doing this now and not last week? I've started the discussion about moving it on February 3rd. There's about 15 repos and about 3000 dependencies. I'm sorry if I managed to miss one while trying to fix everything for the release (and mind you that the number of KTp developers pretty much reduced to one). I'm sorry that nobody caught this in the review period for about a month. We're clearly all just people with just enough free time. If you feel like it should not be part of KDE Apps 15.04, fine, just say so and I'll request a move of everything back. Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KDE Telepathy has an unreleased dependency
On Thu, Feb 26, 2015 at 4:22 PM, Vishesh Handa m...@vhanda.in wrote: On Wed, Feb 25, 2015 at 6:39 PM, Martin Klapetek martin.klape...@gmail.com wrote: As I said it's not even being used right now, so imho would be fine if it got removed/disabled altogether. Also, it will never work. Baloo KF5, has no knowledge about emails. That code also uses Akonadi APIs. There, I fixed it. https://git.reviewboard.kde.org/r/122729/ Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KDE Telepathy has an unreleased dependency
On Wed, Feb 25, 2015 at 6:39 PM, Martin Klapetek martin.klape...@gmail.com wrote: As I said it's not even being used right now, so imho would be fine if it got removed/disabled altogether. Also, it will never work. Baloo KF5, has no knowledge about emails. That code also uses Akonadi APIs. -- Vishesh Handa ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KDE Telepathy has an unreleased dependency
El Dijous, 26 de febrer de 2015, a les 16:55:17, Martin Klapetek va escriure: On Thu, Feb 26, 2015 at 4:22 PM, Vishesh Handa m...@vhanda.in wrote: On Wed, Feb 25, 2015 at 6:39 PM, Martin Klapetek martin.klape...@gmail.com wrote: As I said it's not even being used right now, so imho would be fine if it got removed/disabled altogether. Also, it will never work. Baloo KF5, has no knowledge about emails. That code also uses Akonadi APIs. There, I fixed it. https://git.reviewboard.kde.org/r/122729/ Cheers So we still need a KPeople release, which is still in playground so noone has properly reviewed it, and you want to speed-turn it into a frameworks in 1 day. Do you actually have anyone to review it in such notice? At least sanitize the headers? This feels like rush, rush and rush. KDE Applications schedule has been set for months, I've sent various reminders about the freeze dates, and yet, here we are, post freeze with unresolved issues, why are we doing this now and not last week? Albert ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KDE Telepathy has an unreleased dependency
On Wed, Feb 25, 2015 at 2:04 AM, Albert Astals Cid aa...@kde.org wrote: El Dimarts, 24 de febrer de 2015, a les 11:52:55, Martin Klapetek va escriure: I just realized that one of the main dependencies, KPeople, will be released only after KDE Applications Beta 2 as it's targeting KF 5.8 (released 12th March while KDE Apps Beta 2 is released 11th March). I'm not sure what should be done in this case; we could perhaps move the 5.8 release two days earlier, but this would still miss Beta 1. So uhh...what should we do? I can see three options: a) Do not release KPeople as part of frameworks but as part of KDE Applications 15.04 (and move it later to frameworks) b) Do not release KDE Telepathy as part of KDE Applications 15.04 c) Give KDE Telepathy an exception to only join on Beta 3 of KDE Applications 15.04 a) will make packagers unhappy because we'd move something around again, creating more friction and confusion b) is bad since KDE Telepathy fills a hole in our KF5-based series of apps So i'd say let's go c) even if it makes me very unhappy that we have to resort to that. Other opinions? Cheers, Albert Cheers At the moment KPeople is an optional dependency, there's still the possibility to use it without KPeople. This shouldn't be a show-stopper, even less for the Beta versions. Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KDE Telepathy has an unreleased dependency
On Wed, Feb 25, 2015 at 9:15 AM, David Faure fa...@kde.org wrote: On Wednesday 25 February 2015 02:04:58 Albert Astals Cid wrote: El Dimarts, 24 de febrer de 2015, a les 11:52:55, Martin Klapetek va escriure: I just realized that one of the main dependencies, KPeople, will be released only after KDE Applications Beta 2 as it's targeting KF 5.8 (released 12th March while KDE Apps Beta 2 is released 11th March). I'm not sure what should be done in this case; we could perhaps move the 5.8 release two days earlier, but this would still miss Beta 1. So uhh...what should we do? I can see three options: a) Do not release KPeople as part of frameworks but as part of KDE Applications 15.04 (and move it later to frameworks) b) Do not release KDE Telepathy as part of KDE Applications 15.04 c) Give KDE Telepathy an exception to only join on Beta 3 of KDE Applications 15.04 I see a fourth option: d) make a KPeople 5.7 release NOW If it's ready, I can make that happen with two commands or so. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 Makes sense to me. +2 Aleix ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KDE Telepathy has an unreleased dependency
On Wed, Feb 25, 2015 at 6:33 PM, David Faure fa...@kde.org wrote: On Wednesday 25 February 2015 15:38:19 Aleix Pol wrote: At the moment KPeople is an optional dependency, there's still the possibility to use it without KPeople. I guess you mean s/KPeople/Baloo/g here. No this was actually KPeople being optional dep of KTp, but the truth is that all the code is actually only tested with KPeople as that's pretty much what we're aiming for in the past couple years (but KPeople went through many many changes, it started as Nepomuk thing, then akonadi, now it's self-contained, so we never wanted to hard-depend on it). Now we've optimized everything for KPeople usage so imho it makes only sense to not discard it now and in fact make it finally a hard-dependency of KDE Telepathy. The problem is: Baloo depends on a few frameworks, and now we would have KPeople depending on Baloo. So it wouldn't be possible to build all of frameworks together, one would need to interject Baloo in the middle of it, in order to be able to build with all options i.e. with this optional dependency. The reason it's optional so it doesn't matter means you might as well delete the code, since it becomes impractical to build it anyway. More seriously I would suggest moving the plugin to Baloo maybe, if it makes sense for it to depend on KPeople, or moving it in workspace maybe (but then it's not available in other workspaces). Or to this new product (set of modules) that I think we should have to host drkonqi, kio-extras etc., i.e. the set of runtime deps common to workspace and applications. This issue keeps popping up. If you want a short term solution, I'd say the plugin should stay in playground somewhere. I don't like the optional dependency thing because it will still show up in dependency diagrams, making a mess with baloo being in the middle of frameworks while it was decided that it's not. As I said it's not even being used right now, so imho would be fine if it got removed/disabled altogether. Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KDE Telepathy has an unreleased dependency
On Wednesday 25 February 2015 15:38:19 Aleix Pol wrote: At the moment KPeople is an optional dependency, there's still the possibility to use it without KPeople. I guess you mean s/KPeople/Baloo/g here. The problem is: Baloo depends on a few frameworks, and now we would have KPeople depending on Baloo. So it wouldn't be possible to build all of frameworks together, one would need to interject Baloo in the middle of it, in order to be able to build with all options i.e. with this optional dependency. The reason it's optional so it doesn't matter means you might as well delete the code, since it becomes impractical to build it anyway. More seriously I would suggest moving the plugin to Baloo maybe, if it makes sense for it to depend on KPeople, or moving it in workspace maybe (but then it's not available in other workspaces). Or to this new product (set of modules) that I think we should have to host drkonqi, kio-extras etc., i.e. the set of runtime deps common to workspace and applications. This issue keeps popping up. If you want a short term solution, I'd say the plugin should stay in playground somewhere. I don't like the optional dependency thing because it will still show up in dependency diagrams, making a mess with baloo being in the middle of frameworks while it was decided that it's not. This shouldn't be a show-stopper, even less for the Beta versions. KF 5.x isn't a beta. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KDE Telepathy has an unreleased dependency
On Wed, Feb 25, 2015 at 10:10 AM, David Faure fa...@kde.org wrote: On Wednesday 25 February 2015 09:53:11 I wrote: If it's ready, I can make that happen with two commands or so. OK, it's not ready though. * It needs to be moved from playground/network to frameworks * It doesn't have the same KF version number stuff that other frameworks have (for updating its number and its deps number automatically) Oh and show stopper: it depends on baloo, which was refused as a framework Hmm, that's a minor dependency though, it's just one widget file which is currently unused afaik. And it's a plugin, so could just be disabled/moved elsewhere/made optional. Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KDE Telepathy has an unreleased dependency
On Wednesday 25 February 2015 09:53:11 I wrote: If it's ready, I can make that happen with two commands or so. OK, it's not ready though. * It needs to be moved from playground/network to frameworks * It doesn't have the same KF version number stuff that other frameworks have (for updating its number and its deps number automatically) Oh and show stopper: it depends on baloo, which was refused as a framework Man, what a mess we're putting ourselves into. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KDE Telepathy has an unreleased dependency
On Wed, Feb 25, 2015 at 9:15 AM, David Faure fa...@kde.org wrote: On Wednesday 25 February 2015 02:04:58 Albert Astals Cid wrote: El Dimarts, 24 de febrer de 2015, a les 11:52:55, Martin Klapetek va escriure: I just realized that one of the main dependencies, KPeople, will be released only after KDE Applications Beta 2 as it's targeting KF 5.8 (released 12th March while KDE Apps Beta 2 is released 11th March). I'm not sure what should be done in this case; we could perhaps move the 5.8 release two days earlier, but this would still miss Beta 1. So uhh...what should we do? I can see three options: a) Do not release KPeople as part of frameworks but as part of KDE Applications 15.04 (and move it later to frameworks) b) Do not release KDE Telepathy as part of KDE Applications 15.04 c) Give KDE Telepathy an exception to only join on Beta 3 of KDE Applications 15.04 I see a fourth option: d) make a KPeople 5.7 release NOW If it's ready, I can make that happen with two commands or so. I had this very idea in the morning. Aleix is the maintainer so he should +2 this but definitely +1 from me. Cheers -- Martin Klapetek | KDE Developer ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KDE Telepathy has an unreleased dependency
On Wednesday 25 February 2015 02:04:58 Albert Astals Cid wrote: El Dimarts, 24 de febrer de 2015, a les 11:52:55, Martin Klapetek va escriure: I just realized that one of the main dependencies, KPeople, will be released only after KDE Applications Beta 2 as it's targeting KF 5.8 (released 12th March while KDE Apps Beta 2 is released 11th March). I'm not sure what should be done in this case; we could perhaps move the 5.8 release two days earlier, but this would still miss Beta 1. So uhh...what should we do? I can see three options: a) Do not release KPeople as part of frameworks but as part of KDE Applications 15.04 (and move it later to frameworks) b) Do not release KDE Telepathy as part of KDE Applications 15.04 c) Give KDE Telepathy an exception to only join on Beta 3 of KDE Applications 15.04 I see a fourth option: d) make a KPeople 5.7 release NOW If it's ready, I can make that happen with two commands or so. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KDE Telepathy has an unreleased dependency
El Dimarts, 24 de febrer de 2015, a les 11:52:55, Martin Klapetek va escriure: I just realized that one of the main dependencies, KPeople, will be released only after KDE Applications Beta 2 as it's targeting KF 5.8 (released 12th March while KDE Apps Beta 2 is released 11th March). I'm not sure what should be done in this case; we could perhaps move the 5.8 release two days earlier, but this would still miss Beta 1. So uhh...what should we do? I can see three options: a) Do not release KPeople as part of frameworks but as part of KDE Applications 15.04 (and move it later to frameworks) b) Do not release KDE Telepathy as part of KDE Applications 15.04 c) Give KDE Telepathy an exception to only join on Beta 3 of KDE Applications 15.04 a) will make packagers unhappy because we'd move something around again, creating more friction and confusion b) is bad since KDE Telepathy fills a hole in our KF5-based series of apps So i'd say let's go c) even if it makes me very unhappy that we have to resort to that. Other opinions? Cheers, Albert Cheers ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
