Re: KF5 Porting: Installing Icons
On Friday 25 July 2014 02:52:09 Eike Hein wrote: On 07/24/2014 08:35 PM, Alex Merry wrote: As Jonathan said, yes, you are correct. And, yes, I should really write a porting script for that. Yay! That's the excuse I needed to avoid fixing Konvi's icon installs until your script is ready ;) Thanks to David Narváez, there is now such a script. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Porting: Installing Icons
On Wednesday 23 July 2014 18:08:42 David Narvaez wrote: Hi, The information at [0] seems to indicate I just need to worry about renaming files to match the new categories (btw, is there a script for that?) but what I get from CMake Warning (dev) at /usr/share/ECM/modules/ECMInstallIcons.cmake:205 (message): ecm_install_icons() with no ICONS argument is deprecated Call Stack (most recent call first): icons/CMakeLists.txt:2 (ecm_install_icons) This warning is for project developers. Use -Wno-dev to suppress it. is that I need to update to # ecm_install_icons(ICONS icon [icon [...]] # DESTINATION icon_install_dir # [LANG l10n_code] # [THEME theme]) which seems to me like I need to explicitly list all icons in the dir, and # The given icons, whose names must match the pattern:: # # size-group-name.ext seems to indicate I need to rename all of the files to remove the theme from the prefix. Am I correct? Should I update the wiki with the complete oddyssey to a correct ecm_install_icions? As Jonathan said, yes, you are correct. And, yes, I should really write a porting script for that. Alex ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Porting: Installing Icons
On 07/24/2014 08:35 PM, Alex Merry wrote: As Jonathan said, yes, you are correct. And, yes, I should really write a porting script for that. Yay! That's the excuse I needed to avoid fixing Konvi's icon installs until your script is ready ;) Alex Cheers, Eike ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Porting: Installing Icons
On Thu, Jul 24, 2014 at 2:35 PM, Alex Merry alex.me...@kde.org wrote: As Jonathan said, yes, you are correct. And, yes, I should really write a porting script for that. Thanks for the confirmation, I just posted https://git.reviewboard.kde.org/r/119457/ David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
KF5 Porting: Installing Icons
Hi, The information at [0] seems to indicate I just need to worry about renaming files to match the new categories (btw, is there a script for that?) but what I get from CMake Warning (dev) at /usr/share/ECM/modules/ECMInstallIcons.cmake:205 (message): ecm_install_icons() with no ICONS argument is deprecated Call Stack (most recent call first): icons/CMakeLists.txt:2 (ecm_install_icons) This warning is for project developers. Use -Wno-dev to suppress it. is that I need to update to # ecm_install_icons(ICONS icon [icon [...]] # DESTINATION icon_install_dir # [LANG l10n_code] # [THEME theme]) which seems to me like I need to explicitly list all icons in the dir, and # The given icons, whose names must match the pattern:: # # size-group-name.ext seems to indicate I need to rename all of the files to remove the theme from the prefix. Am I correct? Should I update the wiki with the complete oddyssey to a correct ecm_install_icions? David E. Narvaez [0] https://community.kde.org/Frameworks/Porting_Notes#Installing_Icons ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Porting: Installing Icons
On Wed, Jul 23, 2014 at 06:08:42PM -0400, David Narvaez wrote: This warning is for project developers. Use -Wno-dev to suppress it. is that I need to update to which seems to me like I need to explicitly list all icons in the dir, and Yes you are advised to use the new install function as it says # The given icons, whose names must match the pattern:: # # size-group-name.ext seems to indicate I need to rename all of the files to remove the theme from the prefix. Keep the theme name, preferably use hicolor for icons that are app specific. Am I correct? Should I update the wiki with the complete oddyssey to a correct ecm_install_icions? Maybe list it at https://techbase.kde.org/Development/ECM_SourceIncompatChanges Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Porting: Installing Icons
On Wed, Jul 23, 2014 at 6:20 PM, Jonathan Riddell j...@jriddell.org wrote: # The given icons, whose names must match the pattern:: # # size-group-name.ext seems to indicate I need to rename all of the files to remove the theme from the prefix. Keep the theme name, preferably use hicolor for icons that are app specific. According to the documentation, that now goes to the THEME option? Am I correct? Should I update the wiki with the complete oddyssey to a correct ecm_install_icions? Maybe list it at https://techbase.kde.org/Development/ECM_SourceIncompatChanges Will do. David E. Narvaez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: KF5 Porting: Installing Icons
On Wed, Jul 23, 2014 at 06:23:32PM -0400, David Narvaez wrote: On Wed, Jul 23, 2014 at 6:20 PM, Jonathan Riddell j...@jriddell.org wrote: # The given icons, whose names must match the pattern:: # # size-group-name.ext seems to indicate I need to rename all of the files to remove the theme from the prefix. Keep the theme name, preferably use hicolor for icons that are app specific. According to the documentation, that now goes to the THEME option? Well spotted, I missed that. Sure update the wiki docs. Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
