Re: KIO on Android Failure

2020-08-20 Thread Ben Cooksley
On Thu, Aug 20, 2020 at 8:00 AM David Faure  wrote:
>
> On mardi 18 août 2020 13:52:50 CEST Ben Cooksley wrote:
> > Hi all,
> >
> > At some point recently functionality was added to KIO which broke the
> > build on Android.
>
> Is there any reason why Android doesn't appear at
> https://build.kde.org/job/Frameworks/job/kio/
> ?
>
> This is the reason why I didn't notice this problem.

Because a job hasn't been requested for KIO on Android.

I'm not sure why it is being included in the Dependency Builds /
Docker image builds, as from my understanding Android builds were all
using a cut down list of dependencies.

We can certainly enable Android CI jobs for KIO though, that is easy
enough to do.

Cheers,
Ben

>
> --
> David Faure, fa...@kde.org, http://www.davidfaure.fr
> Working on KDE Frameworks 5
>
>
>


Re: KIO on Android Failure

2020-08-19 Thread David Faure
On mardi 18 août 2020 13:52:50 CEST Ben Cooksley wrote:
> Hi all,
> 
> At some point recently functionality was added to KIO which broke the
> build on Android.

Is there any reason why Android doesn't appear at
https://build.kde.org/job/Frameworks/job/kio/
?

This is the reason why I didn't notice this problem.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5





Re: KIO on Android Failure

2020-08-19 Thread Ben Cooksley
On Wed, Aug 19, 2020 at 3:01 AM Ahmad Samir  wrote:
>
> On 18/08/2020 13:52, Ben Cooksley wrote:
> > Hi all,
> >
> > At some point recently functionality was added to KIO which broke the
> > build on Android.
> >
> > I'm not sure why we're building KIO on Android, but it appears that
> > some applications may be using it - and this in turn causes the
> > Dependency Build jobs to fail.
> >
> > Could someone take a look please?
> > https://build.kde.org/job/Administration/job/Docker%20Generate%20AndroidQt5.14%20KF5-SDK/lastFailedBuild/console
> >
> > Thanks,
> > Ben
> >
>
> It looks like it's caused by systemd integration in kprocessrunner; also it 
> seems Q_OS_UNIX includes
> Android systems, so we need to guard it with !defind(Q_OS_ANDROID). Should 
> hopefully be fixed by
> https://invent.kde.org/frameworks/kio/-/merge_requests/107 .
>

Many thanks for quickly addressing this Ahmad, it's appreciated.

Cheers,
Ben

> --
> Ahmad Samir


Re: KIO on Android Failure

2020-08-18 Thread Ahmad Samir

On 18/08/2020 13:52, Ben Cooksley wrote:

Hi all,

At some point recently functionality was added to KIO which broke the
build on Android.

I'm not sure why we're building KIO on Android, but it appears that
some applications may be using it - and this in turn causes the
Dependency Build jobs to fail.

Could someone take a look please?
https://build.kde.org/job/Administration/job/Docker%20Generate%20AndroidQt5.14%20KF5-SDK/lastFailedBuild/console

Thanks,
Ben



It looks like it's caused by systemd integration in kprocessrunner; also it seems Q_OS_UNIX includes 
Android systems, so we need to guard it with !defind(Q_OS_ANDROID). Should hopefully be fixed by 
https://invent.kde.org/frameworks/kio/-/merge_requests/107 .


--
Ahmad Samir


KIO on Android Failure

2020-08-18 Thread Ben Cooksley
Hi all,

At some point recently functionality was added to KIO which broke the
build on Android.

I'm not sure why we're building KIO on Android, but it appears that
some applications may be using it - and this in turn causes the
Dependency Build jobs to fail.

Could someone take a look please?
https://build.kde.org/job/Administration/job/Docker%20Generate%20AndroidQt5.14%20KF5-SDK/lastFailedBuild/console

Thanks,
Ben