Re: OSX/CI: kio placed files erroneously due to missing required backslash in path
Hi, 2014-12-23 9:44 GMT+01:00 David Faure: On Tuesday 23 December 2014 00:59:56 Marko Käning wrote: Fixed in http://commits.kde.org/kio/c5522b6931908d3fd8ad97555a3edf2a3e859b50 Ooops, should I have pushed this through Gerrit before committing? Nope, that's fine, trivial fix. Thanks! Wouldn't it be better to use QDir::separator() though, in order to make sure that it works on non-Unix operating systems? Cheers, Frank ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kio placed files erroneously due to missing required backslash in path
On Sunday 28 December 2014 22:54:51 Frank Reininghaus wrote: Hi, 2014-12-23 9:44 GMT+01:00 David Faure: On Tuesday 23 December 2014 00:59:56 Marko Käning wrote: Fixed in http://commits.kde.org/kio/c5522b6931908d3fd8ad97555a3edf2a3e859b50 Ooops, should I have pushed this through Gerrit before committing? Nope, that's fine, trivial fix. Thanks! Wouldn't it be better to use QDir::separator() though, in order to make sure that it works on non-Unix operating systems? This seems to be a very common misconception All of the Qt API works fine with forward slashes. The Windows file-engine in Qt takes care of converting if necessary for the underlying native calls, but Qt encapsulates all of that for us, in order to make application development much easier. You only need to use QDir::separator() well, never, mostly ;) If you want to display a path to the user you can use QDir::toNativeSeparators() and when reading a path from the user you can use QDir::fromNativeSeparators(). Anyway, in this commit we're not talking about user-visible stuff, so '/' is perfectly fine. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: OSX/CI: kio placed files erroneously due to missing required backslash in path
On Tuesday 23 December 2014 00:59:56 Marko Käning wrote: Fixed in http://commits.kde.org/kio/c5522b6931908d3fd8ad97555a3edf2a3e859b50 Ooops, should I have pushed this through Gerrit before committing? Nope, that's fine, trivial fix. Thanks! -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
OSX/CI: kio placed files erroneously due to missing required backslash in path
Hi,
on OSX it looks like some app places files directly in ~/Library, as it
misses to insert a backslash in between the standard location
~/Library/Application Support” and the 3 files (user-places.xbel*) to be
generated in there:
---
$ ls -l1 Library/Application\ Supportuser-places.xbel*
-rw--- 1 marko staff 245 Dec 10 03:23 Library/Application
Supportuser-places.xbel
-rw--- 1 marko staff 512 Dec 10 03:23 Library/Application
Supportuser-places.xbel.bak
-rw--- 1 marko staff 0 Dec 10 03:23 Library/Application
Supportuser-places.xbel.tbcache
---
Grep-ing the whole code base to figure out which app caused this shows:
---
$ find WC/KDECI-builds/ -name *.cpp -exec grep -H user-places.xbel {} \;
WC/KDECI-builds/kbookmarks/autotests/kbookmarktest.cpp:const QString
placesFile = datadir + /user-places.xbel;
WC/KDECI-builds/kio/src/filewidgets/kfileplacesmodel.cpp://
~/.local/share/user-places.xbel (according to freedesktop bookmarks spec), and
WC/KDECI-builds/kio/src/filewidgets/kfileplacesmodel.cpp://
user-places.xbel will be filled later). (ereslibre)
WC/KDECI-builds/kio/src/filewidgets/kfileplacessharedbookmarks.cpp:const
QString file = datadir + user-places.xbel;
—--
where the last line reveals the culprit as being kio!
Fixed in
http://commits.kde.org/kio/c5522b6931908d3fd8ad97555a3edf2a3e859b50
Ooops, should I have pushed this through Gerrit before committing?
Greets,
Marko
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
