Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

[David Faure]

On Monday 05 October 2015 21:24:34 Marko Käning wrote:
> Well, I know, I could simply make my Portfile use a patch file…
> 
> On 05 Oct 2015, at 21:18 , Marko Käning  wrote:
> > I’d suggest a 5.14.1 for the kdesignerplugin, which contains Kurt’s fix:
> 
> … or simply wait a a tiny bit longer…
> 
> Perhaps that’s less hassle then you trying to do create a another tiny 
> release step
> for this framework given that you’ll come up within the next few days with 
> new version
> 5.15.0 anyways!

Yes the release of 5.15.0 is in progress already.
You can check out the v5.15.0-rc1 tag in each repo, or wait until the end of 
the week.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

[Marko Käning]

Hi David,

now that I learnt, that we can have bug-fix releases in already released KF5 
versions,
I’d suggest a 5.14.1 for the kdesignerplugin, which contains Kurt’s fix:

On 18 Sep 2015, at 20:42 , Marko Käning  wrote:

> Dear Kurt,
> 
> On 16 Sep 2015, at 15:20 , Kurt Hindenburg  wrote:
>> Git commit 6cbf534c3cd2c5bdda819e092c9778c27e814161 by Kurt Hindenburg.
> 
> thanks for your commit!
> 
> Looking forward to release 5.15 then, David.
> :)

That would finally allow me to test the 5.14 on a MacPorts-based OSX VM.

What do you think about that?

Greets,
Marko

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

[Marko Käning]

Well, I know, I could simply make my Portfile use a patch file…

On 05 Oct 2015, at 21:18 , Marko Käning  wrote:
> I’d suggest a 5.14.1 for the kdesignerplugin, which contains Kurt’s fix:

… or simply wait a a tiny bit longer…

Perhaps that’s less hassle then you trying to do create a another tiny release 
step
for this framework given that you’ll come up within the next few days with new 
version
5.15.0 anyways!

:)
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

[Marko Käning]

Dear Kurt,

On 16 Sep 2015, at 15:20 , Kurt Hindenburg  wrote:
> Git commit 6cbf534c3cd2c5bdda819e092c9778c27e814161 by Kurt Hindenburg.

thanks for your commit!

Looking forward to release 5.15 then, David.
:)

Greets,
Marko
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

[David Faure]

On Tuesday 15 September 2015 22:50:50 Kurt Hindenburg wrote:
> 
> > On Sep 15, 2015, at 2:07 PM, Marko Käning  wrote:
> > 
> > Hi kdesignerplugin devs,
> > 
> > On 14 Sep 2015, at 15:00 , Kurt Hindenburg  
> > wrote:
> >> 
> >> It appears the  QT_VERSION check in 
> >> d53ec9b97d7b353ea4cce54d5ecae3c93b933ddd is not enough when using Qt 5.4.x
> > 
> > anyone out there who can fix kdesignerplugin regarding this version check 
> > so that the next KF5 release is build-able again on Qt 5.4.x?
> > 
> If I read the Qt moc docs correctly, moc can’t expand macros.  So it never 
> actually handles the #if.
> 
> The quick and dirty hack is to put the #if outside the static const, which 
> means duplicating most of the static const.  It works here for Qt 5.4.x.  
> There is likely a more elegant way of doing it.

Try this:
#if QT_VERSION >= 0x050500

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

[Kurt Hindenburg]

> On Sep 16, 2015, at 2:54 AM, David Faure  wrote:
> 
> On Tuesday 15 September 2015 22:50:50 Kurt Hindenburg wrote:
>> 
>>> On Sep 15, 2015, at 2:07 PM, Marko Käning  wrote:
>>> 
>>> Hi kdesignerplugin devs,
>>> 
>>> On 14 Sep 2015, at 15:00 , Kurt Hindenburg  
>>> wrote:
 
 It appears the  QT_VERSION check in 
 d53ec9b97d7b353ea4cce54d5ecae3c93b933ddd is not enough when using Qt 5.4.x
>>> 
>>> anyone out there who can fix kdesignerplugin regarding this version check 
>>> so that the next KF5 release is build-able again on Qt 5.4.x?
>>> 
>> If I read the Qt moc docs correctly, moc can’t expand macros.  So it never 
>> actually handles the #if.
>> 
>> The quick and dirty hack is to put the #if outside the static const, which 
>> means duplicating most of the static const.  It works here for Qt 5.4.x.  
>> There is likely a more elegant way of doing it.
> 
> Try this:
> #if QT_VERSION >= 0x050500
> 

Thanks, that works for Qt 5.4.x; I don’t have a Qt5 install to check that.  
Should I commit or do a review-board item?

-"#if QT_VERSION >= QT_VERSION_CHECK(5, 5, 
0)\n"
+"#if QT_VERSION >= 0x050500\n"

  Kurt

> — 

> David Faure, fa...@kde.org , http://www.davidfaure.fr 
> 
> Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

[David Faure]

On Wednesday 16 September 2015 08:39:47 Kurt Hindenburg wrote:
> 
> Thanks, that works for Qt 5.4.x; I don’t have a Qt5 install to check that.  
> Should I commit or do a review-board item?
> 
> -"#if QT_VERSION >= QT_VERSION_CHECK(5, 
> 5, 0)\n"
> +"#if QT_VERSION >= 0x050500\n"

Please commit. 

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

[Kurt Hindenburg]

> On Sep 15, 2015, at 2:07 PM, Marko Käning  wrote:
> 
> Hi kdesignerplugin devs,
> 
> On 14 Sep 2015, at 15:00 , Kurt Hindenburg  wrote:
>> 
>> It appears the  QT_VERSION check in d53ec9b97d7b353ea4cce54d5ecae3c93b933ddd 
>> is not enough when using Qt 5.4.x
> 
> anyone out there who can fix kdesignerplugin regarding this version check so 
> that the next KF5 release is build-able again on Qt 5.4.x?
> 
If I read the Qt moc docs correctly, moc can’t expand macros.  So it never 
actually handles the #if.

The quick and dirty hack is to put the #if outside the static const, which 
means duplicating most of the static const.  It works here for Qt 5.4.x.  There 
is likely a more elegant way of doing it.


 Kurt


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

[Marko Käning]

Hi kdesignerplugin devs,

On 14 Sep 2015, at 15:00 , Kurt Hindenburg  wrote:
> 
> It appears the  QT_VERSION check in d53ec9b97d7b353ea4cce54d5ecae3c93b933ddd 
> is not enough when using Qt 5.4.x

anyone out there who can fix kdesignerplugin regarding this version check so 
that the next KF5 release is build-able again on Qt 5.4.x?

Greets,
Marko


P.S.: Thanks, Kurt, for investigating this! :)
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

[Kurt Hindenburg]

> On Sep 14, 2015, at 8:36 AM, Kurt Hindenburg  
> wrote:
> 
> 
>> On Sep 14, 2015, at 5:54 AM, Alex Merry  wrote:
>> 
>> On 2015-09-14 00:42, Kurt Hindenburg wrote:
 On Sep 13, 2015, at 5:43 PM, Marko Käning  wrote:
 Hi devs,
 the other day I had built version 5.13 successfully on a 
 OSX/MacPorts-based VM.
 And so I wanted to try the same with the newest 5.14 just now, but failed! 
 :(
 Any idea why those three interfaces are undefined?
>>> Hi,
>>> I just ran in this same issue - checking out tag v5.13.0 for
>>> kdesignerplugin and changing the version appears to work.
>> 
>> There have been two main changes since v5.13.0:
>> 
>> https://quickgit.kde.org/?p=kdesignerplugin.git=commit=2cc4b4e7bbe7c3a19616b422d536f5ee12f3
>> https://quickgit.kde.org/?p=kdesignerplugin.git=commit=d53ec9b97d7b353ea4cce54d5ecae3c93b933ddd
>> 
>> are one change (the second commit fixes the first for older Qt version), and
>> 
>> https://quickgit.kde.org/?p=kdesignerplugin.git=commit=7da71f38419b7f9a08498bf7e5d26ae8c8c6df8c
>> 
>> is the other. Could you please try rolling back to 
>> 4abac3309aca5e0dc751dcbbe48c5fc6587b1a11 (which is after the first change, 
>> and after the version bump, but before the second change) and seeing if that 
>> builds?
>> 
> 4abac3309aca5e0dc751dcbbe48c5fc6587b1a11 fails with the same issue
> 
> a01c112ed88d3fb180610ee3977cc13fd1231b5b works.
> 
> From the git log I would say 2cc4b4e7bbe7c3a19616b422d536f5ee12f3 is the 
> issue commit.
> 

It appears the  QT_VERSION check in d53ec9b97d7b353ea4cce54d5ecae3c93b933ddd is 
not enough when using Qt 5.4.x

Kurt
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

[Alex Merry]

On 2015-09-14 00:42, Kurt Hindenburg wrote:
On Sep 13, 2015, at 5:43 PM, Marko Käning  
wrote:


Hi devs,

the other day I had built version 5.13 successfully on a 
OSX/MacPorts-based VM.
And so I wanted to try the same with the newest 5.14 just now, but 
failed! :(


Any idea why those three interfaces are undefined?


Hi,
  I just ran in this same issue - checking out tag v5.13.0 for
kdesignerplugin and changing the version appears to work.


There have been two main changes since v5.13.0:

https://quickgit.kde.org/?p=kdesignerplugin.git=commit=2cc4b4e7bbe7c3a19616b422d536f5ee12f3
https://quickgit.kde.org/?p=kdesignerplugin.git=commit=d53ec9b97d7b353ea4cce54d5ecae3c93b933ddd

are one change (the second commit fixes the first for older Qt version), 
and


https://quickgit.kde.org/?p=kdesignerplugin.git=commit=7da71f38419b7f9a08498bf7e5d26ae8c8c6df8c

is the other. Could you please try rolling back to 
4abac3309aca5e0dc751dcbbe48c5fc6587b1a11 (which is after the first 
change, and after the version bump, but before the second change) and 
seeing if that builds?


Thanks

Alex
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Building KF in version 5.14 on OSX fails for framework kdesignerplugin

[Kurt Hindenburg]

> On Sep 13, 2015, at 5:43 PM, Marko Käning  wrote:
> 
> Hi devs,
> 
> the other day I had built version 5.13 successfully on a OSX/MacPorts-based 
> VM.
> And so I wanted to try the same with the newest 5.14 just now, but failed! :(
> 
> Any idea why those three interfaces are undefined?
> 
Hi,
  I just ran in this same issue - checking out tag v5.13.0 for kdesignerplugin 
and changing the version appears to work.
   Kurt

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel