Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 44 - Still Unstable!
On Monday 16 May 2016, David Faure wrote: > On Saturday, May 14, 2016 10:52:16 AM CEST no-re...@kde.org wrote: > > GENERAL INFO > > > > BUILD UNSTABLE > > Build URL: > > https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/ > > PLATFORM=Linux,Variation=All,compiler=gcc/44/ Project: > > PLATFORM=Linux,Variation=All,compiler=gcc > > Date of build: Sat, 14 May 2016 10:44:59 + > > Build duration: 6 min 19 sec > > > > Total: 14 test(s)Failed: TestSuite.plasma-themetest > > FAIL! : ThemeTest::loadSvgIcon() 'm_svg->isValid()' returned FALSE. () >Loc: [/home/jenkins/sources/plasma-framework/kf5-qt5/autotests/ > themetest.cpp(77)] this should fix it.. https://paste.kde.org/plgadpvs8 Harald, this is against your latest commit in kiconthemes, does this patch make sense to you? -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 44 - Still Unstable!
On Monday 16 May 2016, David Faure wrote: > > Can someone take a look? Can more precise checks be added before the > QVERIFY to ease debugging when this fails? > At least a QVERIFY2(QFile::exists(iconPath), qPrintable(iconPath)) would be > good, right? But what if iconTheme is null? Then for sure iconPath is > empty... from the last version, iconTheme is there, the iconTheme is valid as well, but iconPath is empty -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux,All,gcc - Build # 44 - Still Unstable!
On Monday 16 May 2016, David Faure wrote: > Can someone take a look? Can more precise checks be added before the > QVERIFY to ease debugging when this fails? > At least a QVERIFY2(QFile::exists(iconPath), qPrintable(iconPath)) would be > good, right? But what if iconTheme is null? Then for sure iconPath is > empty... added some more tests, let's see what they say -- Marco Martin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Jenkins-kde-ci: plasma-framework master stable-kf5-qt5 » Linux, All, gcc - Build # 44 - Still Unstable!
On Saturday, May 14, 2016 10:52:16 AM CEST no-re...@kde.org wrote:
> GENERAL INFO
>
> BUILD UNSTABLE
> Build URL:
> https://build.kde.org/job/plasma-framework%20master%20stable-kf5-qt5/
PLATFORM=Linux,Variation=All,compiler=gcc/44/ Project:
> PLATFORM=Linux,Variation=All,compiler=gcc
> Date of build: Sat, 14 May 2016 10:44:59 +
> Build duration: 6 min 19 sec
>
> Total: 14 test(s)Failed: TestSuite.plasma-themetest
FAIL! : ThemeTest::loadSvgIcon() 'm_svg->isValid()' returned FALSE. ()
Loc: [/home/jenkins/sources/plasma-framework/kf5-qt5/autotests/
themetest.cpp(77)]
Can someone take a look? Can more precise checks be added before the QVERIFY
to ease debugging when this fails?
At least a QVERIFY2(QFile::exists(iconPath), qPrintable(iconPath)) would be
good, right? But what if iconTheme is null? Then for sure iconPath is empty...
void ThemeTest::loadSvgIcon()
{
const auto *iconTheme = KIconLoader::global()->theme();
QString iconPath;
if (iconTheme) {
iconPath = iconTheme->iconPath(QLatin1String("konversation.svg"), 48,
KIconLoader::MatchBest);
}
m_svg->setImagePath(iconPath);
QVERIFY(m_svg->isValid());
--
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5
___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
