Re: KGlobalAccel regression in latest frameworks release
I've tagged v5.38.1 and released a tar with the change reverted. I've not reverted it in master branch so it will need to be fixed or reverted before 5.39.0 Jonthan
Re: KGlobalAccel regression in latest frameworks release
Oki, just KGlobalAccel seems fine, too. Ursprüngliche Nachricht Von: mgraess...@kde.org Gesendet: 13. September 2017 8:33 nachm. An: plasma-de...@kde.org; kde-frameworks-devel@kde.org Antworten: kde-frameworks-devel@kde.org Betreff: Re: KGlobalAccel regression in latest frameworks release Am 2017-09-13 20:28, schrieb Kai Uwe Broulik: > Hi, > > either of the following reverts fix the problem for me: > > KGlobalAccel: 2c20ddff034e4958bf0536ca91ae9e444955305d > > or > > KWindowSystem: 53ab31c663e63c18e30c69af445e9dd022a89acc and > 32526718eae99ccb594360627586eebdf793372b > > but perhaps both KGlobalAccel and KWindowSystem to be sure. If KGlobalAccel itself is enough, then only KGlobalAccel. KWindowSystem introduces new API so reverting would cause ABI issues in worst case. Cheers Martin
Re: KGlobalAccel regression in latest frameworks release
Am 2017-09-13 20:28, schrieb Kai Uwe Broulik: Hi, either of the following reverts fix the problem for me: KGlobalAccel: 2c20ddff034e4958bf0536ca91ae9e444955305d or KWindowSystem: 53ab31c663e63c18e30c69af445e9dd022a89acc and 32526718eae99ccb594360627586eebdf793372b but perhaps both KGlobalAccel and KWindowSystem to be sure. If KGlobalAccel itself is enough, then only KGlobalAccel. KWindowSystem introduces new API so reverting would cause ABI issues in worst case. Cheers Martin
Re: KGlobalAccel regression in latest frameworks release
Hi, either of the following reverts fix the problem for me: KGlobalAccel: 2c20ddff034e4958bf0536ca91ae9e444955305d or KWindowSystem: 53ab31c663e63c18e30c69af445e9dd022a89acc and 32526718eae99ccb594360627586eebdf793372b but perhaps both KGlobalAccel and KWindowSystem to be sure. Cheers Kai Uwe
Re: KGlobalAccel regression in latest frameworks release
Am 2017-09-13 19:06, schrieb Jonathan Riddell: This patch? https://phabricator.kde.org/D6234 I think reverting it for now and me or David can make a 5.38.1 release would be easiest Yes, that should be the change causing the issue. It could also be the change in KWindowSystem. Best would be someone on an X11 system to test what helps (maybe Kai-Uwe?). Cheers Martin Jonathan On Wed, Sep 13, 2017 at 06:23:48PM +0200, Martin Flöser wrote: Hi all, unfortunately I have to inform you that KGlobalAccel has a severe regression [1] in the latest framework release resulting in many shortcuts no longer functioning. As the current frameworks release is the one the next Plasma release is going to depend on, we need to act quickly. In the current state I would say a release of Plasma requiring this frameworks version is an absolute no-no, this is release blocking. I'm saying this as the maintainer of kglobalaccel and of the most affected application KWin. Following recommendations from my side: * distributions who have not yet shipped out the latest frameworks release should hold back kglobalaccel and maybe kwindowsystem * in KGlobalAccel we need to get a fix for it, I'm not able to provide it, though. * Otherwise I would suggest that the change in KGlobalAccel gets reverted Due to the fact that Plasma depends on this release we must act quickly and do a bug fix release for frameworks even if this is uncommon and against the practice. Sorry for any inconveniences. Martin Flöser KGlobalAccel maintainer [1] https://bugs.kde.org/show_bug.cgi?id=384597
Re: KGlobalAccel regression in latest frameworks release
This patch? https://phabricator.kde.org/D6234 I think reverting it for now and me or David can make a 5.38.1 release would be easiest Jonathan On Wed, Sep 13, 2017 at 06:23:48PM +0200, Martin Flöser wrote: > Hi all, > > unfortunately I have to inform you that KGlobalAccel has a severe > regression [1] in the latest framework release resulting in many > shortcuts no longer functioning. > > As the current frameworks release is the one the next Plasma release > is going to depend on, we need to act quickly. In the current state > I would say a release of Plasma requiring this frameworks version is > an absolute no-no, this is release blocking. I'm saying this as the > maintainer of kglobalaccel and of the most affected application > KWin. > > Following recommendations from my side: > * distributions who have not yet shipped out the latest frameworks > release should hold back kglobalaccel and maybe kwindowsystem > * in KGlobalAccel we need to get a fix for it, I'm not able to > provide it, though. > * Otherwise I would suggest that the change in KGlobalAccel gets > reverted > > Due to the fact that Plasma depends on this release we must act > quickly and do a bug fix release for frameworks even if this is > uncommon and against the practice. > > Sorry for any inconveniences. > > Martin Flöser > KGlobalAccel maintainer > > [1] https://bugs.kde.org/show_bug.cgi?id=384597
