Re: Quick Charts in KDE Review
On 07-11-2019 15:34, Friedrich W. H. Kossebau wrote: Am Montag, 21. Oktober 2019, 15:22:23 CET schrieb Arjen Hiemstra: Hi, Quick Charts has been moved to KDE review. The intent is to make it a Tier 1 framework. Any chance the official name can be "KQuickCharts"? "Quick Charts" is a generic name which only asks for being misunderstood, is hard to google etc.. Fair point. Since the repo is already kquickcharts, I will update the documentation to match. Quick Charts is a QML module that implements a set of high-performance, GPU accelerated charts. Currently the main user of it is a new KSysGuard UI I have been working on, but once it is part of Frameworks I also hope to convert several bits of Plasma to using it. If there is only one user currently, might it perhaps be a better idea to do some independent releases for a while to get more feedback on the API, before settling to the API freeze by being part of KDE Frameworks? It will be at least a year until KF6 is there to properly fix up any potential API inconveniences which users might find. I would at least recommend to first get some API shaping by real-world exposure. So there is one known user currently, KSysGuard. Additionally, there are several places in Plasma that I want to look at to use them. There is also the KInfoCenter energy information page where we want to look at using this. Additionally, there has been some interest from others. I do not know what Plasma's policy is regarding dependencies, but having it in Frameworks would make things quite a bit simpler to port existing things. The module has been in development for about 5 months at this point. We have been using it for the mentioned new KSysGuard UI as well as some other bits we want to upstream. At this point, I am fairly sure that any major API changes would amount to a "KF6" version anyway. I would rather commit to the stable API so that people will know there is no large chance of things suddenly changing from underneath them. - Arjen Sorry otherwise for not reviewing myself, not into QML the recent months. Cheers Friedrich
Re: Quick Charts in KDE Review
On 07-11-2019 15:24, Alexander Potashev wrote: чт, 7 нояб. 2019 г. в 13:53, Arjen Hiemstra : On 21-10-2019 15:22, Arjen Hiemstra wrote: > Hi, > > Quick Charts has been moved to KDE review. The intent is to make it a > Tier 1 framework. > > Quick Charts is a QML module that implements a set of > high-performance, GPU accelerated > charts. Currently the main user of it is a new KSysGuard UI I have > been working on, but > once it is part of Frameworks I also hope to convert several bits of > Plasma to using it. It has now been a little over two weeks. If there are no objections, I will move this to frameworks later today. Hi Arjen, Did anyone from the Plasma team approve the new KSysGuard UI? It is being developed together with several people from the Plasma team actually. :) It will also go through a separate review, but it needs Quick Charts to be ready before that can happen. - Arjen
Re: Quick Charts in KDE Review
Am Montag, 21. Oktober 2019, 15:22:23 CET schrieb Arjen Hiemstra: > Hi, > > Quick Charts has been moved to KDE review. The intent is to make it a > Tier 1 framework. Any chance the official name can be "KQuickCharts"? "Quick Charts" is a generic name which only asks for being misunderstood, is hard to google etc.. > Quick Charts is a QML module that implements a set of high-performance, > GPU accelerated > charts. Currently the main user of it is a new KSysGuard UI I have been > working on, but > once it is part of Frameworks I also hope to convert several bits of > Plasma to using it. If there is only one user currently, might it perhaps be a better idea to do some independent releases for a while to get more feedback on the API, before settling to the API freeze by being part of KDE Frameworks? It will be at least a year until KF6 is there to properly fix up any potential API inconveniences which users might find. I would at least recommend to first get some API shaping by real-world exposure. Sorry otherwise for not reviewing myself, not into QML the recent months. Cheers Friedrich
Re: Quick Charts in KDE Review
Approved in general, but we will cover that and any ported applets effectively ported from KDeclarative::Plotter in relevant separate review processes. David
Re: Quick Charts in KDE Review
чт, 7 нояб. 2019 г. в 13:53, Arjen Hiemstra : > > On 21-10-2019 15:22, Arjen Hiemstra wrote: > > Hi, > > > > Quick Charts has been moved to KDE review. The intent is to make it a > > Tier 1 framework. > > > > Quick Charts is a QML module that implements a set of > > high-performance, GPU accelerated > > charts. Currently the main user of it is a new KSysGuard UI I have > > been working on, but > > once it is part of Frameworks I also hope to convert several bits of > > Plasma to using it. > > It has now been a little over two weeks. If there are no objections, I > will move this to frameworks later today. Hi Arjen, Did anyone from the Plasma team approve the new KSysGuard UI? -- Alexander Potashev
Re: Quick Charts in KDE Review
On 21-10-2019 15:22, Arjen Hiemstra wrote: Hi, Quick Charts has been moved to KDE review. The intent is to make it a Tier 1 framework. Quick Charts is a QML module that implements a set of high-performance, GPU accelerated charts. Currently the main user of it is a new KSysGuard UI I have been working on, but once it is part of Frameworks I also hope to convert several bits of Plasma to using it. It has now been a little over two weeks. If there are no objections, I will move this to frameworks later today. - Arjen
Re: Quick Charts in KDE Review
On 22-10-2019 18:09, Luigi Toscano wrote: Jonathan Riddell ha scritto: There's a file called LICENSE which contains a copy of the LGPL 2.1 But all the files with an explicit licence seem to be GPL 2+3+KDEeV Please decide which licence you want to apply and if it's GPL 2+3+KDEeV remove LICENSE and put a copy of the GPL 2 called COPYING which is our normal practice. Also, if the goal is to make it part of Frameworks, it can't be GPL (but LGPL or less restrictive licenses). https://community.kde.org/Policies/Licensing_Policy Yeah, I knew that. It should've been LGPL 2.1+ all along, but apparently I copied the headers wrong. :) Now fixed, everything should be LGPL 2.1+ with EV exception. I have also renamed the license file to COPYING.
Re: Quick Charts in KDE Review
Jonathan Riddell ha scritto: > There's a file called LICENSE which contains a copy of the LGPL 2.1 > > But all the files with an explicit licence seem to be GPL 2+3+KDEeV > > Please decide which licence you want to apply and if it's GPL 2+3+KDEeV remove > LICENSE and put a copy of the GPL 2 called COPYING which is our normal > practice. > Also, if the goal is to make it part of Frameworks, it can't be GPL (but LGPL or less restrictive licenses). https://community.kde.org/Policies/Licensing_Policy -- Luigi
Re: Quick Charts in KDE Review
There's a file called LICENSE which contains a copy of the LGPL 2.1 But all the files with an explicit licence seem to be GPL 2+3+KDEeV Please decide which licence you want to apply and if it's GPL 2+3+KDEeV remove LICENSE and put a copy of the GPL 2 called COPYING which is our normal practice. Jonathan On Mon, 21 Oct 2019 at 14:39, Arjen Hiemstra wrote: > Hi, > > Quick Charts has been moved to KDE review. The intent is to make it a > Tier 1 framework. > > Quick Charts is a QML module that implements a set of high-performance, > GPU accelerated > charts. Currently the main user of it is a new KSysGuard UI I have been > working on, but > once it is part of Frameworks I also hope to convert several bits of > Plasma to using it. > > - Arjen >
Re: Quick Charts in KDE Review
On 21-10-2019 16:45, Alexander Potashev wrote: Hi Arjen, 1. I don't see any checks in the autotests. Would it be easy to compare the displayed chart against a reference screenshot image, in each of the tests? The same screenshots could also help developers understand what kind of charts kquickcharts is good for. They are very simple QML based tests that currently only verify that the main Chart types still get created correctly. It'd be nice to expand them, though I am slightly hesitant to go with image based tests as they tend to break easily. On the other hand, one of the main reasons for not having more extensive tests is that I did not have an idea on how to do that, and image based tests would solve part of that problem. 2. How to add a grid, ticks and labels to a line chart? For the grid and labels, these are what I generally refer to as "decorations". These are implemented as separate items that you use the normal QML layout options with to layout. You can have a look at controls/LineChartControl.qml to see how it is done for a Line chart. I still need to write some better examples for this, but the control should give you a decent idea. For ticks, assuming with those you mean some marker on the chart data points, these are not currently implemented. I do have some ideas regarding these but I did not need them yet. - Arjen пн, 21 окт. 2019 г. в 16:46, Arjen Hiemstra : On 21-10-2019 15:22, Arjen Hiemstra wrote: > Hi, > > Quick Charts has been moved to KDE review. The intent is to make it a > Tier 1 framework. > > Quick Charts is a QML module that implements a set of > high-performance, GPU accelerated > charts. Currently the main user of it is a new KSysGuard UI I have > been working on, but > once it is part of Frameworks I also hope to convert several bits of > Plasma to using it. And of course, a link would be useful: https://invent.kde.org/kde/kquickcharts > > - Arjen
Re: Quick Charts in KDE Review
Hi Arjen, 1. I don't see any checks in the autotests. Would it be easy to compare the displayed chart against a reference screenshot image, in each of the tests? The same screenshots could also help developers understand what kind of charts kquickcharts is good for. 2. How to add a grid, ticks and labels to a line chart? пн, 21 окт. 2019 г. в 16:46, Arjen Hiemstra : > > On 21-10-2019 15:22, Arjen Hiemstra wrote: > > Hi, > > > > Quick Charts has been moved to KDE review. The intent is to make it a > > Tier 1 framework. > > > > Quick Charts is a QML module that implements a set of > > high-performance, GPU accelerated > > charts. Currently the main user of it is a new KSysGuard UI I have > > been working on, but > > once it is part of Frameworks I also hope to convert several bits of > > Plasma to using it. > > And of course, a link would be useful: > > https://invent.kde.org/kde/kquickcharts > > > > > - Arjen -- Alexander Potashev
Re: Quick Charts in KDE Review
On 21-10-2019 15:22, Arjen Hiemstra wrote: Hi, Quick Charts has been moved to KDE review. The intent is to make it a Tier 1 framework. Quick Charts is a QML module that implements a set of high-performance, GPU accelerated charts. Currently the main user of it is a new KSysGuard UI I have been working on, but once it is part of Frameworks I also hope to convert several bits of Plasma to using it. And of course, a link would be useful: https://invent.kde.org/kde/kquickcharts - Arjen
