Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/ --- (Updated Sept. 20, 2013, 1:26 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Aurélien Gâteau. Description --- Removes KIconLoader dependency from KPixmapSequencer*, and adds KIconLoader::loadPixmapSequence for those applications that require animations shipped with XDG. As a TODO, I'd like to find a way of adding XDG compatibility without KIconLoader, maybe using QStandardPath. Diffs - KDE5PORTING.html c1dde0a knewstuff/src/ui/itemsviewbasedelegate.cpp 4c2733d knewstuff/src/ui/progressindicator.cpp 1ca9478 staging/kiconthemes/autotests/CMakeLists.txt 1e5899f staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c staging/kiconthemes/src/CMakeLists.txt 0de6456 staging/kiconthemes/src/kiconloader.h 65346df staging/kiconthemes/src/kiconloader.cpp 36a61a1 staging/kiconthemes/src/kpixmapsequence.h ef94596 staging/kiconthemes/src/kpixmapsequence.cpp c5b42e1 staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h 1c64e82 staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp 4632e74 staging/kiconthemes/src/kpixmapsequencewidget.h c6c7e17 staging/kiconthemes/src/kpixmapsequencewidget.cpp f7ab00c staging/kiconthemes/tests/CMakeLists.txt 855d45d staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp e60682c tier1/kwidgetsaddons/src/CMakeLists.txt e1d039b tier1/kwidgetsaddons/tests/CMakeLists.txt e4227a2 tier1/kwidgetsaddons/tests/kpixmap-animation.png PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112823/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/#review40352 --- Looks good overall, but I found a few minor issues. staging/kiconthemes/src/kiconloader.h http://git.reviewboard.kde.org/r/112823/#comment29771 Missing @since 5.0 staging/kiconthemes/src/kiconloader.h http://git.reviewboard.kde.org/r/112823/#comment29770 should be const staging/kiconthemes/src/kpixmapsequence.h http://git.reviewboard.kde.org/r/112823/#comment29772 No need for explicit now that the constructor takes two mandatory arguments. tier1/kwidgetsaddons/tests/CMakeLists.txt http://git.reviewboard.kde.org/r/112823/#comment29773 In KDE4 days programs marked as test had a KDESRCDIR define set which pointed to CMAKE_CURRENT_SOURCE_DIR. If it still exists it would be simpler to use it than to define a config file. - Aurélien Gâteau On Sept. 19, 2013, 4:04 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/ --- (Updated Sept. 19, 2013, 4:04 p.m.) Review request for KDE Frameworks and Aurélien Gâteau. Description --- Removes KIconLoader dependency from KPixmapSequencer*, and adds KIconLoader::loadPixmapSequence for those applications that require animations shipped with XDG. As a TODO, I'd like to find a way of adding XDG compatibility without KIconLoader, maybe using QStandardPath. Diffs - knewstuff/src/ui/itemsviewbasedelegate.cpp 4c2733d knewstuff/src/ui/progressindicator.cpp 1ca9478 staging/kiconthemes/autotests/CMakeLists.txt 1e5899f staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c staging/kiconthemes/src/CMakeLists.txt 0de6456 staging/kiconthemes/src/kiconloader.h 65346df staging/kiconthemes/src/kiconloader.cpp 36a61a1 staging/kiconthemes/src/kpixmapsequence.h ef94596 staging/kiconthemes/src/kpixmapsequence.cpp c5b42e1 staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h 1c64e82 staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp 4632e74 staging/kiconthemes/src/kpixmapsequencewidget.h c6c7e17 staging/kiconthemes/src/kpixmapsequencewidget.cpp f7ab00c staging/kiconthemes/tests/CMakeLists.txt 855d45d staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp e60682c tier1/kwidgetsaddons/src/CMakeLists.txt e1d039b tier1/kwidgetsaddons/tests/CMakeLists.txt e4227a2 tier1/kwidgetsaddons/tests/kpixmap-animation.png PRE-CREATION tier1/kwidgetsaddons/tests/kpixmapsequence_config.h.in PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112823/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/#review40350 --- Maybe you should add a note in KDE5Porting.html? - Aleix Pol Gonzalez On Sept. 19, 2013, 2:04 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/ --- (Updated Sept. 19, 2013, 2:04 p.m.) Review request for KDE Frameworks and Aurélien Gâteau. Description --- Removes KIconLoader dependency from KPixmapSequencer*, and adds KIconLoader::loadPixmapSequence for those applications that require animations shipped with XDG. As a TODO, I'd like to find a way of adding XDG compatibility without KIconLoader, maybe using QStandardPath. Diffs - knewstuff/src/ui/itemsviewbasedelegate.cpp 4c2733d knewstuff/src/ui/progressindicator.cpp 1ca9478 staging/kiconthemes/autotests/CMakeLists.txt 1e5899f staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c staging/kiconthemes/src/CMakeLists.txt 0de6456 staging/kiconthemes/src/kiconloader.h 65346df staging/kiconthemes/src/kiconloader.cpp 36a61a1 staging/kiconthemes/src/kpixmapsequence.h ef94596 staging/kiconthemes/src/kpixmapsequence.cpp c5b42e1 staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h 1c64e82 staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp 4632e74 staging/kiconthemes/src/kpixmapsequencewidget.h c6c7e17 staging/kiconthemes/src/kpixmapsequencewidget.cpp f7ab00c staging/kiconthemes/tests/CMakeLists.txt 855d45d staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp e60682c tier1/kwidgetsaddons/src/CMakeLists.txt e1d039b tier1/kwidgetsaddons/tests/CMakeLists.txt e4227a2 tier1/kwidgetsaddons/tests/kpixmap-animation.png PRE-CREATION tier1/kwidgetsaddons/tests/kpixmapsequence_config.h.in PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112823/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/#review40351 --- Maybe you should add a note in KDE5Porting.html? - Aleix Pol Gonzalez On Sept. 19, 2013, 2:04 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/ --- (Updated Sept. 19, 2013, 2:04 p.m.) Review request for KDE Frameworks and Aurélien Gâteau. Description --- Removes KIconLoader dependency from KPixmapSequencer*, and adds KIconLoader::loadPixmapSequence for those applications that require animations shipped with XDG. As a TODO, I'd like to find a way of adding XDG compatibility without KIconLoader, maybe using QStandardPath. Diffs - knewstuff/src/ui/itemsviewbasedelegate.cpp 4c2733d knewstuff/src/ui/progressindicator.cpp 1ca9478 staging/kiconthemes/autotests/CMakeLists.txt 1e5899f staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c staging/kiconthemes/src/CMakeLists.txt 0de6456 staging/kiconthemes/src/kiconloader.h 65346df staging/kiconthemes/src/kiconloader.cpp 36a61a1 staging/kiconthemes/src/kpixmapsequence.h ef94596 staging/kiconthemes/src/kpixmapsequence.cpp c5b42e1 staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h 1c64e82 staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp 4632e74 staging/kiconthemes/src/kpixmapsequencewidget.h c6c7e17 staging/kiconthemes/src/kpixmapsequencewidget.cpp f7ab00c staging/kiconthemes/tests/CMakeLists.txt 855d45d staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp e60682c tier1/kwidgetsaddons/src/CMakeLists.txt e1d039b tier1/kwidgetsaddons/tests/CMakeLists.txt e4227a2 tier1/kwidgetsaddons/tests/kpixmap-animation.png PRE-CREATION tier1/kwidgetsaddons/tests/kpixmapsequence_config.h.in PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112823/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/ --- (Updated Sept. 19, 2013, 3:25 p.m.) Review request for KDE Frameworks and Aurélien Gâteau. Changes --- Fixed all opened issues. Description --- Removes KIconLoader dependency from KPixmapSequencer*, and adds KIconLoader::loadPixmapSequence for those applications that require animations shipped with XDG. As a TODO, I'd like to find a way of adding XDG compatibility without KIconLoader, maybe using QStandardPath. Diffs (updated) - KDE5PORTING.html c1dde0a knewstuff/src/ui/itemsviewbasedelegate.cpp 4c2733d knewstuff/src/ui/progressindicator.cpp 1ca9478 staging/kiconthemes/autotests/CMakeLists.txt 1e5899f staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c staging/kiconthemes/src/CMakeLists.txt 0de6456 staging/kiconthemes/src/kiconloader.h 65346df staging/kiconthemes/src/kiconloader.cpp 36a61a1 staging/kiconthemes/src/kpixmapsequence.h ef94596 staging/kiconthemes/src/kpixmapsequence.cpp c5b42e1 staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h 1c64e82 staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp 4632e74 staging/kiconthemes/src/kpixmapsequencewidget.h c6c7e17 staging/kiconthemes/src/kpixmapsequencewidget.cpp f7ab00c staging/kiconthemes/tests/CMakeLists.txt 855d45d staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp e60682c tier1/kwidgetsaddons/src/CMakeLists.txt e1d039b tier1/kwidgetsaddons/tests/CMakeLists.txt e4227a2 tier1/kwidgetsaddons/tests/kpixmap-animation.png PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112823/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons
On Sept. 19, 2013, 2:27 p.m., Aurélien Gâteau wrote: tier1/kwidgetsaddons/tests/CMakeLists.txt, line 6 http://git.reviewboard.kde.org/r/112823/diff/1/?file=190546#file190546line6 In KDE4 days programs marked as test had a KDESRCDIR define set which pointed to CMAKE_CURRENT_SOURCE_DIR. If it still exists it would be simpler to use it than to define a config file. QFINDTESTDATA(kpixmap-animation.png) should do it (in your .cpp file). - Sebastian --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/#review40352 --- On Sept. 19, 2013, 2:04 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/ --- (Updated Sept. 19, 2013, 2:04 p.m.) Review request for KDE Frameworks and Aurélien Gâteau. Description --- Removes KIconLoader dependency from KPixmapSequencer*, and adds KIconLoader::loadPixmapSequence for those applications that require animations shipped with XDG. As a TODO, I'd like to find a way of adding XDG compatibility without KIconLoader, maybe using QStandardPath. Diffs - knewstuff/src/ui/itemsviewbasedelegate.cpp 4c2733d knewstuff/src/ui/progressindicator.cpp 1ca9478 staging/kiconthemes/autotests/CMakeLists.txt 1e5899f staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c staging/kiconthemes/src/CMakeLists.txt 0de6456 staging/kiconthemes/src/kiconloader.h 65346df staging/kiconthemes/src/kiconloader.cpp 36a61a1 staging/kiconthemes/src/kpixmapsequence.h ef94596 staging/kiconthemes/src/kpixmapsequence.cpp c5b42e1 staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h 1c64e82 staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp 4632e74 staging/kiconthemes/src/kpixmapsequencewidget.h c6c7e17 staging/kiconthemes/src/kpixmapsequencewidget.cpp f7ab00c staging/kiconthemes/tests/CMakeLists.txt 855d45d staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp e60682c tier1/kwidgetsaddons/src/CMakeLists.txt e1d039b tier1/kwidgetsaddons/tests/CMakeLists.txt e4227a2 tier1/kwidgetsaddons/tests/kpixmap-animation.png PRE-CREATION tier1/kwidgetsaddons/tests/kpixmapsequence_config.h.in PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112823/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/ --- (Updated Sept. 19, 2013, 3:07 p.m.) Review request for KDE Frameworks and Aurélien Gâteau. Changes --- Added kde5porting. Description --- Removes KIconLoader dependency from KPixmapSequencer*, and adds KIconLoader::loadPixmapSequence for those applications that require animations shipped with XDG. As a TODO, I'd like to find a way of adding XDG compatibility without KIconLoader, maybe using QStandardPath. Diffs (updated) - KDE5PORTING.html c1dde0a knewstuff/src/ui/itemsviewbasedelegate.cpp 4c2733d knewstuff/src/ui/progressindicator.cpp 1ca9478 staging/kiconthemes/autotests/CMakeLists.txt 1e5899f staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c staging/kiconthemes/src/CMakeLists.txt 0de6456 staging/kiconthemes/src/kiconloader.h 65346df staging/kiconthemes/src/kiconloader.cpp 36a61a1 staging/kiconthemes/src/kpixmapsequence.h ef94596 staging/kiconthemes/src/kpixmapsequence.cpp c5b42e1 staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h 1c64e82 staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp 4632e74 staging/kiconthemes/src/kpixmapsequencewidget.h c6c7e17 staging/kiconthemes/src/kpixmapsequencewidget.cpp f7ab00c staging/kiconthemes/tests/CMakeLists.txt 855d45d staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp e60682c tier1/kwidgetsaddons/src/CMakeLists.txt e1d039b tier1/kwidgetsaddons/tests/CMakeLists.txt e4227a2 tier1/kwidgetsaddons/tests/kpixmap-animation.png PRE-CREATION tier1/kwidgetsaddons/tests/kpixmapsequence_config.h.in PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112823/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112823: Move KPixmapSequencer to KWidgetsAddons
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/#review40361 --- Ship it! Patch does not apply there (complains about kpixmap-animation.png), but I assume this is a reviewboard glitch, so ship it. - Aurélien Gâteau On Sept. 19, 2013, 5:25 p.m., Àlex Fiestas wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112823/ --- (Updated Sept. 19, 2013, 5:25 p.m.) Review request for KDE Frameworks and Aurélien Gâteau. Description --- Removes KIconLoader dependency from KPixmapSequencer*, and adds KIconLoader::loadPixmapSequence for those applications that require animations shipped with XDG. As a TODO, I'd like to find a way of adding XDG compatibility without KIconLoader, maybe using QStandardPath. Diffs - KDE5PORTING.html c1dde0a knewstuff/src/ui/itemsviewbasedelegate.cpp 4c2733d knewstuff/src/ui/progressindicator.cpp 1ca9478 staging/kiconthemes/autotests/CMakeLists.txt 1e5899f staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c staging/kiconthemes/src/CMakeLists.txt 0de6456 staging/kiconthemes/src/kiconloader.h 65346df staging/kiconthemes/src/kiconloader.cpp 36a61a1 staging/kiconthemes/src/kpixmapsequence.h ef94596 staging/kiconthemes/src/kpixmapsequence.cpp c5b42e1 staging/kiconthemes/src/kpixmapsequenceoverlaypainter.h 1c64e82 staging/kiconthemes/src/kpixmapsequenceoverlaypainter.cpp 4632e74 staging/kiconthemes/src/kpixmapsequencewidget.h c6c7e17 staging/kiconthemes/src/kpixmapsequencewidget.cpp f7ab00c staging/kiconthemes/tests/CMakeLists.txt 855d45d staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.h staging/kiconthemes/tests/kpixmapsequenceoverlaypaintertest.cpp e60682c tier1/kwidgetsaddons/src/CMakeLists.txt e1d039b tier1/kwidgetsaddons/tests/CMakeLists.txt e4227a2 tier1/kwidgetsaddons/tests/kpixmap-animation.png PRE-CREATION Diff: http://git.reviewboard.kde.org/r/112823/diff/ Testing --- Thanks, Àlex Fiestas ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
