Re: Review Request 115504: Only perform tests for plugins that are built
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/#review50563 --- Ship it! Ship It! - David Faure On Feb. 20, 2014, 1:04 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/ --- (Updated Feb. 20, 2014, 1:04 p.m.) Review request for KDE Frameworks and Alex Merry. Repository: kimageformats Description --- Only perform tests for plugins that are built This both excludes the autotests and tests subdirs if the user sets BUILD_TESTING off, and makes sure we do not run tests for formats that were not built due to dependencies not being found. Diffs - CMakeLists.txt 8a24fd3600ef18a4e9992660c8637af6ed8f9ddc autotests/CMakeLists.txt 14db235bcea9bb6882539803e715a6e051ea6c18 src/imageformats/CMakeLists.txt e2242a6bc84c9fef10f7a06200daeac5e990e6c6 Diff: https://git.reviewboard.kde.org/r/115504/diff/ Testing --- Builds and tests pass. Builds with BUILD_TESTING off (and tests are not build, and make test does nothing). Commented out the optional find_package calls; still built and tests still passed. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115504: Only perform tests for plugins that are built
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/#review50579 --- This review has been submitted with commit 6272954cc53fa39e73524cbd2a42a90018544ee5 by Alex Merry to branch master. - Commit Hook On Feb. 20, 2014, 1:04 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/ --- (Updated Feb. 20, 2014, 1:04 p.m.) Review request for KDE Frameworks and Alex Merry. Repository: kimageformats Description --- Only perform tests for plugins that are built This both excludes the autotests and tests subdirs if the user sets BUILD_TESTING off, and makes sure we do not run tests for formats that were not built due to dependencies not being found. Diffs - CMakeLists.txt 8a24fd3600ef18a4e9992660c8637af6ed8f9ddc autotests/CMakeLists.txt 14db235bcea9bb6882539803e715a6e051ea6c18 src/imageformats/CMakeLists.txt e2242a6bc84c9fef10f7a06200daeac5e990e6c6 Diff: https://git.reviewboard.kde.org/r/115504/diff/ Testing --- Builds and tests pass. Builds with BUILD_TESTING off (and tests are not build, and make test does nothing). Commented out the optional find_package calls; still built and tests still passed. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115504: Only perform tests for plugins that are built
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/ --- (Updated Feb. 23, 2014, 11:55 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Repository: kimageformats Description --- Only perform tests for plugins that are built This both excludes the autotests and tests subdirs if the user sets BUILD_TESTING off, and makes sure we do not run tests for formats that were not built due to dependencies not being found. Diffs - CMakeLists.txt 8a24fd3600ef18a4e9992660c8637af6ed8f9ddc autotests/CMakeLists.txt 14db235bcea9bb6882539803e715a6e051ea6c18 src/imageformats/CMakeLists.txt e2242a6bc84c9fef10f7a06200daeac5e990e6c6 Diff: https://git.reviewboard.kde.org/r/115504/diff/ Testing --- Builds and tests pass. Builds with BUILD_TESTING off (and tests are not build, and make test does nothing). Commented out the optional find_package calls; still built and tests still passed. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115504: Only perform tests for plugins that are built
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/#review50341 --- autotests/CMakeLists.txt https://git.reviewboard.kde.org/r/115504/#comment35416 Didn't you mean if (BUILD_EPS_PLUGIN) ? This line confuses me. :-) - Kevin Ottens On Feb. 5, 2014, 5:41 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/ --- (Updated Feb. 5, 2014, 5:41 p.m.) Review request for KDE Frameworks. Repository: kimageformats Description --- Only perform tests for plugins that are built This both excludes the autotests and tests subdirs if the user sets BUILD_TESTING off, and makes sure we do not run tests for formats that were not built due to dependencies not being found. Diffs - CMakeLists.txt 2b88843e677163d8229d2a3b9055a540f7fb5961 autotests/CMakeLists.txt 0192636c3617bf37264a3895e61ecd837e228c4a src/imageformats/CMakeLists.txt 242753e0b2c493bbf1da9654967494415e8249d8 Diff: https://git.reviewboard.kde.org/r/115504/diff/ Testing --- Builds and tests pass. Builds with BUILD_TESTING off (and tests are not build, and make test does nothing). Commented out the optional find_package calls; still built and tests still passed. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115504: Only perform tests for plugins that are built
On Feb. 20, 2014, 12:14 p.m., Kevin Ottens wrote: autotests/CMakeLists.txt, line 82 https://git.reviewboard.kde.org/r/115504/diff/1/?file=242132#file242132line82 Didn't you mean if (BUILD_EPS_PLUGIN) ? This line confuses me. :-) Hmm... it is a little non-obvious, now you mention it. It is disabled for the reason mentioned in the comment above it; perhaps it would be clearer if I just commented out those lines. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/#review50341 --- On Feb. 5, 2014, 5:41 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/ --- (Updated Feb. 5, 2014, 5:41 p.m.) Review request for KDE Frameworks. Repository: kimageformats Description --- Only perform tests for plugins that are built This both excludes the autotests and tests subdirs if the user sets BUILD_TESTING off, and makes sure we do not run tests for formats that were not built due to dependencies not being found. Diffs - CMakeLists.txt 2b88843e677163d8229d2a3b9055a540f7fb5961 autotests/CMakeLists.txt 0192636c3617bf37264a3895e61ecd837e228c4a src/imageformats/CMakeLists.txt 242753e0b2c493bbf1da9654967494415e8249d8 Diff: https://git.reviewboard.kde.org/r/115504/diff/ Testing --- Builds and tests pass. Builds with BUILD_TESTING off (and tests are not build, and make test does nothing). Commented out the optional find_package calls; still built and tests still passed. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115504: Only perform tests for plugins that are built
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/ --- (Updated Feb. 20, 2014, 12:38 p.m.) Review request for KDE Frameworks. Changes --- Comment out broken tests, instead of using if(FALSE) Repository: kimageformats Description --- Only perform tests for plugins that are built This both excludes the autotests and tests subdirs if the user sets BUILD_TESTING off, and makes sure we do not run tests for formats that were not built due to dependencies not being found. Diffs (updated) - CMakeLists.txt 8a24fd3600ef18a4e9992660c8637af6ed8f9ddc autotests/CMakeLists.txt bedc3ad451128365699ec8f1392c68993934453b src/imageformats/CMakeLists.txt 7cafd18105a7219a9c761193012f87625f74d995 Diff: https://git.reviewboard.kde.org/r/115504/diff/ Testing --- Builds and tests pass. Builds with BUILD_TESTING off (and tests are not build, and make test does nothing). Commented out the optional find_package calls; still built and tests still passed. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115504: Only perform tests for plugins that are built
On Feb. 5, 2014, 6:52 p.m., Michael Palimaka wrote: CMakeLists.txt, lines 28-30 https://git.reviewboard.kde.org/r/115504/diff/1/?file=242131#file242131line28 Curious, what's the advantage to having a new variable vs. checking Qt5PrintSupport_FOUND later? Well, the relationship between, say OpenEXR_FOUND and the exr plugin is pretty obvious, but the EPS plugin technically depends on (Qt5PrintSupport_FOUND AND UNIX) (although, as you note, as long as no other part of the code uses Qt5PrintSupport, just checking Qt5PrintSupport_FOUND is sufficient). I just figured this would be easier to follow in src/ and autotests/, and avoid duplicating non-obvious tests. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/#review49066 --- On Feb. 5, 2014, 5:41 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/ --- (Updated Feb. 5, 2014, 5:41 p.m.) Review request for KDE Frameworks. Repository: kimageformats Description --- Only perform tests for plugins that are built This both excludes the autotests and tests subdirs if the user sets BUILD_TESTING off, and makes sure we do not run tests for formats that were not built due to dependencies not being found. Diffs - CMakeLists.txt 2b88843e677163d8229d2a3b9055a540f7fb5961 autotests/CMakeLists.txt 0192636c3617bf37264a3895e61ecd837e228c4a src/imageformats/CMakeLists.txt 242753e0b2c493bbf1da9654967494415e8249d8 Diff: https://git.reviewboard.kde.org/r/115504/diff/ Testing --- Builds and tests pass. Builds with BUILD_TESTING off (and tests are not build, and make test does nothing). Commented out the optional find_package calls; still built and tests still passed. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115504: Only perform tests for plugins that are built
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/#review49066 --- CMakeLists.txt https://git.reviewboard.kde.org/r/115504/#comment34644 Curious, what's the advantage to having a new variable vs. checking Qt5PrintSupport_FOUND later? - Michael Palimaka On Feb. 5, 2014, 5:41 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115504/ --- (Updated Feb. 5, 2014, 5:41 p.m.) Review request for KDE Frameworks. Repository: kimageformats Description --- Only perform tests for plugins that are built This both excludes the autotests and tests subdirs if the user sets BUILD_TESTING off, and makes sure we do not run tests for formats that were not built due to dependencies not being found. Diffs - CMakeLists.txt 2b88843e677163d8229d2a3b9055a540f7fb5961 autotests/CMakeLists.txt 0192636c3617bf37264a3895e61ecd837e228c4a src/imageformats/CMakeLists.txt 242753e0b2c493bbf1da9654967494415e8249d8 Diff: https://git.reviewboard.kde.org/r/115504/diff/ Testing --- Builds and tests pass. Builds with BUILD_TESTING off (and tests are not build, and make test does nothing). Commented out the optional find_package calls; still built and tests still passed. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
