Re: Review Request 115768: Remove the xv image format plugin

2014-02-15 Thread David Faure

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115768/#review49852
---

Ship it!


Ship It!

- David Faure


On Feb. 15, 2014, 5:49 p.m., Alex Merry wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115768/
 ---
 
 (Updated Feb. 15, 2014, 5:49 p.m.)
 
 
 Review request for KDE Frameworks and David Faure.
 
 
 Repository: kimageformats
 
 
 Description
 ---
 
 Remove the xv image format plugin
 
 It appears to be some internal format of xview, although I cannot find
 any mention of such a thing on the internet.  There does not appear to
 be any sort of mime type to associate with this file format, either.
 
 Therefore, I think it is reasonable to declare it obsolete.
 
 
 Diffs
 -
 
   autotests/CMakeLists.txt 0192636c3617bf37264a3895e61ecd837e228c4a 
   autotests/read/xv/bw.png 5f8fc8dd763d27e2685e1f236c2b78999a3f7072 
   autotests/read/xv/bw.xv b884b2e9aa6641a4be1498b9303923b7e406a2e0 
   autotests/read/xv/rgb.png d584013eadd0aedcff7f758393f0486e7b954c49 
   autotests/read/xv/rgb.xv 60cdbf37a19acb07a40b78b36e0aaf4b744e37d2 
   src/imageformats/CMakeLists.txt 242753e0b2c493bbf1da9654967494415e8249d8 
   src/imageformats/xv.desktop 9fa4a7e8b4e1287d918ed600b30d6feb9c79b7df 
   src/imageformats/xview.h 3e394e1e2d2ea9eb29dbe06d3862fbfa75266255 
   src/imageformats/xview.cpp af8539a879b710a2d29565e8d6a105367ec20832 
   src/imageformats/xview.json 117effbc26c109d5fdda0ea0482e4e884c244245 
 
 Diff: https://git.reviewboard.kde.org/r/115768/diff/
 
 
 Testing
 ---
 
 builds, installs, tests pass.
 
 
 Thanks,
 
 Alex Merry
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115768: Remove the xv image format plugin

2014-02-15 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115768/#review49854
---


This review has been submitted with commit 
3eafdc861af37cfacda4fcbfa2f65222bea79c13 by Alex Merry to branch master.

- Commit Hook


On Feb. 15, 2014, 5:49 p.m., Alex Merry wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115768/
 ---
 
 (Updated Feb. 15, 2014, 5:49 p.m.)
 
 
 Review request for KDE Frameworks and David Faure.
 
 
 Repository: kimageformats
 
 
 Description
 ---
 
 Remove the xv image format plugin
 
 It appears to be some internal format of xview, although I cannot find
 any mention of such a thing on the internet.  There does not appear to
 be any sort of mime type to associate with this file format, either.
 
 Therefore, I think it is reasonable to declare it obsolete.
 
 
 Diffs
 -
 
   autotests/CMakeLists.txt 0192636c3617bf37264a3895e61ecd837e228c4a 
   autotests/read/xv/bw.png 5f8fc8dd763d27e2685e1f236c2b78999a3f7072 
   autotests/read/xv/bw.xv b884b2e9aa6641a4be1498b9303923b7e406a2e0 
   autotests/read/xv/rgb.png d584013eadd0aedcff7f758393f0486e7b954c49 
   autotests/read/xv/rgb.xv 60cdbf37a19acb07a40b78b36e0aaf4b744e37d2 
   src/imageformats/CMakeLists.txt 242753e0b2c493bbf1da9654967494415e8249d8 
   src/imageformats/xv.desktop 9fa4a7e8b4e1287d918ed600b30d6feb9c79b7df 
   src/imageformats/xview.h 3e394e1e2d2ea9eb29dbe06d3862fbfa75266255 
   src/imageformats/xview.cpp af8539a879b710a2d29565e8d6a105367ec20832 
   src/imageformats/xview.json 117effbc26c109d5fdda0ea0482e4e884c244245 
 
 Diff: https://git.reviewboard.kde.org/r/115768/diff/
 
 
 Testing
 ---
 
 builds, installs, tests pass.
 
 
 Thanks,
 
 Alex Merry
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel