Re: Review Request 117795: Adapt to yaml file renaming ($framework.yaml => metainfo.yaml)

2014-04-27 Thread Aurélien Gâteau 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117795/
---

(Updated April 27, 2014, 9:51 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Aurélien Gâteau.


Repository: kapidox


Description
---

The dependency diagram code used to extract the framework name from the name of 
the yaml file, but that is not possible anymore. We can't use the name of the 
directory containing the code because build.kde.org stores the framework code 
under different names. Therefore I decided to use the name of the project() 
from the toplevel CMakeLists.txt. I rewrote parse_fancyname() to get the info 
from the CMakeLists.txt instead of README.md for consistency.

That patch is unfortunately quite large as the changes cascaded quite a lot.


Diffs
-

  src/kgenapidox 8fbffb1 
  src/kapidox/data/dependencies.md.mustache 5d34042 
  src/kapidox/__init__.py 61e6a13 
  src/depdiagram-prepare 320502f 
  src/kgenframeworksapidox 101f9b3 

Diff: https://git.reviewboard.kde.org/r/117795/diff/


Testing
---

- Regenerated all the diagrams.
- Ran kgenframeworksapidox on all the frameworks.
- Ran kgenapidox on one framework.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117795: Adapt to yaml file renaming ($framework.yaml => metainfo.yaml)

2014-04-27 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117795/#review56670
---


This review has been submitted with commit 
8ea94caa0ad7efc94d6aea3688af3b40ae99ea86 by Aurélien Gâteau to branch master.

- Commit Hook


On April 27, 2014, 9:40 a.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117795/
> ---
> 
> (Updated April 27, 2014, 9:40 a.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> The dependency diagram code used to extract the framework name from the name 
> of the yaml file, but that is not possible anymore. We can't use the name of 
> the directory containing the code because build.kde.org stores the framework 
> code under different names. Therefore I decided to use the name of the 
> project() from the toplevel CMakeLists.txt. I rewrote parse_fancyname() to 
> get the info from the CMakeLists.txt instead of README.md for consistency.
> 
> That patch is unfortunately quite large as the changes cascaded quite a lot.
> 
> 
> Diffs
> -
> 
>   src/kgenapidox 8fbffb1 
>   src/kapidox/data/dependencies.md.mustache 5d34042 
>   src/kapidox/__init__.py 61e6a13 
>   src/depdiagram-prepare 320502f 
>   src/kgenframeworksapidox 101f9b3 
> 
> Diff: https://git.reviewboard.kde.org/r/117795/diff/
> 
> 
> Testing
> ---
> 
> - Regenerated all the diagrams.
> - Ran kgenframeworksapidox on all the frameworks.
> - Ran kgenapidox on one framework.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117795: Adapt to yaml file renaming ($framework.yaml => metainfo.yaml)

2014-04-27 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117795/#review56669
---

Ship it!


Ship It!

- Alex Merry


On April 27, 2014, 9:40 a.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117795/
> ---
> 
> (Updated April 27, 2014, 9:40 a.m.)
> 
> 
> Review request for KDE Frameworks and Aurélien Gâteau.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> The dependency diagram code used to extract the framework name from the name 
> of the yaml file, but that is not possible anymore. We can't use the name of 
> the directory containing the code because build.kde.org stores the framework 
> code under different names. Therefore I decided to use the name of the 
> project() from the toplevel CMakeLists.txt. I rewrote parse_fancyname() to 
> get the info from the CMakeLists.txt instead of README.md for consistency.
> 
> That patch is unfortunately quite large as the changes cascaded quite a lot.
> 
> 
> Diffs
> -
> 
>   src/kgenapidox 8fbffb1 
>   src/kapidox/data/dependencies.md.mustache 5d34042 
>   src/kapidox/__init__.py 61e6a13 
>   src/depdiagram-prepare 320502f 
>   src/kgenframeworksapidox 101f9b3 
> 
> Diff: https://git.reviewboard.kde.org/r/117795/diff/
> 
> 
> Testing
> ---
> 
> - Regenerated all the diagrams.
> - Ran kgenframeworksapidox on all the frameworks.
> - Ran kgenapidox on one framework.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117795: Adapt to yaml file renaming ($framework.yaml => metainfo.yaml)

2014-04-27 Thread Aurélien Gâteau 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117795/
---

(Updated April 27, 2014, 11:40 a.m.)


Review request for KDE Frameworks and Aurélien Gâteau.


Repository: kapidox


Description
---

The dependency diagram code used to extract the framework name from the name of 
the yaml file, but that is not possible anymore. We can't use the name of the 
directory containing the code because build.kde.org stores the framework code 
under different names. Therefore I decided to use the name of the project() 
from the toplevel CMakeLists.txt. I rewrote parse_fancyname() to get the info 
from the CMakeLists.txt instead of README.md for consistency.

That patch is unfortunately quite large as the changes cascaded quite a lot.


Diffs (updated)
-

  src/kgenapidox 8fbffb1 
  src/kapidox/data/dependencies.md.mustache 5d34042 
  src/kapidox/__init__.py 61e6a13 
  src/depdiagram-prepare 320502f 
  src/kgenframeworksapidox 101f9b3 

Diff: https://git.reviewboard.kde.org/r/117795/diff/


Testing
---

- Regenerated all the diagrams.
- Ran kgenframeworksapidox on all the frameworks.
- Ran kgenapidox on one framework.


Thanks,

Aurélien Gâteau

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 117795: Adapt to yaml file renaming ($framework.yaml => metainfo.yaml)

2014-04-26 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117795/#review56646
---



src/depdiagram-prepare


This will break when we start putting VERSION arguments into project() 
calls (after we depend on CMake 3.0).



src/kapidox/__init__.py


As before, this will break with a VERSION argument (or, indeed, any 
languages).



src/kgenframeworksapidox


Not needed any more



src/kgenframeworksapidox


don't bother checking for README.md any more (this script doesn't care 
about it).


- Alex Merry


On April 26, 2014, 7:01 p.m., Aurélien Gâteau wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117795/
> ---
> 
> (Updated April 26, 2014, 7:01 p.m.)
> 
> 
> Review request for KDE Frameworks and Alex Merry.
> 
> 
> Repository: kapidox
> 
> 
> Description
> ---
> 
> The dependency diagram code used to extract the framework name from the name 
> of the yaml file, but that is not possible anymore. We can't use the name of 
> the directory containing the code because build.kde.org stores the framework 
> code under different names. Therefore I decided to use the name of the 
> project() from the toplevel CMakeLists.txt. I rewrote parse_fancyname() to 
> get the info from the CMakeLists.txt instead of README.md for consistency.
> 
> That patch is unfortunately quite large as the changes cascaded quite a lot.
> 
> 
> Diffs
> -
> 
>   src/depdiagram-prepare 320502f 
>   src/kapidox/__init__.py 61e6a13 
>   src/kapidox/data/dependencies.md.mustache 5d34042 
>   src/kgenapidox 8fbffb1 
>   src/kgenframeworksapidox 101f9b3 
> 
> Diff: https://git.reviewboard.kde.org/r/117795/diff/
> 
> 
> Testing
> ---
> 
> - Regenerated all the diagrams.
> - Ran kgenframeworksapidox on all the frameworks.
> - Ran kgenapidox on one framework.
> 
> 
> Thanks,
> 
> Aurélien Gâteau
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel