Re: Review Request 122549: Avoid code path that leaves local config files locked
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122549/ --- (Updated Feb. 19, 2015, 10:49 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig Description --- The local config file gets locked on line 415, if we return early we need to unlock it otherwise we keep a stray .lock file on the config. We've been getting a lot of lockups in Plasma with stray .lock files so I code reviewed the relevant bit of code to look for any problems. I doubt this is the cause but it seems wrong anyway. Diffs - src/core/kconfig.cpp 782e971 Diff: https://git.reviewboard.kde.org/r/122549/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122549: Avoid code path that leaves local config files locked
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122549/#review76254 --- Ship it! Makes sense to me, not the maintainer but seems pretty obvious fix. - Albert Astals Cid On feb. 12, 2015, 9:34 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122549/ --- (Updated feb. 12, 2015, 9:34 p.m.) Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig Description --- The local config file gets locked on line 415, if we return early we need to unlock it otherwise we keep a stray .lock file on the config. We've been getting a lot of lockups in Plasma with stray .lock files so I code reviewed the relevant bit of code to look for any problems. I doubt this is the cause but it seems wrong anyway. Diffs - src/core/kconfig.cpp 782e971 Diff: https://git.reviewboard.kde.org/r/122549/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122549: Avoid code path that leaves local config files locked
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122549/#review76212 --- bump? - David Edmundson On Feb. 12, 2015, 9:34 p.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122549/ --- (Updated Feb. 12, 2015, 9:34 p.m.) Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig Description --- The local config file gets locked on line 415, if we return early we need to unlock it otherwise we keep a stray .lock file on the config. We've been getting a lot of lockups in Plasma with stray .lock files so I code reviewed the relevant bit of code to look for any problems. I doubt this is the cause but it seems wrong anyway. Diffs - src/core/kconfig.cpp 782e971 Diff: https://git.reviewboard.kde.org/r/122549/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122549: Avoid code path that leaves local config files locked
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122549/#review75962 --- related bug : https://bugs.kde.org/show_bug.cgi?id=344032 - Bhushan Shah On Feb. 13, 2015, 3:04 a.m., David Edmundson wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122549/ --- (Updated Feb. 13, 2015, 3:04 a.m.) Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig Description --- The local config file gets locked on line 415, if we return early we need to unlock it otherwise we keep a stray .lock file on the config. We've been getting a lot of lockups in Plasma with stray .lock files so I code reviewed the relevant bit of code to look for any problems. I doubt this is the cause but it seems wrong anyway. Diffs - src/core/kconfig.cpp 782e971 Diff: https://git.reviewboard.kde.org/r/122549/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
