Re: Review Request 122775: Make QImageItem handle non default devicePixelRatios
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122775/ --- (Updated March 2, 2015, 4:34 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdeclarative Description --- PaintedWidth/Height are all relative to the items geometry so already in user pixels not device pixels. Diffs - src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp ed735b5 src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 8c06146 Diff: https://git.reviewboard.kde.org/r/122775/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122775: Make QImageItem handle non default devicePixelRatios
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122775/#review76905 --- Ship it! Inviala! - Luca Beltrame On Mar. 2, 2015, 2:50 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122775/ > --- > > (Updated Mar. 2, 2015, 2:50 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdeclarative > > > Description > --- > > PaintedWidth/Height are all relative to the items geometry so already > in user pixels not device pixels. > > > Diffs > - > > src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp ed735b5 > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 8c06146 > > Diff: https://git.reviewboard.kde.org/r/122775/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122775: Make QImageItem handle non default devicePixelRatios
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122775/#review76893 --- Ship it! Ship It! - Aleix Pol Gonzalez On March 2, 2015, 3:50 p.m., David Edmundson wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122775/ > --- > > (Updated March 2, 2015, 3:50 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdeclarative > > > Description > --- > > PaintedWidth/Height are all relative to the items geometry so already > in user pixels not device pixels. > > > Diffs > - > > src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp ed735b5 > src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 8c06146 > > Diff: https://git.reviewboard.kde.org/r/122775/diff/ > > > Testing > --- > > > Thanks, > > David Edmundson > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 122775: Make QImageItem handle non default devicePixelRatios
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122775/ --- (Updated March 2, 2015, 2:50 p.m.) Review request for KDE Frameworks. Summary (updated) - Make QImageItem handle non default devicePixelRatios Repository: kdeclarative Description --- PaintedWidth/Height are all relative to the items geometry so already in user pixels not device pixels. Diffs - src/qmlcontrols/kquickcontrolsaddons/qimageitem.cpp ed735b5 src/qmlcontrols/kquickcontrolsaddons/qpixmapitem.cpp 8c06146 Diff: https://git.reviewboard.kde.org/r/122775/diff/ Testing --- Thanks, David Edmundson ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel