Re: Review Request 123692: autotests: Use QTEST_GUILESS_MAIN
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123692/#review81439 --- Ping? - Heiko Becker On Mai 8, 2015, 7:15 nachm., Heiko Becker wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123692/ --- (Updated Mai 8, 2015, 7:15 nachm.) Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstuff Description --- The tests still work fine with it, allowing them to run without a display server. Diffs - autotests/knewstuffauthortest.cpp 5ca7c4903e90a5b8bf377c3c12d5bbe7c0623002 autotests/knewstuffentrytest.cpp 7862ebbbf7c6a913cb4d6d0b70b2edf151ec6327 Diff: https://git.reviewboard.kde.org/r/123692/diff/ Testing --- Built and ran the tests successfully. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123692: autotests: Use QTEST_GUILESS_MAIN
On June 13, 2015, 10:26 a.m., Heiko Becker wrote: Ping? Hi Heiko, I've added this to our KDE's Phabricator task [T398](https://phabricator.kde.org/T398). ATM I can't test on my own OSX/CI system, as that is in limbo since we changed to Scarlett's new KDE/CI system. But I'll come back to this RR, once I had a chance to check it independently on OSX. - Marko --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123692/#review81439 --- On May 8, 2015, 9:15 p.m., Heiko Becker wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123692/ --- (Updated May 8, 2015, 9:15 p.m.) Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstuff Description --- The tests still work fine with it, allowing them to run without a display server. Diffs - autotests/knewstuffauthortest.cpp 5ca7c4903e90a5b8bf377c3c12d5bbe7c0623002 autotests/knewstuffentrytest.cpp 7862ebbbf7c6a913cb4d6d0b70b2edf151ec6327 Diff: https://git.reviewboard.kde.org/r/123692/diff/ Testing --- Built and ran the tests successfully. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123692: autotests: Use QTEST_GUILESS_MAIN
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123692/#review81446 --- Ship it! This is making it run without a gui on linux fine. I also tested on OS X here, but the tests don't run here for some reason. It could be because it's creating .app files rather than directly creating a binary. If I run the test autotests/knewstuffauthortest.app/Contents/MacoOS/knewstuffauthortest it passes fine (even over ssh), but make test fails. - Jeremy Whiting On May 8, 2015, 1:15 p.m., Heiko Becker wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123692/ --- (Updated May 8, 2015, 1:15 p.m.) Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstuff Description --- The tests still work fine with it, allowing them to run without a display server. Diffs - autotests/knewstuffauthortest.cpp 5ca7c4903e90a5b8bf377c3c12d5bbe7c0623002 autotests/knewstuffentrytest.cpp 7862ebbbf7c6a913cb4d6d0b70b2edf151ec6327 Diff: https://git.reviewboard.kde.org/r/123692/diff/ Testing --- Built and ran the tests successfully. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123692: autotests: Use QTEST_GUILESS_MAIN
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123692/ --- (Updated June 13, 2015, 7:56 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Jeremy Whiting. Changes --- Submitted with commit 5a63345aa9f9a3e27bcc25f53328687e519c1fdc by Heiko Becker to branch master. Repository: knewstuff Description --- The tests still work fine with it, allowing them to run without a display server. Diffs - autotests/knewstuffauthortest.cpp 5ca7c4903e90a5b8bf377c3c12d5bbe7c0623002 autotests/knewstuffentrytest.cpp 7862ebbbf7c6a913cb4d6d0b70b2edf151ec6327 Diff: https://git.reviewboard.kde.org/r/123692/diff/ Testing --- Built and ran the tests successfully. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 123692: autotests: Use QTEST_GUILESS_MAIN
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123692/#review81451 --- I've pushed this after Jeremy's comment. As someone who has no clue about Mac OS, I do wonder in what respect GUI-less tests are special on Mac OS. - Heiko Becker On Juni 13, 2015, 7:56 nachm., Heiko Becker wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123692/ --- (Updated Juni 13, 2015, 7:56 nachm.) Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstuff Description --- The tests still work fine with it, allowing them to run without a display server. Diffs - autotests/knewstuffauthortest.cpp 5ca7c4903e90a5b8bf377c3c12d5bbe7c0623002 autotests/knewstuffentrytest.cpp 7862ebbbf7c6a913cb4d6d0b70b2edf151ec6327 Diff: https://git.reviewboard.kde.org/r/123692/diff/ Testing --- Built and ran the tests successfully. Thanks, Heiko Becker ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
