Re: Review Request 125334: Small improvements in ColumnProxyModel

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125334/
---

(Updated Oct. 4, 2015, 4:27 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Changes
---

Submitted with commit c0b8ee043e8fbf1edd7b4e3223dedb00960f2e0a by Aleix Pol to 
branch master.


Repository: kdeclarative


Description
---

* Add a check for a property set so that it doesn't re-compute if the new value 
is the same as the former.
* Implement ::setData to the source model.


Diffs
-

  autotests/columnproxymodeltest.h 46b8d40 
  autotests/columnproxymodeltest.cpp 8844651 
  src/qmlcontrols/kquickcontrolsaddons/columnproxymodel.h 83d65d1 
  src/qmlcontrols/kquickcontrolsaddons/columnproxymodel.cpp b4f7973 

Diff: https://git.reviewboard.kde.org/r/125334/diff/


Testing
---

added test, does what I need it to do on muon.


Thanks,

Aleix Pol Gonzalez

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125334: Small improvements in ColumnProxyModel

[Mark Gaiser]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125334/#review86337
---


+1


src/qmlcontrols/kquickcontrolsaddons/columnproxymodel.cpp (lines 118 - 119)


Always use curly braces. (kde coding style)


- Mark Gaiser


On sep 21, 2015, 4:04 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125334/
> ---
> 
> (Updated sep 21, 2015, 4:04 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> * Add a check for a property set so that it doesn't re-compute if the new 
> value is the same as the former.
> * Implement ::setData to the source model.
> 
> 
> Diffs
> -
> 
>   autotests/columnproxymodeltest.h 46b8d40 
>   autotests/columnproxymodeltest.cpp 8844651 
>   src/qmlcontrols/kquickcontrolsaddons/columnproxymodel.h 83d65d1 
>   src/qmlcontrols/kquickcontrolsaddons/columnproxymodel.cpp b4f7973 
> 
> Diff: https://git.reviewboard.kde.org/r/125334/diff/
> 
> 
> Testing
> ---
> 
> added test, does what I need it to do on muon.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125334: Small improvements in ColumnProxyModel

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125334/#review86338
---

Ship it!


Ship It!

- David Edmundson


On Sept. 21, 2015, 4:04 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125334/
> ---
> 
> (Updated Sept. 21, 2015, 4:04 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> ---
> 
> * Add a check for a property set so that it doesn't re-compute if the new 
> value is the same as the former.
> * Implement ::setData to the source model.
> 
> 
> Diffs
> -
> 
>   autotests/columnproxymodeltest.h 46b8d40 
>   autotests/columnproxymodeltest.cpp 8844651 
>   src/qmlcontrols/kquickcontrolsaddons/columnproxymodel.h 83d65d1 
>   src/qmlcontrols/kquickcontrolsaddons/columnproxymodel.cpp b4f7973 
> 
> Diff: https://git.reviewboard.kde.org/r/125334/diff/
> 
> 
> Testing
> ---
> 
> added test, does what I need it to do on muon.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel