Re: Review Request 125538: [kio-trash] Add file system freespace retrieval to trash kioslave

2015-10-06 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125538/#review86410
---

Ship it!


Nice!


src/ioslaves/trash/trashimpl.cpp (line 726)


trailing space



src/ioslaves/trash/trashimpl.cpp (line 731)


QString is just one more character than auto, and more readable :-)


- David Faure


On Oct. 6, 2015, 7:05 a.m., Emmanuel Pescosta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125538/
> ---
> 
> (Updated Oct. 6, 2015, 7:05 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Gives the user info about the trash occupancy when opening the trash
> 
> 
> Diffs
> -
> 
>   src/ioslaves/trash/kio_trash.h e6160c4 
>   src/ioslaves/trash/kio_trash.cpp 7ca8ad0 
>   src/ioslaves/trash/trashimpl.h 9881d8e 
>   src/ioslaves/trash/trashimpl.cpp 5a2832a 
> 
> Diff: https://git.reviewboard.kde.org/r/125538/diff/
> 
> 
> Testing
> ---
> 
> Works fine (with and without maximum size limit)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125538: [kio-trash] Add file system freespace retrieval to trash kioslave

2015-10-06 Thread Emmanuel Pescosta 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125538/
---

(Updated Oct. 6, 2015, 7:40 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Changes
---

Submitted with commit 6128e94f689d416abb60255bb3792f127e52783c by Emmanuel 
Pescosta to branch master.


Repository: kio


Description
---

Gives the user info about the trash occupancy when opening the trash


Diffs
-

  src/ioslaves/trash/kio_trash.h e6160c4 
  src/ioslaves/trash/kio_trash.cpp 7ca8ad0 
  src/ioslaves/trash/trashimpl.h 9881d8e 
  src/ioslaves/trash/trashimpl.cpp 5a2832a 

Diff: https://git.reviewboard.kde.org/r/125538/diff/


Testing
---

Works fine (with and without maximum size limit)


Thanks,

Emmanuel Pescosta

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125538: [kio-trash] Add file system freespace retrieval to trash kioslave

2015-10-06 Thread Aleix Pol Gonzalez 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125538/#review86411
---



src/ioslaves/trash/kio_trash.cpp (line 617)


Maybe use qCDebug? So it can be disabled and so.


- Aleix Pol Gonzalez


On Oct. 6, 2015, 9:40 a.m., Emmanuel Pescosta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125538/
> ---
> 
> (Updated Oct. 6, 2015, 9:40 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Gives the user info about the trash occupancy when opening the trash
> 
> 
> Diffs
> -
> 
>   src/ioslaves/trash/kio_trash.h e6160c4 
>   src/ioslaves/trash/kio_trash.cpp 7ca8ad0 
>   src/ioslaves/trash/trashimpl.h 9881d8e 
>   src/ioslaves/trash/trashimpl.cpp 5a2832a 
> 
> Diff: https://git.reviewboard.kde.org/r/125538/diff/
> 
> 
> Testing
> ---
> 
> Works fine (with and without maximum size limit)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125538: [kio-trash] Add file system freespace retrieval to trash kioslave

2015-10-06 Thread Emmanuel Pescosta 


> On Oct. 6, 2015, 10:27 a.m., Aleix Pol Gonzalez wrote:
> > src/ioslaves/trash/kio_trash.cpp, line 617
> > 
> >
> > Maybe use qCDebug? So it can be disabled and so.

Trash doesn't use categorized logging atm so I decided to use qDebug.

IMHO categorized logging should be added in a separate patch instead.


- Emmanuel


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125538/#review86411
---


On Oct. 6, 2015, 9:40 a.m., Emmanuel Pescosta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125538/
> ---
> 
> (Updated Oct. 6, 2015, 9:40 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Gives the user info about the trash occupancy when opening the trash
> 
> 
> Diffs
> -
> 
>   src/ioslaves/trash/kio_trash.h e6160c4 
>   src/ioslaves/trash/kio_trash.cpp 7ca8ad0 
>   src/ioslaves/trash/trashimpl.h 9881d8e 
>   src/ioslaves/trash/trashimpl.cpp 5a2832a 
> 
> Diff: https://git.reviewboard.kde.org/r/125538/diff/
> 
> 
> Testing
> ---
> 
> Works fine (with and without maximum size limit)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 125538: [kio-trash] Add file system freespace retrieval to trash kioslave

2015-10-06 Thread Aleix Pol Gonzalez 


> On Oct. 6, 2015, 10:27 a.m., Aleix Pol Gonzalez wrote:
> > src/ioslaves/trash/kio_trash.cpp, line 617
> > 
> >
> > Maybe use qCDebug? So it can be disabled and so.
> 
> Emmanuel Pescosta wrote:
> Trash doesn't use categorized logging atm so I decided to use qDebug.
> 
> IMHO categorized logging should be added in a separate patch instead.

Ok, looking forward to it. :)


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125538/#review86411
---


On Oct. 6, 2015, 9:40 a.m., Emmanuel Pescosta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125538/
> ---
> 
> (Updated Oct. 6, 2015, 9:40 a.m.)
> 
> 
> Review request for KDE Frameworks and David Faure.
> 
> 
> Repository: kio
> 
> 
> Description
> ---
> 
> Gives the user info about the trash occupancy when opening the trash
> 
> 
> Diffs
> -
> 
>   src/ioslaves/trash/kio_trash.h e6160c4 
>   src/ioslaves/trash/kio_trash.cpp 7ca8ad0 
>   src/ioslaves/trash/trashimpl.h 9881d8e 
>   src/ioslaves/trash/trashimpl.cpp 5a2832a 
> 
> Diff: https://git.reviewboard.kde.org/r/125538/diff/
> 
> 
> Testing
> ---
> 
> Works fine (with and without maximum size limit)
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel