Re: Review Request 125559: Fix usage with cmake < 3.0.0
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125559/ --- (Updated Oct. 8, 2015, 5:49 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Alex Merry. Repository: kdesignerplugin Description --- Qt5UiPlugin [requires cmake 3.0.0](http://code.qt.io/cgit/qt/qtbase.git/commit/mkspecs/features/data/cmake/Qt5BasicConfig.cmake.in?id=884679a7cc74b85d6c565316520304a9c73b5f04) so don't try to use it if we're running with cmake < 3.0.0 Diffs - KF5DesignerPluginMacros.cmake 0dfa9cdfc3f05d477b30dbee67585bf407a32613 Diff: https://git.reviewboard.kde.org/r/125559/diff/ Testing --- Thanks, Antonio Larrosa Jimenez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125559: Fix usage with cmake < 3.0.0
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125559/#review86515 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 8, 2015, 7:33 p.m., Antonio Larrosa Jimenez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125559/ > --- > > (Updated Oct. 8, 2015, 7:33 p.m.) > > > Review request for KDE Frameworks and Alex Merry. > > > Repository: kdesignerplugin > > > Description > --- > > Qt5UiPlugin [requires cmake > 3.0.0](http://code.qt.io/cgit/qt/qtbase.git/commit/mkspecs/features/data/cmake/Qt5BasicConfig.cmake.in?id=884679a7cc74b85d6c565316520304a9c73b5f04) > so don't try to use it if we're > running with cmake < 3.0.0 > > > Diffs > - > > KF5DesignerPluginMacros.cmake 0dfa9cdfc3f05d477b30dbee67585bf407a32613 > > Diff: https://git.reviewboard.kde.org/r/125559/diff/ > > > Testing > --- > > > Thanks, > > Antonio Larrosa Jimenez > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125559: Fix usage with cmake < 3.0.0
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125559/ --- (Updated Oct. 8, 2015, 5:33 p.m.) Review request for KDE Frameworks and Alex Merry. Changes --- nicer url Repository: kdesignerplugin Description (updated) --- Qt5UiPlugin [requires cmake 3.0.0](http://code.qt.io/cgit/qt/qtbase.git/commit/mkspecs/features/data/cmake/Qt5BasicConfig.cmake.in?id=884679a7cc74b85d6c565316520304a9c73b5f04) so don't try to use it if we're running with cmake < 3.0.0 Diffs - KF5DesignerPluginMacros.cmake 0dfa9cdfc3f05d477b30dbee67585bf407a32613 Diff: https://git.reviewboard.kde.org/r/125559/diff/ Testing --- Thanks, Antonio Larrosa Jimenez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125559: Fix usage with cmake < 3.0.0
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125559/ --- (Updated Oct. 8, 2015, 5:30 p.m.) Review request for KDE Frameworks and Alex Merry. Repository: kdesignerplugin Description (updated) --- Qt5UiPlugin requires cmake 3.0.0 (1) so don't try to use it if we're running with cmake < 3.0.0 (1) http://code.qt.io/cgit/qt/qtbase.git/commit/mkspecs/features/data/cmake/Qt5BasicConfig.cmake.in?id=884679a7cc74b85d6c565316520304a9c73b5f04 Diffs - KF5DesignerPluginMacros.cmake 0dfa9cdfc3f05d477b30dbee67585bf407a32613 Diff: https://git.reviewboard.kde.org/r/125559/diff/ Testing --- Thanks, Antonio Larrosa Jimenez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel