Re: Review Request 125760: Allow local embedded themes, like Qt does a default search in :/icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125760/ --- (Updated Oct. 24, 2015, 1:10 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, Christoph Feck and Boudewijn Rempt. Changes --- Submitted with commit b10bae68c7319cbb4e4e985e139702a15df7dcb8 by Christoph Cullmann to branch master. Repository: kiconthemes Description --- Allow icon themes to be embedded in applications and prefer the embedded ones, if e.g. Krita or Kate ships an embedded theme, that shall be found and used. Qt does already do so, by searching in :/icons. Diffs - autotests/CMakeLists.txt 707f39b autotests/kiconloader_resourcethemetest.cpp PRE-CREATION autotests/resources.qrc 5385977 src/kicontheme.cpp d0ab4b9 Diff: https://git.reviewboard.kde.org/r/125760/diff/ Testing --- Themes still work, if you have the right theme in :/icons it is found, in contrast to before this patch. Still a problem, that I need to takle in a different patch: How to enforce the use of some theme, Qt is able to do so via setThemeName, KIconLoader and Co. ignore that. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125760: Allow local embedded themes, like Qt does a default search in :/icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125760/#review87338 --- Ship it! Ship It! - Boudewijn Rempt On Oct. 23, 2015, 5:28 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125760/ > --- > > (Updated Oct. 23, 2015, 5:28 p.m.) > > > Review request for KDE Frameworks, Christoph Feck and Boudewijn Rempt. > > > Repository: kiconthemes > > > Description > --- > > Allow icon themes to be embedded in applications and prefer the embedded > ones, if e.g. Krita or Kate ships an embedded theme, that shall be found and > used. > Qt does already do so, by searching in :/icons. > > > Diffs > - > > autotests/CMakeLists.txt 707f39b > autotests/kiconloader_resourcethemetest.cpp PRE-CREATION > autotests/resources.qrc 5385977 > src/kicontheme.cpp d0ab4b9 > > Diff: https://git.reviewboard.kde.org/r/125760/diff/ > > > Testing > --- > > Themes still work, if you have the right theme in :/icons it is found, in > contrast to before this patch. > Still a problem, that I need to takle in a different patch: How to enforce > the use of some theme, Qt is able to do so via setThemeName, KIconLoader and > Co. ignore that. > > > Thanks, > > Christoph Cullmann > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125760: Allow local embedded themes, like Qt does a default search in :/icons
> On Oct. 23, 2015, 9:46 p.m., Aleix Pol Gonzalez wrote: > > +1 looks good to me. Ship it from someone? - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125760/#review87320 --- On Oct. 23, 2015, 5:28 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125760/ > --- > > (Updated Oct. 23, 2015, 5:28 p.m.) > > > Review request for KDE Frameworks, Christoph Feck and Boudewijn Rempt. > > > Repository: kiconthemes > > > Description > --- > > Allow icon themes to be embedded in applications and prefer the embedded > ones, if e.g. Krita or Kate ships an embedded theme, that shall be found and > used. > Qt does already do so, by searching in :/icons. > > > Diffs > - > > autotests/CMakeLists.txt 707f39b > autotests/kiconloader_resourcethemetest.cpp PRE-CREATION > autotests/resources.qrc 5385977 > src/kicontheme.cpp d0ab4b9 > > Diff: https://git.reviewboard.kde.org/r/125760/diff/ > > > Testing > --- > > Themes still work, if you have the right theme in :/icons it is found, in > contrast to before this patch. > Still a problem, that I need to takle in a different patch: How to enforce > the use of some theme, Qt is able to do so via setThemeName, KIconLoader and > Co. ignore that. > > > Thanks, > > Christoph Cullmann > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125760: Allow local embedded themes, like Qt does a default search in :/icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125760/#review87320 --- +1 looks good to me. - Aleix Pol Gonzalez On Oct. 23, 2015, 7:28 p.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125760/ > --- > > (Updated Oct. 23, 2015, 7:28 p.m.) > > > Review request for KDE Frameworks, Christoph Feck and Boudewijn Rempt. > > > Repository: kiconthemes > > > Description > --- > > Allow icon themes to be embedded in applications and prefer the embedded > ones, if e.g. Krita or Kate ships an embedded theme, that shall be found and > used. > Qt does already do so, by searching in :/icons. > > > Diffs > - > > autotests/CMakeLists.txt 707f39b > autotests/kiconloader_resourcethemetest.cpp PRE-CREATION > autotests/resources.qrc 5385977 > src/kicontheme.cpp d0ab4b9 > > Diff: https://git.reviewboard.kde.org/r/125760/diff/ > > > Testing > --- > > Themes still work, if you have the right theme in :/icons it is found, in > contrast to before this patch. > Still a problem, that I need to takle in a different patch: How to enforce > the use of some theme, Qt is able to do so via setThemeName, KIconLoader and > Co. ignore that. > > > Thanks, > > Christoph Cullmann > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125760: Allow local embedded themes, like Qt does a default search in :/icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125760/ --- (Updated Oct. 23, 2015, 5:28 p.m.) Review request for KDE Frameworks, Christoph Feck and Boudewijn Rempt. Changes --- Added test, ok that way? Repository: kiconthemes Description --- Allow icon themes to be embedded in applications and prefer the embedded ones, if e.g. Krita or Kate ships an embedded theme, that shall be found and used. Qt does already do so, by searching in :/icons. Diffs (updated) - autotests/CMakeLists.txt 707f39b autotests/kiconloader_resourcethemetest.cpp PRE-CREATION autotests/resources.qrc 5385977 src/kicontheme.cpp d0ab4b9 Diff: https://git.reviewboard.kde.org/r/125760/diff/ Testing --- Themes still work, if you have the right theme in :/icons it is found, in contrast to before this patch. Still a problem, that I need to takle in a different patch: How to enforce the use of some theme, Qt is able to do so via setThemeName, KIconLoader and Co. ignore that. Thanks, Christoph Cullmann ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 125760: Allow local embedded themes, like Qt does a default search in :/icons
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125760/#review87303 --- Looks good to me. Maybe some testing would be useful? - Aleix Pol Gonzalez On Oct. 23, 2015, 8:25 a.m., Christoph Cullmann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125760/ > --- > > (Updated Oct. 23, 2015, 8:25 a.m.) > > > Review request for KDE Frameworks, Christoph Feck and Boudewijn Rempt. > > > Repository: kiconthemes > > > Description > --- > > Allow icon themes to be embedded in applications and prefer the embedded > ones, if e.g. Krita or Kate ships an embedded theme, that shall be found and > used. > Qt does already do so, by searching in :/icons. > > > Diffs > - > > src/kicontheme.cpp d0ab4b9 > > Diff: https://git.reviewboard.kde.org/r/125760/diff/ > > > Testing > --- > > Themes still work, if you have the right theme in :/icons it is found, in > contrast to before this patch. > Still a problem, that I need to takle in a different patch: How to enforce > the use of some theme, Qt is able to do so via setThemeName, KIconLoader and > Co. ignore that. > > > Thanks, > > Christoph Cullmann > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
