Re: Review Request 126285: OS X build and warning fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126285/ --- (Updated Oct. 20, 2016, 11:35 a.m.) Status -- This change has been marked as submitted. Review request for KDE Software on Mac OS X, KDE Frameworks and Ivan Čukić. Changes --- Submitted with commit 7ba0ee591e0f50a7e7b532f9eb7e500e7da784fb by Albert Astals Cid on behalf of Samuel Gaist to branch master. Repository: qca Description --- Revert "Add missed file" This reverts commit 4c9f27270e0a7c00c10cbc56ce5c6842b47e5ab2. FindCoreFoundation.cmake is not needed since CoreFoundation is a system framework. Its use has been removed by commit f223ce03d4b94ffbb093fc8be5adf8d968f54434 Diffs - cmake/modules/FindCoreFoundation.cmake c08e529ceec337c085f2f650f180b4e7897246bb Diff: https://git.reviewboard.kde.org/r/126285/diff/ Testing --- Thanks, Samuel Gaist
Re: Review Request 126285: OS X build and warning fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126285/ --- (Updated May 10, 2016, 10:06 p.m.) Review request for KDE Software on Mac OS X, KDE Frameworks and Ivan Čukić. Changes --- Fixed diff Repository: qca Description --- Revert "Add missed file" This reverts commit 4c9f27270e0a7c00c10cbc56ce5c6842b47e5ab2. FindCoreFoundation.cmake is not needed since CoreFoundation is a system framework. Its use has been removed by commit f223ce03d4b94ffbb093fc8be5adf8d968f54434 Diffs (updated) - cmake/modules/FindCoreFoundation.cmake c08e529ceec337c085f2f650f180b4e7897246bb Diff: https://git.reviewboard.kde.org/r/126285/diff/ Testing --- Thanks, Samuel Gaist ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126285: OS X build and warning fix
> On May 4, 2016, 4:16 p.m., Ivan Čukić wrote: > > Looks good to me - though I can not comment on the OSX API. I must have missed something when generating the patch, the OS X API changes comes from f223ce03d4b94ffbb093fc8be5adf8d968f54434 - Samuel --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126285/#review95174 --- On April 29, 2016, 11:59 a.m., Samuel Gaist wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126285/ > --- > > (Updated April 29, 2016, 11:59 a.m.) > > > Review request for KDE Software on Mac OS X, KDE Frameworks and Ivan Čukić. > > > Repository: qca > > > Description > --- > > Revert "Add missed file" > > This reverts commit 4c9f27270e0a7c00c10cbc56ce5c6842b47e5ab2. > > FindCoreFoundation.cmake is not needed since CoreFoundation > is a system framework. Its use has been removed by > commit f223ce03d4b94ffbb093fc8be5adf8d968f54434 > > > Diffs > - > > CMakeLists.txt 051ae6d26111725d3a296a124e8c1772e37c9940 > cmake/modules/FindCoreFoundation.cmake > c08e529ceec337c085f2f650f180b4e7897246bb > src/CMakeLists.txt a60bda0bf3d8bad7523ee7d50798c8cdb6c2eccb > src/qca_systemstore_mac.cpp 9349c90c8258d3d1f00a3796d93f94c09f5b1f2a > > Diff: https://git.reviewboard.kde.org/r/126285/diff/ > > > Testing > --- > > > Thanks, > > Samuel Gaist > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126285: OS X build and warning fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126285/#review95174 --- Ship it! Looks good to me - though I can not comment on the OSX API. - Ivan Čukić On April 29, 2016, 11:59 a.m., Samuel Gaist wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126285/ > --- > > (Updated April 29, 2016, 11:59 a.m.) > > > Review request for KDE Software on Mac OS X, KDE Frameworks and Ivan Čukić. > > > Repository: qca > > > Description > --- > > Revert "Add missed file" > > This reverts commit 4c9f27270e0a7c00c10cbc56ce5c6842b47e5ab2. > > FindCoreFoundation.cmake is not needed since CoreFoundation > is a system framework. Its use has been removed by > commit f223ce03d4b94ffbb093fc8be5adf8d968f54434 > > > Diffs > - > > CMakeLists.txt 051ae6d26111725d3a296a124e8c1772e37c9940 > cmake/modules/FindCoreFoundation.cmake > c08e529ceec337c085f2f650f180b4e7897246bb > src/CMakeLists.txt a60bda0bf3d8bad7523ee7d50798c8cdb6c2eccb > src/qca_systemstore_mac.cpp 9349c90c8258d3d1f00a3796d93f94c09f5b1f2a > > Diff: https://git.reviewboard.kde.org/r/126285/diff/ > > > Testing > --- > > > Thanks, > > Samuel Gaist > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 126285: OS X build and warning fix
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126285/ --- (Updated Dec. 8, 2015, 8:48 p.m.) Review request for KDE Frameworks and Ivan Romanov. Repository: qca Description --- Revert "Add missed file" This reverts commit 4c9f27270e0a7c00c10cbc56ce5c6842b47e5ab2. FindCoreFoundation.cmake is not needed since CoreFoundation is a system framework. Its use has been removed by commit f223ce03d4b94ffbb093fc8be5adf8d968f54434 Diffs - CMakeLists.txt 051ae6d26111725d3a296a124e8c1772e37c9940 cmake/modules/FindCoreFoundation.cmake c08e529ceec337c085f2f650f180b4e7897246bb src/CMakeLists.txt a60bda0bf3d8bad7523ee7d50798c8cdb6c2eccb src/qca_systemstore_mac.cpp 9349c90c8258d3d1f00a3796d93f94c09f5b1f2a Diff: https://git.reviewboard.kde.org/r/126285/diff/ Testing --- Thanks, Samuel Gaist ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
