Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-11 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127253/
---

(Updated April 11, 2016, 9:26 vorm.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, John Layt and Wolfgang Bauer.


Bugs: 336016
https://bugs.kde.org/show_bug.cgi?id=336016


Repository: kunitconversion


Description
---

This adds the "Isreali New Shekel" currency to KUnitConversion.

Patch originally from Wolfgang Ludwig in the linked bug report but adjusted to 
Frameworks 5.

Added the new unit to the end of the enum for compatibility reasons.


Diffs
-

  src/currency.cpp 3b99644 
  src/unit.h 60e849f 

Diff: https://git.reviewboard.kde.org/r/127253/diff/


Testing
---

When I type "5 ILS" into KRunner it spits out correct results, same for "5 
sheqel"


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-09 Thread John Layt 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127253/#review94450
---


Ship it!




Ship It!

- John Layt


On April 7, 2016, 10:53 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127253/
> ---
> 
> (Updated April 7, 2016, 10:53 p.m.)
> 
> 
> Review request for KDE Frameworks, John Layt and Wolfgang Bauer.
> 
> 
> Bugs: 336016
> https://bugs.kde.org/show_bug.cgi?id=336016
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> ---
> 
> This adds the "Isreali New Shekel" currency to KUnitConversion.
> 
> Patch originally from Wolfgang Ludwig in the linked bug report but adjusted 
> to Frameworks 5.
> 
> Added the new unit to the end of the enum for compatibility reasons.
> 
> 
> Diffs
> -
> 
>   src/currency.cpp 3b99644 
>   src/unit.h 60e849f 
> 
> Diff: https://git.reviewboard.kde.org/r/127253/diff/
> 
> 
> Testing
> ---
> 
> When I type "5 ILS" into KRunner it spits out correct results, same for "5 
> sheqel"
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-09 Thread John Layt 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127253/#review94443
---



- John Layt


On April 7, 2016, 10:53 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127253/
> ---
> 
> (Updated April 7, 2016, 10:53 p.m.)
> 
> 
> Review request for KDE Frameworks, John Layt and Wolfgang Bauer.
> 
> 
> Bugs: 336016
> https://bugs.kde.org/show_bug.cgi?id=336016
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> ---
> 
> This adds the "Isreali New Shekel" currency to KUnitConversion.
> 
> Patch originally from Wolfgang Ludwig in the linked bug report but adjusted 
> to Frameworks 5.
> 
> Added the new unit to the end of the enum for compatibility reasons.
> 
> 
> Diffs
> -
> 
>   src/currency.cpp 3b99644 
>   src/unit.h 60e849f 
> 
> Diff: https://git.reviewboard.kde.org/r/127253/diff/
> 
> 
> Testing
> ---
> 
> When I type "5 ILS" into KRunner it spits out correct results, same for "5 
> sheqel"
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-07 Thread David Edmundson 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127253/#review94405
---


Ship it!




Ship It!

- David Edmundson


On April 7, 2016, 9:53 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127253/
> ---
> 
> (Updated April 7, 2016, 9:53 p.m.)
> 
> 
> Review request for KDE Frameworks, John Layt and Wolfgang Bauer.
> 
> 
> Bugs: 336016
> https://bugs.kde.org/show_bug.cgi?id=336016
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> ---
> 
> This adds the "Isreali New Shekel" currency to KUnitConversion.
> 
> Patch originally from Wolfgang Ludwig in the linked bug report but adjusted 
> to Frameworks 5.
> 
> Added the new unit to the end of the enum for compatibility reasons.
> 
> 
> Diffs
> -
> 
>   src/currency.cpp 3b99644 
>   src/unit.h 60e849f 
> 
> Diff: https://git.reviewboard.kde.org/r/127253/diff/
> 
> 
> Testing
> ---
> 
> When I type "5 ILS" into KRunner it spits out correct results, same for "5 
> sheqel"
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-07 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127253/
---

(Updated April 7, 2016, 9:53 nachm.)


Review request for KDE Frameworks, John Layt and Wolfgang Bauer.


Changes
---

Place new enum value where it belongs


Bugs: 336016
https://bugs.kde.org/show_bug.cgi?id=336016


Repository: kunitconversion


Description
---

This adds the "Isreali New Shekel" currency to KUnitConversion.

Patch originally from Wolfgang Ludwig in the linked bug report but adjusted to 
Frameworks 5.

Added the new unit to the end of the enum for compatibility reasons.


Diffs (updated)
-

  src/currency.cpp 3b99644 
  src/unit.h 60e849f 

Diff: https://git.reviewboard.kde.org/r/127253/diff/


Testing
---

When I type "5 ILS" into KRunner it spits out correct results, same for "5 
sheqel"


Thanks,

Kai Uwe Broulik

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-07 Thread John Layt 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127253/#review94365
---




src/unit.h (line 158)


Err, obviously I mean be BC, not BIC...


- John Layt


On March 2, 2016, 1:17 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127253/
> ---
> 
> (Updated March 2, 2016, 1:17 a.m.)
> 
> 
> Review request for KDE Frameworks, John Layt and Wolfgang Bauer.
> 
> 
> Bugs: 336016
> https://bugs.kde.org/show_bug.cgi?id=336016
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> ---
> 
> This adds the "Isreali New Shekel" currency to KUnitConversion.
> 
> Patch originally from Wolfgang Ludwig in the linked bug report but adjusted 
> to Frameworks 5.
> 
> Added the new unit to the end of the enum for compatibility reasons.
> 
> 
> Diffs
> -
> 
>   src/currency.cpp 3b99644 
>   src/unit.h 9e17624 
> 
> Diff: https://git.reviewboard.kde.org/r/127253/diff/
> 
> 
> Testing
> ---
> 
> When I type "5 ILS" into KRunner it spits out correct results, same for "5 
> sheqel"
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-07 Thread Kai Uwe Broulik 


> On April 7, 2016, 9:55 vorm., John Layt wrote:
> > src/unit.h, line 158
> > 
> >
> > This can be added to the end of the Currency group and still be BIC, 
> > that's why each group is hard-coded to start at a 1000 interval.

Ah, didn't know that, thanks, will update the patch.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127253/#review94364
---


On März 2, 2016, 1:17 vorm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127253/
> ---
> 
> (Updated März 2, 2016, 1:17 vorm.)
> 
> 
> Review request for KDE Frameworks, John Layt and Wolfgang Bauer.
> 
> 
> Bugs: 336016
> https://bugs.kde.org/show_bug.cgi?id=336016
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> ---
> 
> This adds the "Isreali New Shekel" currency to KUnitConversion.
> 
> Patch originally from Wolfgang Ludwig in the linked bug report but adjusted 
> to Frameworks 5.
> 
> Added the new unit to the end of the enum for compatibility reasons.
> 
> 
> Diffs
> -
> 
>   src/currency.cpp 3b99644 
>   src/unit.h 9e17624 
> 
> Diff: https://git.reviewboard.kde.org/r/127253/diff/
> 
> 
> Testing
> ---
> 
> When I type "5 ILS" into KRunner it spits out correct results, same for "5 
> sheqel"
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-07 Thread John Layt 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127253/#review94364
---



One correction to the enum.


src/unit.h (line 158)


This can be added to the end of the Currency group and still be BIC, that's 
why each group is hard-coded to start at a 1000 interval.


- John Layt


On March 2, 2016, 1:17 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127253/
> ---
> 
> (Updated March 2, 2016, 1:17 a.m.)
> 
> 
> Review request for KDE Frameworks, John Layt and Wolfgang Bauer.
> 
> 
> Bugs: 336016
> https://bugs.kde.org/show_bug.cgi?id=336016
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> ---
> 
> This adds the "Isreali New Shekel" currency to KUnitConversion.
> 
> Patch originally from Wolfgang Ludwig in the linked bug report but adjusted 
> to Frameworks 5.
> 
> Added the new unit to the end of the enum for compatibility reasons.
> 
> 
> Diffs
> -
> 
>   src/currency.cpp 3b99644 
>   src/unit.h 9e17624 
> 
> Diff: https://git.reviewboard.kde.org/r/127253/diff/
> 
> 
> Testing
> ---
> 
> When I type "5 ILS" into KRunner it spits out correct results, same for "5 
> sheqel"
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127253: [KUnitConversion] Add ILS (Israeli New Shekel) currency

2016-04-07 Thread Kai Uwe Broulik 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127253/#review94362
---



Ping

- Kai Uwe Broulik


On März 2, 2016, 1:17 vorm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127253/
> ---
> 
> (Updated März 2, 2016, 1:17 vorm.)
> 
> 
> Review request for KDE Frameworks, John Layt and Wolfgang Bauer.
> 
> 
> Bugs: 336016
> https://bugs.kde.org/show_bug.cgi?id=336016
> 
> 
> Repository: kunitconversion
> 
> 
> Description
> ---
> 
> This adds the "Isreali New Shekel" currency to KUnitConversion.
> 
> Patch originally from Wolfgang Ludwig in the linked bug report but adjusted 
> to Frameworks 5.
> 
> Added the new unit to the end of the enum for compatibility reasons.
> 
> 
> Diffs
> -
> 
>   src/currency.cpp 3b99644 
>   src/unit.h 9e17624 
> 
> Diff: https://git.reviewboard.kde.org/r/127253/diff/
> 
> 
> Testing
> ---
> 
> When I type "5 ILS" into KRunner it spits out correct results, same for "5 
> sheqel"
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel