Re: Review Request 127686: Provide a way to disable FAM and inotify use in KDirWatch.

2016-05-05 Thread Gleb Popov 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127686/
---

(Updated May 5, 2016, 6:05 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks, Aleix Pol Gonzalez and David Faure.


Changes
---

Submitted with commit 359e837f6c18d528d3b5febff34e1a174448d04e by Gleb Popov to 
branch master.


Repository: kcoreaddons


Description
---

This is useful for distribution package maintainers to prevent accidental 
feature activation.


Diffs
-

  CMakeLists.txt 2ce2bc9 

Diff: https://git.reviewboard.kde.org/r/127686/diff/


Testing
---


Thanks,

Gleb Popov

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127686: Provide a way to disable FAM and inotify use in KDirWatch.

2016-04-22 Thread Gleb Popov 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127686/
---

(Updated April 22, 2016, 2:10 p.m.)


Review request for KDE Frameworks, Aleix Pol Gonzalez and David Faure.


Repository: kcoreaddons


Description
---

This is useful for distribution package maintainers to prevent accidental 
feature activation.


Diffs (updated)
-

  CMakeLists.txt 2ce2bc9 

Diff: https://git.reviewboard.kde.org/r/127686/diff/


Testing
---


Thanks,

Gleb Popov

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127686: Provide a way to disable FAM and inotify use in KDirWatch.

2016-04-22 Thread Johannes Huber 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127686/#review94758
---




CMakeLists.txt (line 30)


FAM can already disabled with cmake built in feature: 
-DCMAKE_DISBALE_FIND_PACKAGE


- Johannes Huber


On April 21, 2016, 10:19 vorm., Gleb Popov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127686/
> ---
> 
> (Updated April 21, 2016, 10:19 vorm.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and David Faure.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> This is useful for distribution package maintainers to prevent accidental 
> feature activation.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 2ce2bc9 
> 
> Diff: https://git.reviewboard.kde.org/r/127686/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127686: Provide a way to disable FAM and inotify use in KDirWatch.

2016-04-22 Thread David Faure 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127686/#review94754
---


Ship it!




Ship It!

- David Faure


On April 21, 2016, 8:19 a.m., Gleb Popov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127686/
> ---
> 
> (Updated April 21, 2016, 8:19 a.m.)
> 
> 
> Review request for KDE Frameworks, Aleix Pol Gonzalez and David Faure.
> 
> 
> Repository: kcoreaddons
> 
> 
> Description
> ---
> 
> This is useful for distribution package maintainers to prevent accidental 
> feature activation.
> 
> 
> Diffs
> -
> 
>   CMakeLists.txt 2ce2bc9 
> 
> Diff: https://git.reviewboard.kde.org/r/127686/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127686: Provide a way to disable FAM and inotify use in KDirWatch.

2016-04-21 Thread Gleb Popov 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127686/
---

(Updated April 21, 2016, 11:19 a.m.)


Review request for KDE Frameworks, Aleix Pol Gonzalez and David Faure.


Changes
---

Rephrase options descriptions.


Repository: kcoreaddons


Description
---

This is useful for distribution package maintainers to prevent accidental 
feature activation.


Diffs (updated)
-

  CMakeLists.txt 2ce2bc9 

Diff: https://git.reviewboard.kde.org/r/127686/diff/


Testing
---


Thanks,

Gleb Popov

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 127686: Provide a way to disable FAM and inotify use in KDirWatch.

2016-04-19 Thread Gleb Popov 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127686/
---

(Updated April 19, 2016, 1:24 p.m.)


Review request for KDE Frameworks, Aleix Pol Gonzalez and David Faure.


Repository: kcoreaddons


Description
---

This is useful for distribution package maintainers to prevent accidental 
feature activation.


Diffs
-

  CMakeLists.txt 2ce2bc9 

Diff: https://git.reviewboard.kde.org/r/127686/diff/


Testing
---


Thanks,

Gleb Popov

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel