Re: Review Request 128464: Allow scrolling in config windows for small screens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/ --- (Updated July 18, 2016, 1:48 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Eike Hein. Changes --- Submitted with commit 574abcd05ece484da77635e2b8f23d3f4c1af5dd by Olivier CHURLAUD to branch master. Bugs: 362234 https://bugs.kde.org/show_bug.cgi?id=362234 Repository: kconfigwidgets Description --- Often I cannot reach the validation buttons of config windows. With this fix I can. The config page has now scroll bars when needed. Diffs - src/kconfigdialog.cpp 83c96b6 Diff: https://git.reviewboard.kde.org/r/128464/diff/ Testing --- Compile and tested: Good behavior Thanks, Olivier Churlaud ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128464: Allow scrolling in config windows for small screens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/ --- (Updated July 18, 2016, 3:46 p.m.) Review request for KDE Frameworks and Eike Hein. Bugs: 362234 https://bugs.kde.org/show_bug.cgi?id=362234 Repository: kconfigwidgets Description --- Often I cannot reach the validation buttons of config windows. With this fix I can. The config page has now scroll bars when needed. Diffs - src/kconfigdialog.cpp 83c96b6 Diff: https://git.reviewboard.kde.org/r/128464/diff/ Testing --- Compile and tested: Good behavior Thanks, Olivier Churlaud ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128464: Allow scrolling in config windows for small screens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/ --- (Updated July 16, 2016, 2:40 p.m.) Review request for KDE Frameworks and Eike Hein. Changes --- Better handling of sizes Bugs: 360260 and 362234 https://bugs.kde.org/show_bug.cgi?id=360260 https://bugs.kde.org/show_bug.cgi?id=362234 Repository: kconfigwidgets Description --- Often I cannot reach the validation buttons of config windows. With this fix I can. The config page has now scroll bars when needed. Diffs (updated) - src/kconfigdialog.cpp 83c96b6 Diff: https://git.reviewboard.kde.org/r/128464/diff/ Testing --- Compile and tested: Good behavior Thanks, Olivier Churlaud ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128464: Allow scrolling in config windows for small screens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/#review97474 --- I just found out one minor issue: the config window now appear too small. I don't know how to define a good default size... - Olivier Churlaud On July 16, 2016, 12:02 p.m., Olivier Churlaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128464/ > --- > > (Updated July 16, 2016, 12:02 p.m.) > > > Review request for KDE Frameworks and Eike Hein. > > > Bugs: 360260 and 362234 > https://bugs.kde.org/show_bug.cgi?id=360260 > https://bugs.kde.org/show_bug.cgi?id=362234 > > > Repository: kconfigwidgets > > > Description > --- > > Often I cannot reach the validation buttons of config windows. With this fix > I can. > > The config page has now scroll bars when needed. > > > Diffs > - > > src/kconfigdialog.cpp 83c96b6 > > Diff: https://git.reviewboard.kde.org/r/128464/diff/ > > > Testing > --- > > Compile and tested: Good behavior > > > Thanks, > > Olivier Churlaud > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128464: Allow scrolling in config windows for small screens
> On July 16, 2016, 9:53 a.m., Sune Vuorela wrote: > > looks good. > > Olivier Churlaud wrote: > Who should provide the ship it flag? I don't know who is the maintainer... if no one else gives a more formal shipit by monday, consider this a shipit. - Sune --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/#review97467 --- On July 16, 2016, 10:02 a.m., Olivier Churlaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128464/ > --- > > (Updated July 16, 2016, 10:02 a.m.) > > > Review request for KDE Frameworks and Eike Hein. > > > Bugs: 360260 and 362234 > https://bugs.kde.org/show_bug.cgi?id=360260 > https://bugs.kde.org/show_bug.cgi?id=362234 > > > Repository: kconfigwidgets > > > Description > --- > > Often I cannot reach the validation buttons of config windows. With this fix > I can. > > The config page has now scroll bars when needed. > > > Diffs > - > > src/kconfigdialog.cpp 83c96b6 > > Diff: https://git.reviewboard.kde.org/r/128464/diff/ > > > Testing > --- > > Compile and tested: Good behavior > > > Thanks, > > Olivier Churlaud > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128464: Allow scrolling in config windows for small screens
> On July 16, 2016, 11:53 a.m., Sune Vuorela wrote: > > looks good. Who should provide the ship it flag? I don't know who is the maintainer... - Olivier --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/#review97467 --- On July 16, 2016, 2:52 a.m., Olivier Churlaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128464/ > --- > > (Updated July 16, 2016, 2:52 a.m.) > > > Review request for KDE Frameworks. > > > Bugs: 360260 and 362234 > https://bugs.kde.org/show_bug.cgi?id=360260 > https://bugs.kde.org/show_bug.cgi?id=362234 > > > Repository: kconfigwidgets > > > Description > --- > > Often I cannot reach the validation buttons of config windows. With this fix > I can. > > The config page has now scroll bars when needed. > > > Diffs > - > > src/kconfigdialog.cpp 83c96b6 > > Diff: https://git.reviewboard.kde.org/r/128464/diff/ > > > Testing > --- > > Compile and tested: Good behavior > > > Thanks, > > Olivier Churlaud > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128464: Allow scrolling in config windows for small screens
> On July 16, 2016, 1:06 a.m., Olivier Churlaud wrote: > > Same patch should be applied to Konversation. I think you need to submit i to konversation as well, then. - Sune --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/#review97455 --- On July 16, 2016, 12:52 a.m., Olivier Churlaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128464/ > --- > > (Updated July 16, 2016, 12:52 a.m.) > > > Review request for KDE Frameworks. > > > Bugs: 360260 and 362234 > https://bugs.kde.org/show_bug.cgi?id=360260 > https://bugs.kde.org/show_bug.cgi?id=362234 > > > Repository: kconfigwidgets > > > Description > --- > > Often I cannot reach the validation buttons of config windows. With this fix > I can. > > The config page has now scroll bars when needed. > > > Diffs > - > > src/kconfigdialog.cpp 83c96b6 > > Diff: https://git.reviewboard.kde.org/r/128464/diff/ > > > Testing > --- > > Compile and tested: Good behavior > > > Thanks, > > Olivier Churlaud > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128464: Allow scrolling in config windows for small screens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/#review97467 --- looks good. - Sune Vuorela On July 16, 2016, 12:52 a.m., Olivier Churlaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128464/ > --- > > (Updated July 16, 2016, 12:52 a.m.) > > > Review request for KDE Frameworks. > > > Bugs: 360260 and 362234 > https://bugs.kde.org/show_bug.cgi?id=360260 > https://bugs.kde.org/show_bug.cgi?id=362234 > > > Repository: kconfigwidgets > > > Description > --- > > Often I cannot reach the validation buttons of config windows. With this fix > I can. > > The config page has now scroll bars when needed. > > > Diffs > - > > src/kconfigdialog.cpp 83c96b6 > > Diff: https://git.reviewboard.kde.org/r/128464/diff/ > > > Testing > --- > > Compile and tested: Good behavior > > > Thanks, > > Olivier Churlaud > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 128464: Allow scrolling in config windows for small screens
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128464/#review97455 --- Same patch should be applied to Konversation. - Olivier Churlaud On July 16, 2016, 2:52 a.m., Olivier Churlaud wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128464/ > --- > > (Updated July 16, 2016, 2:52 a.m.) > > > Review request for KDE Frameworks. > > > Bugs: 360260 and 362234 > https://bugs.kde.org/show_bug.cgi?id=360260 > https://bugs.kde.org/show_bug.cgi?id=362234 > > > Repository: kconfigwidgets > > > Description > --- > > Often I cannot reach the validation buttons of config windows. With this fix > I can. > > The config page has now scroll bars when needed. > > > Diffs > - > > src/kconfigdialog.cpp 83c96b6 > > Diff: https://git.reviewboard.kde.org/r/128464/diff/ > > > Testing > --- > > Compile and tested: Good behavior > > > Thanks, > > Olivier Churlaud > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
