Re: Review Request 129260: Add find module for QtPlatformSupport

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/
---

(Updated Feb. 8, 2017, 2:25 nachm.)


Status
--

This change has been discarded.


Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.


Repository: extra-cmake-modules


Description
---

Comes from KWin and will eventually be used in Plasma Integration, hence moving 
it to extra-cmake-modules.


Diffs
-

  find-modules/FindQt5PlatformSupport.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/129260/diff/


Testing
---

Removed it from KWin, built KWin, worked.

Built plasma-integration with QDBusMenu private stuff, worked, although 
includes there sometimes omit the QtPlatformSupport/ prefix but this is an 
upstream issue since it works with the files Kwin includes.


Thanks,

Kai Uwe Broulik

Re: Review Request 129260: Add find module for QtPlatformSupport

[Martin Gräßlin]

> On Oct. 27, 2016, 7:39 a.m., Martin Gräßlin wrote:
> > Due to https://git.reviewboard.kde.org/r/129268/ I'm giving a -2 to adding 
> > to ECM
> 
> David Edmundson wrote:
> To this specific patch, or the concept in general?

To this specific patch


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100323
---


On Oct. 26, 2016, 11:17 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> ---
> 
> (Updated Oct. 26, 2016, 11:17 a.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Comes from KWin and will eventually be used in Plasma Integration, hence 
> moving it to extra-cmake-modules.
> 
> 
> Diffs
> -
> 
>   find-modules/FindQt5PlatformSupport.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
> 
> 
> Testing
> ---
> 
> Removed it from KWin, built KWin, worked.
> 
> Built plasma-integration with QDBusMenu private stuff, worked, although 
> includes there sometimes omit the QtPlatformSupport/ prefix but this is an 
> upstream issue since it works with the files Kwin includes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 129260: Add find module for QtPlatformSupport

[David Edmundson]

> On Oct. 27, 2016, 5:39 a.m., Martin Gräßlin wrote:
> > Due to https://git.reviewboard.kde.org/r/129268/ I'm giving a -2 to adding 
> > to ECM

To this specific patch, or the concept in general?


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100323
---


On Oct. 26, 2016, 9:17 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> ---
> 
> (Updated Oct. 26, 2016, 9:17 a.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Comes from KWin and will eventually be used in Plasma Integration, hence 
> moving it to extra-cmake-modules.
> 
> 
> Diffs
> -
> 
>   find-modules/FindQt5PlatformSupport.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
> 
> 
> Testing
> ---
> 
> Removed it from KWin, built KWin, worked.
> 
> Built plasma-integration with QDBusMenu private stuff, worked, although 
> includes there sometimes omit the QtPlatformSupport/ prefix but this is an 
> upstream issue since it works with the files Kwin includes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 129260: Add find module for QtPlatformSupport

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100323
---



Due to https://git.reviewboard.kde.org/r/129268/ I'm giving a -2 to adding to 
ECM

- Martin Gräßlin


On Oct. 26, 2016, 11:17 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> ---
> 
> (Updated Oct. 26, 2016, 11:17 a.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Comes from KWin and will eventually be used in Plasma Integration, hence 
> moving it to extra-cmake-modules.
> 
> 
> Diffs
> -
> 
>   find-modules/FindQt5PlatformSupport.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
> 
> 
> Testing
> ---
> 
> Removed it from KWin, built KWin, worked.
> 
> Built plasma-integration with QDBusMenu private stuff, worked, although 
> includes there sometimes omit the QtPlatformSupport/ prefix but this is an 
> upstream issue since it works with the files Kwin includes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 129260: Add find module for QtPlatformSupport

[Kai Uwe Broulik]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/
---

(Updated Okt. 26, 2016, 9:17 vorm.)


Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.


Changes
---

* Apply patch by Hrvoje, thanks!

After adjusting CMakeLists to use Qt5::PlatformSupport and the include private 
dirs it works with both Kwin and plasma-integration


Repository: extra-cmake-modules


Description
---

Comes from KWin and will eventually be used in Plasma Integration, hence moving 
it to extra-cmake-modules.


Diffs (updated)
-

  find-modules/FindQt5PlatformSupport.cmake PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/129260/diff/


Testing
---

Removed it from KWin, built KWin, worked.

Built plasma-integration with QDBusMenu private stuff, worked, although 
includes there sometimes omit the QtPlatformSupport/ prefix but this is an 
upstream issue since it works with the files Kwin includes.


Thanks,

Kai Uwe Broulik

Re: Review Request 129260: Add find module for QtPlatformSupport

[Hrvoje Senjan]

> On Oct. 25, 2016, 1:31 p.m., Hrvoje Senjan wrote:
> > find-modules/FindQt5PlatformSupport.cmake, line 75
> > 
> >
> > Shouldn't this be rather Qt5PlatformSupport_PRIVATE_INCLUDE_DIRS, and  
> > ${PKG_Qt5PlatformSupport_INCLUDEDIR}/QtPlatformSupport/ be marked as 
> > Qt5PlatformSupport_INCLUDE_DIR?
> 
> Kai Uwe Broulik wrote:
> I suppose? Dunno, I just copied it from KWin and I know nothing about 
> CMake syntax.
> 
> Hrvoje Senjan wrote:
> Well, all other modules have both INCLUDE_DIRS and PRIVATE_INCLUDE_DIRS...
> Also, IMO it's a better idea to include ECMQueryQmake and use e.g. 
> query_qmake(qt_install_include_dir QT_INSTALL_HEADERS) then to use pkgconfig.
> 
> Kai Uwe Broulik wrote:
> You've just lost me.

Something like http://paste.opensuse.org/74147268


- Hrvoje


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100256
---


On Oct. 25, 2016, 1:21 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> ---
> 
> (Updated Oct. 25, 2016, 1:21 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Comes from KWin and will eventually be used in Plasma Integration, hence 
> moving it to extra-cmake-modules.
> 
> 
> Diffs
> -
> 
>   find-modules/FindQt5PlatformSupport.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
> 
> 
> Testing
> ---
> 
> Removed it from KWin, built KWin, worked.
> 
> Built plasma-integration with QDBusMenu private stuff, worked, although 
> includes there sometimes omit the QtPlatformSupport/ prefix but this is an 
> upstream issue since it works with the files Kwin includes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 129260: Add find module for QtPlatformSupport

[Kai Uwe Broulik]

> On Okt. 25, 2016, 11:31 vorm., Hrvoje Senjan wrote:
> > find-modules/FindQt5PlatformSupport.cmake, line 75
> > 
> >
> > Shouldn't this be rather Qt5PlatformSupport_PRIVATE_INCLUDE_DIRS, and  
> > ${PKG_Qt5PlatformSupport_INCLUDEDIR}/QtPlatformSupport/ be marked as 
> > Qt5PlatformSupport_INCLUDE_DIR?
> 
> Kai Uwe Broulik wrote:
> I suppose? Dunno, I just copied it from KWin and I know nothing about 
> CMake syntax.
> 
> Hrvoje Senjan wrote:
> Well, all other modules have both INCLUDE_DIRS and PRIVATE_INCLUDE_DIRS...
> Also, IMO it's a better idea to include ECMQueryQmake and use e.g. 
> query_qmake(qt_install_include_dir QT_INSTALL_HEADERS) then to use pkgconfig.

You've just lost me.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100256
---


On Okt. 25, 2016, 11:21 vorm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> ---
> 
> (Updated Okt. 25, 2016, 11:21 vorm.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Comes from KWin and will eventually be used in Plasma Integration, hence 
> moving it to extra-cmake-modules.
> 
> 
> Diffs
> -
> 
>   find-modules/FindQt5PlatformSupport.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
> 
> 
> Testing
> ---
> 
> Removed it from KWin, built KWin, worked.
> 
> Built plasma-integration with QDBusMenu private stuff, worked, although 
> includes there sometimes omit the QtPlatformSupport/ prefix but this is an 
> upstream issue since it works with the files Kwin includes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 129260: Add find module for QtPlatformSupport

[Hrvoje Senjan]

> On Oct. 25, 2016, 1:31 p.m., Hrvoje Senjan wrote:
> > find-modules/FindQt5PlatformSupport.cmake, line 75
> > 
> >
> > Shouldn't this be rather Qt5PlatformSupport_PRIVATE_INCLUDE_DIRS, and  
> > ${PKG_Qt5PlatformSupport_INCLUDEDIR}/QtPlatformSupport/ be marked as 
> > Qt5PlatformSupport_INCLUDE_DIR?
> 
> Kai Uwe Broulik wrote:
> I suppose? Dunno, I just copied it from KWin and I know nothing about 
> CMake syntax.

Well, all other modules have both INCLUDE_DIRS and PRIVATE_INCLUDE_DIRS...
Also, IMO it's a better idea to include ECMQueryQmake and use e.g. 
query_qmake(qt_install_include_dir QT_INSTALL_HEADERS) then to use pkgconfig.


- Hrvoje


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100256
---


On Oct. 25, 2016, 1:21 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> ---
> 
> (Updated Oct. 25, 2016, 1:21 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Comes from KWin and will eventually be used in Plasma Integration, hence 
> moving it to extra-cmake-modules.
> 
> 
> Diffs
> -
> 
>   find-modules/FindQt5PlatformSupport.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
> 
> 
> Testing
> ---
> 
> Removed it from KWin, built KWin, worked.
> 
> Built plasma-integration with QDBusMenu private stuff, worked, although 
> includes there sometimes omit the QtPlatformSupport/ prefix but this is an 
> upstream issue since it works with the files Kwin includes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 129260: Add find module for QtPlatformSupport

[Kevin Funk]

> On Oct. 25, 2016, 11:37 a.m., Aleix Pol Gonzalez wrote:
> > Shouldn't this be in Qt? What am I missing?
> 
> Martin Gräßlin wrote:
> Yes it should, but it isn't. No idea why not.
> 
> Hrvoje Senjan wrote:
> The module is internal, so it intentionally doesn't install any cmake 
> files.

Correct, that's why. See: https://bugreports.qt.io/browse/QTBUG-50073


- Kevin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100257
---


On Oct. 25, 2016, 11:21 a.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> ---
> 
> (Updated Oct. 25, 2016, 11:21 a.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Comes from KWin and will eventually be used in Plasma Integration, hence 
> moving it to extra-cmake-modules.
> 
> 
> Diffs
> -
> 
>   find-modules/FindQt5PlatformSupport.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
> 
> 
> Testing
> ---
> 
> Removed it from KWin, built KWin, worked.
> 
> Built plasma-integration with QDBusMenu private stuff, worked, although 
> includes there sometimes omit the QtPlatformSupport/ prefix but this is an 
> upstream issue since it works with the files Kwin includes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 129260: Add find module for QtPlatformSupport

[Hrvoje Senjan]

> On Oct. 25, 2016, 1:37 p.m., Aleix Pol Gonzalez wrote:
> > Shouldn't this be in Qt? What am I missing?
> 
> Martin Gräßlin wrote:
> Yes it should, but it isn't. No idea why not.

The module is internal, so it intentionally doesn't install any cmake files.


- Hrvoje


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100257
---


On Oct. 25, 2016, 1:21 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> ---
> 
> (Updated Oct. 25, 2016, 1:21 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Comes from KWin and will eventually be used in Plasma Integration, hence 
> moving it to extra-cmake-modules.
> 
> 
> Diffs
> -
> 
>   find-modules/FindQt5PlatformSupport.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
> 
> 
> Testing
> ---
> 
> Removed it from KWin, built KWin, worked.
> 
> Built plasma-integration with QDBusMenu private stuff, worked, although 
> includes there sometimes omit the QtPlatformSupport/ prefix but this is an 
> upstream issue since it works with the files Kwin includes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 129260: Add find module for QtPlatformSupport

[Kai Uwe Broulik]

> On Okt. 25, 2016, 11:31 vorm., Hrvoje Senjan wrote:
> > find-modules/FindQt5PlatformSupport.cmake, line 75
> > 
> >
> > Shouldn't this be rather Qt5PlatformSupport_PRIVATE_INCLUDE_DIRS, and  
> > ${PKG_Qt5PlatformSupport_INCLUDEDIR}/QtPlatformSupport/ be marked as 
> > Qt5PlatformSupport_INCLUDE_DIR?

I suppose? Dunno, I just copied it from KWin and I know nothing about CMake 
syntax.


- Kai Uwe


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100256
---


On Okt. 25, 2016, 11:21 vorm., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> ---
> 
> (Updated Okt. 25, 2016, 11:21 vorm.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Comes from KWin and will eventually be used in Plasma Integration, hence 
> moving it to extra-cmake-modules.
> 
> 
> Diffs
> -
> 
>   find-modules/FindQt5PlatformSupport.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
> 
> 
> Testing
> ---
> 
> Removed it from KWin, built KWin, worked.
> 
> Built plasma-integration with QDBusMenu private stuff, worked, although 
> includes there sometimes omit the QtPlatformSupport/ prefix but this is an 
> upstream issue since it works with the files Kwin includes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 129260: Add find module for QtPlatformSupport

[Martin Gräßlin]

> On Oct. 25, 2016, 1:37 p.m., Aleix Pol Gonzalez wrote:
> > Shouldn't this be in Qt? What am I missing?

Yes it should, but it isn't. No idea why not.


- Martin


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100257
---


On Oct. 25, 2016, 1:21 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> ---
> 
> (Updated Oct. 25, 2016, 1:21 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Comes from KWin and will eventually be used in Plasma Integration, hence 
> moving it to extra-cmake-modules.
> 
> 
> Diffs
> -
> 
>   find-modules/FindQt5PlatformSupport.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
> 
> 
> Testing
> ---
> 
> Removed it from KWin, built KWin, worked.
> 
> Built plasma-integration with QDBusMenu private stuff, worked, although 
> includes there sometimes omit the QtPlatformSupport/ prefix but this is an 
> upstream issue since it works with the files Kwin includes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 129260: Add find module for QtPlatformSupport

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100257
---



Shouldn't this be in Qt? What am I missing?

- Aleix Pol Gonzalez


On Oct. 25, 2016, 1:21 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> ---
> 
> (Updated Oct. 25, 2016, 1:21 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Comes from KWin and will eventually be used in Plasma Integration, hence 
> moving it to extra-cmake-modules.
> 
> 
> Diffs
> -
> 
>   find-modules/FindQt5PlatformSupport.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
> 
> 
> Testing
> ---
> 
> Removed it from KWin, built KWin, worked.
> 
> Built plasma-integration with QDBusMenu private stuff, worked, although 
> includes there sometimes omit the QtPlatformSupport/ prefix but this is an 
> upstream issue since it works with the files Kwin includes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 129260: Add find module for QtPlatformSupport

[Hrvoje Senjan]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100256
---




find-modules/FindQt5PlatformSupport.cmake (line 75)


Shouldn't this be rather Qt5PlatformSupport_PRIVATE_INCLUDE_DIRS, and  
${PKG_Qt5PlatformSupport_INCLUDEDIR}/QtPlatformSupport/ be marked as 
Qt5PlatformSupport_INCLUDE_DIR?


- Hrvoje Senjan


On Oct. 25, 2016, 1:21 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> ---
> 
> (Updated Oct. 25, 2016, 1:21 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Comes from KWin and will eventually be used in Plasma Integration, hence 
> moving it to extra-cmake-modules.
> 
> 
> Diffs
> -
> 
>   find-modules/FindQt5PlatformSupport.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
> 
> 
> Testing
> ---
> 
> Removed it from KWin, built KWin, worked.
> 
> Built plasma-integration with QDBusMenu private stuff, worked, although 
> includes there sometimes omit the QtPlatformSupport/ prefix but this is an 
> upstream issue since it works with the files Kwin includes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

Re: Review Request 129260: Add find module for QtPlatformSupport

[Martin Gräßlin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129260/#review100255
---



+1

- Martin Gräßlin


On Oct. 25, 2016, 1:21 p.m., Kai Uwe Broulik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129260/
> ---
> 
> (Updated Oct. 25, 2016, 1:21 p.m.)
> 
> 
> Review request for KDE Frameworks, Alex Merry and Martin Gräßlin.
> 
> 
> Repository: extra-cmake-modules
> 
> 
> Description
> ---
> 
> Comes from KWin and will eventually be used in Plasma Integration, hence 
> moving it to extra-cmake-modules.
> 
> 
> Diffs
> -
> 
>   find-modules/FindQt5PlatformSupport.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/129260/diff/
> 
> 
> Testing
> ---
> 
> Removed it from KWin, built KWin, worked.
> 
> Built plasma-integration with QDBusMenu private stuff, worked, although 
> includes there sometimes omit the QtPlatformSupport/ prefix but this is an 
> upstream issue since it works with the files Kwin includes.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>