Re: kxmlgui regression on OS X between 5.32.0 and 5.35.0

2017-06-20 Thread René J . V . Bertin 
David Faure wrote:

> * 78e572dadf - Revert "use transientparent directly" (7 days ago)
> []
> * 4690808e65 - use transientparent directly (5 weeks ago)
> 

Thanks, cherry-picking 78e572dadf resolves the issue without any further 
changes 
required. 

I'll check the proposed Qt change (provided it applies to 5.8.0).

R.

Re: kxmlgui regression on OS X between 5.32.0 and 5.35.0

2017-06-20 Thread René J . V . Bertin 
On Tuesday June 20 2017 13:19:51 David Faure wrote:

>k-f-d is the proper place for this discussion => CC'ed.

I know, at least theoretically. In practice I didn't want to create noise there 
where it might not interest the majority and fail to reach the person(s) most 
likely to have an answer. After all, finding the regression is only the 1st 
step.

R.

Re: kxmlgui regression on OS X between 5.32.0 and 5.35.0

2017-06-20 Thread David Faure 
On mardi 20 juin 2017 13:01:29 CEST René J.V. Bertin wrote:
> Hi,
> 
> Apologies for writing you directly and not a generic mailing list.
> 
> I noticed an issue that was introduced by one of the relatively few changes
> to KXmlGui between v5.32.0 and v5.35.0 : the QtCurve configuration dialog
> (https://cgit.kde.org/qtcurve.git/tree/qt5/config) no longer accepts GUI
> events on Mac (using the Cocoa QPA, no problem when using the "officious"
> XCB QPA). This dialog is accessible only as a KCM, and thus requires
> kcmshell5. Functionality is restored after reverting to kxmlgui 5.32.0 .
> 
> Which of the commits to kxmlgui could have caused the issue, and what would
> be the proper (best) way to address it?

Not 100% sure, but most likely it's the two kxmlgui commits that got reverted 
after 5.35 was released:

* 1bc3a0b41c - Revert "When building menu hyerarchies, parent menus to their 
containers" (6 days ago)
* 78e572dadf - Revert "use transientparent directly" (7 days ago)
[]
* 4690808e65 - use transientparent directly (5 weeks ago)
* b5af0296cb - When building menu hyerarchies, parent menus to their containers 
(6 weeks ago)

Please test these reverts.

k-f-d is the proper place for this discussion => CC'ed.

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5