Re: Review Request 111841: Prefer job-exec() to synchronousRun
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111841/#review36958 --- kio/tests/netaccesstest.cpp http://git.reviewboard.kde.org/r/111841/#comment27258 Well you're not testing NetAccess anymore then. :-) This one shouldn't be changed. staging/kiconthemes/autotests/kiconloader_unittest.cpp http://git.reviewboard.kde.org/r/111841/#comment27259 Why this change? - Kevin Ottens On Aug. 1, 2013, 5:52 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111841/ --- (Updated Aug. 1, 2013, 5:52 p.m.) Review request for KDE Frameworks. Description --- Ports all uses of NetAccess::synchronousRun to KJob::exec() but one in khtml, but there it should be re-thought, the change is not straight-forward (XmlHttpRequest). Diffs - kfile/kdirselectdialog.cpp 68c4b93 kfile/kfilewidget.cpp 2fa1d28 kio/kio/paste.cpp c7c43e1 kio/tests/fileundomanagertest.cpp 5fe746f kio/tests/jobguitest.cpp 5a6c950 kio/tests/jobremotetest.cpp 5759b21 kio/tests/jobtest.cpp ceaf605 kio/tests/kdirmodeltest.cpp 8059fa8 kio/tests/netaccesstest.cpp 174feb0 staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c staging/kunitconversion/src/kunitconversion/currency.cpp 8d18f633 Diff: http://git.reviewboard.kde.org/r/111841/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111841: Prefer job-exec() to synchronousRun
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111841/ --- (Updated Aug. 2, 2013, 9:38 a.m.) Review request for KDE Frameworks. Changes --- revert crazy change and unrelated debug entry. Description --- Ports all uses of NetAccess::synchronousRun to KJob::exec() but one in khtml, but there it should be re-thought, the change is not straight-forward (XmlHttpRequest). Diffs (updated) - kfile/kdirselectdialog.cpp 68c4b93 kfile/kfilewidget.cpp 2fa1d28 kio/kio/paste.cpp c7c43e1 kio/tests/fileundomanagertest.cpp 5fe746f kio/tests/jobguitest.cpp 5a6c950 kio/tests/jobremotetest.cpp 5759b21 kio/tests/jobtest.cpp ceaf605 kio/tests/kdirmodeltest.cpp 8059fa8 staging/kunitconversion/src/kunitconversion/currency.cpp 8d18f633 Diff: http://git.reviewboard.kde.org/r/111841/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111841: Prefer job-exec() to synchronousRun
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111841/#review36962 --- Ship it! Ship It! - Kevin Ottens On Aug. 2, 2013, 9:38 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111841/ --- (Updated Aug. 2, 2013, 9:38 a.m.) Review request for KDE Frameworks. Description --- Ports all uses of NetAccess::synchronousRun to KJob::exec() but one in khtml, but there it should be re-thought, the change is not straight-forward (XmlHttpRequest). Diffs - kfile/kdirselectdialog.cpp 68c4b93 kfile/kfilewidget.cpp 2fa1d28 kio/kio/paste.cpp c7c43e1 kio/tests/fileundomanagertest.cpp 5fe746f kio/tests/jobguitest.cpp 5a6c950 kio/tests/jobremotetest.cpp 5759b21 kio/tests/jobtest.cpp ceaf605 kio/tests/kdirmodeltest.cpp 8059fa8 staging/kunitconversion/src/kunitconversion/currency.cpp 8d18f633 Diff: http://git.reviewboard.kde.org/r/111841/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111841: Prefer job-exec() to synchronousRun
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111841/#review36965 --- This review has been submitted with commit a3df15c674a1f515645ee5a6fcedc298c5a47811 by Aleix Pol to branch frameworks. - Commit Hook On Aug. 2, 2013, 9:38 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111841/ --- (Updated Aug. 2, 2013, 9:38 a.m.) Review request for KDE Frameworks. Description --- Ports all uses of NetAccess::synchronousRun to KJob::exec() but one in khtml, but there it should be re-thought, the change is not straight-forward (XmlHttpRequest). Diffs - kfile/kdirselectdialog.cpp 68c4b93 kfile/kfilewidget.cpp 2fa1d28 kio/kio/paste.cpp c7c43e1 kio/tests/fileundomanagertest.cpp 5fe746f kio/tests/jobguitest.cpp 5a6c950 kio/tests/jobremotetest.cpp 5759b21 kio/tests/jobtest.cpp ceaf605 kio/tests/kdirmodeltest.cpp 8059fa8 staging/kunitconversion/src/kunitconversion/currency.cpp 8d18f633 Diff: http://git.reviewboard.kde.org/r/111841/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111841: Prefer job-exec() to synchronousRun
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111841/ --- (Updated Aug. 2, 2013, 10:18 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Description --- Ports all uses of NetAccess::synchronousRun to KJob::exec() but one in khtml, but there it should be re-thought, the change is not straight-forward (XmlHttpRequest). Diffs - kfile/kdirselectdialog.cpp 68c4b93 kfile/kfilewidget.cpp 2fa1d28 kio/kio/paste.cpp c7c43e1 kio/tests/fileundomanagertest.cpp 5fe746f kio/tests/jobguitest.cpp 5a6c950 kio/tests/jobremotetest.cpp 5759b21 kio/tests/jobtest.cpp ceaf605 kio/tests/kdirmodeltest.cpp 8059fa8 staging/kunitconversion/src/kunitconversion/currency.cpp 8d18f633 Diff: http://git.reviewboard.kde.org/r/111841/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 111841: Prefer job-exec() to synchronousRun
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111841/ --- Review request for KDE Frameworks. Description --- Ports all uses of NetAccess::synchronousRun to KJob::exec() but one in khtml, but there it should be re-thought, the change is not straight-forward (XmlHttpRequest). Diffs - kfile/kdirselectdialog.cpp 68c4b93 kfile/kfilewidget.cpp 2fa1d28 kio/kio/paste.cpp c7c43e1 kio/tests/fileundomanagertest.cpp 5fe746f kio/tests/jobguitest.cpp 5a6c950 kio/tests/jobremotetest.cpp 5759b21 kio/tests/jobtest.cpp ceaf605 kio/tests/kdirmodeltest.cpp 8059fa8 kio/tests/netaccesstest.cpp 174feb0 staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c staging/kunitconversion/src/kunitconversion/currency.cpp 8d18f633 Diff: http://git.reviewboard.kde.org/r/111841/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 111841: Prefer job-exec() to synchronousRun
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/111841/ --- (Updated Aug. 1, 2013, 5:52 p.m.) Review request for KDE Frameworks. Description --- Ports all uses of NetAccess::synchronousRun to KJob::exec() but one in khtml, but there it should be re-thought, the change is not straight-forward (XmlHttpRequest). Diffs - kfile/kdirselectdialog.cpp 68c4b93 kfile/kfilewidget.cpp 2fa1d28 kio/kio/paste.cpp c7c43e1 kio/tests/fileundomanagertest.cpp 5fe746f kio/tests/jobguitest.cpp 5a6c950 kio/tests/jobremotetest.cpp 5759b21 kio/tests/jobtest.cpp ceaf605 kio/tests/kdirmodeltest.cpp 8059fa8 kio/tests/netaccesstest.cpp 174feb0 staging/kiconthemes/autotests/kiconloader_unittest.cpp 116203c staging/kunitconversion/src/kunitconversion/currency.cpp 8d18f633 Diff: http://git.reviewboard.kde.org/r/111841/diff/ Testing --- Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
