Re: Review Request 112684: Don't inspect XEvent queue in KUserTimestamp::updateUserTimestamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112684/ --- (Updated Sept. 13, 2013, 1:42 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, David Faure and Aurélien Gâteau. Description --- updateUserTimestamp() used to fetch the current time by creating a property notify event and wait till it is received by inspecting the XEvent queue. That doesn't work with XCB anymore, but Qt provides this functionality for us, so just use that. At the same time the argument is changed from int to unsigned long as that's what the method in QX11Info returns. Diffs - staging/kinterprocesswindowing/src/kusertimestamp.h 004def5 staging/kinterprocesswindowing/src/kusertimestamp.cpp 950579f Diff: http://git.reviewboard.kde.org/r/112684/diff/ Testing --- compiles. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112684: Don't inspect XEvent queue in KUserTimestamp::updateUserTimestamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112684/#review39967 --- This review has been submitted with commit 0be299aa017f717926fc0f342fc13d217c2a5353 by Martin Gräßlin to branch frameworks. - Commit Hook On Sept. 12, 2013, 1:30 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112684/ > --- > > (Updated Sept. 12, 2013, 1:30 p.m.) > > > Review request for KDE Frameworks, David Faure and Aurélien Gâteau. > > > Description > --- > > updateUserTimestamp() used to fetch the current time by creating a property > notify event and wait till it is received by inspecting the XEvent queue. > That doesn't work with XCB anymore, but Qt provides this functionality for > us, so just use that. > > At the same time the argument is changed from int to unsigned long as that's > what the method in QX11Info returns. > > > Diffs > - > > staging/kinterprocesswindowing/src/kusertimestamp.h 004def5 > staging/kinterprocesswindowing/src/kusertimestamp.cpp 950579f > > Diff: http://git.reviewboard.kde.org/r/112684/diff/ > > > Testing > --- > > compiles. > > > Thanks, > > Martin Gräßlin > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112684: Don't inspect XEvent queue in KUserTimestamp::updateUserTimestamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112684/#review39940 --- Ship it! Much simpler indeed - David Faure On Sept. 12, 2013, 1:30 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112684/ > --- > > (Updated Sept. 12, 2013, 1:30 p.m.) > > > Review request for KDE Frameworks, David Faure and Aurélien Gâteau. > > > Description > --- > > updateUserTimestamp() used to fetch the current time by creating a property > notify event and wait till it is received by inspecting the XEvent queue. > That doesn't work with XCB anymore, but Qt provides this functionality for > us, so just use that. > > At the same time the argument is changed from int to unsigned long as that's > what the method in QX11Info returns. > > > Diffs > - > > staging/kinterprocesswindowing/src/kusertimestamp.h 004def5 > staging/kinterprocesswindowing/src/kusertimestamp.cpp 950579f > > Diff: http://git.reviewboard.kde.org/r/112684/diff/ > > > Testing > --- > > compiles. > > > Thanks, > > Martin Gräßlin > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112684: Don't inspect XEvent queue in KUserTimestamp::updateUserTimestamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112684/#review39882 --- Looks good to me, but I don't feel qualified to press the "Ship It" button. - Aurélien Gâteau On Sept. 12, 2013, 3:30 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/112684/ > --- > > (Updated Sept. 12, 2013, 3:30 p.m.) > > > Review request for KDE Frameworks, David Faure and Aurélien Gâteau. > > > Description > --- > > updateUserTimestamp() used to fetch the current time by creating a property > notify event and wait till it is received by inspecting the XEvent queue. > That doesn't work with XCB anymore, but Qt provides this functionality for > us, so just use that. > > At the same time the argument is changed from int to unsigned long as that's > what the method in QX11Info returns. > > > Diffs > - > > staging/kinterprocesswindowing/src/kusertimestamp.h 004def5 > staging/kinterprocesswindowing/src/kusertimestamp.cpp 950579f > > Diff: http://git.reviewboard.kde.org/r/112684/diff/ > > > Testing > --- > > compiles. > > > Thanks, > > Martin Gräßlin > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 112684: Don't inspect XEvent queue in KUserTimestamp::updateUserTimestamp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112684/ --- Review request for KDE Frameworks, David Faure and Aurélien Gâteau. Description --- updateUserTimestamp() used to fetch the current time by creating a property notify event and wait till it is received by inspecting the XEvent queue. That doesn't work with XCB anymore, but Qt provides this functionality for us, so just use that. At the same time the argument is changed from int to unsigned long as that's what the method in QX11Info returns. Diffs - staging/kinterprocesswindowing/src/kusertimestamp.h 004def5 staging/kinterprocesswindowing/src/kusertimestamp.cpp 950579f Diff: http://git.reviewboard.kde.org/r/112684/diff/ Testing --- compiles. Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
