Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/#review39936 --- See the docu inside kdelibs-frameworks/superbuild/CMakeLists.txt. This is preparation for future splitting. The variables are necessary for that, for now, as I understand it. Let's finish moving everything into separate frameworks, then we can finally split up kdelibs and stop having to care for two ways to build stuff :) - David Faure On Sept. 12, 2013, 5 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/ --- (Updated Sept. 12, 2013, 5 p.m.) Review request for Build System, KDE Frameworks and Stephen Kelly. Description --- move add_subdirectory(tier2) right after add_subdirectory(tier1). Make it compile again. It's good because this simplifies some doubts we've been having lately. Also it didn't do much down there, only right after setting the _LIBRARY variables. In any case, everything in kdelibs/CMakeLists.txt under tier2 will have to go and move within each module, so it makes sense to start going in this direction. Diffs - CMakeLists.txt 17f1b46 tier2/kauth/autotests/CMakeLists.txt ff0feb0 tier2/kauth/src/CMakeLists.txt 31f0f9c tier2/kcrash/src/CMakeLists.txt f340acd Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/ --- (Updated Sept. 13, 2013, 10:33 a.m.) Review request for Build System, KDE Frameworks, Alexander Neundorf, and Stephen Kelly. Changes --- add neundorf Description --- move add_subdirectory(tier2) right after add_subdirectory(tier1). Make it compile again. It's good because this simplifies some doubts we've been having lately. Also it didn't do much down there, only right after setting the _LIBRARY variables. In any case, everything in kdelibs/CMakeLists.txt under tier2 will have to go and move within each module, so it makes sense to start going in this direction. Diffs - CMakeLists.txt 17f1b46 tier2/kauth/autotests/CMakeLists.txt ff0feb0 tier2/kauth/src/CMakeLists.txt 31f0f9c tier2/kcrash/src/CMakeLists.txt f340acd Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions
On Sept. 13, 2013, 7:35 a.m., David Faure wrote: See the docu inside kdelibs-frameworks/superbuild/CMakeLists.txt. This is preparation for future splitting. The variables are necessary for that, for now, as I understand it. Let's finish moving everything into separate frameworks, then we can finally split up kdelibs and stop having to care for two ways to build stuff :) Well, then it shouldn't matter, because it makes the modules less inter-dependent. At the moment we're relying too much about things defined in kdelibs/CMakeLists.txt and we're having things defined in weird ways, IMHO. - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/#review39936 --- On Sept. 13, 2013, 10:33 a.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/ --- (Updated Sept. 13, 2013, 10:33 a.m.) Review request for Build System, KDE Frameworks, Alexander Neundorf, and Stephen Kelly. Description --- move add_subdirectory(tier2) right after add_subdirectory(tier1). Make it compile again. It's good because this simplifies some doubts we've been having lately. Also it didn't do much down there, only right after setting the _LIBRARY variables. In any case, everything in kdelibs/CMakeLists.txt under tier2 will have to go and move within each module, so it makes sense to start going in this direction. Diffs - CMakeLists.txt 17f1b46 tier2/kauth/autotests/CMakeLists.txt ff0feb0 tier2/kauth/src/CMakeLists.txt 31f0f9c tier2/kcrash/src/CMakeLists.txt f340acd Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/ --- (Updated Sept. 13, 2013, 3:33 p.m.) Status -- This change has been discarded. Review request for Build System, KDE Frameworks, Alexander Neundorf, and Stephen Kelly. Description --- move add_subdirectory(tier2) right after add_subdirectory(tier1). Make it compile again. It's good because this simplifies some doubts we've been having lately. Also it didn't do much down there, only right after setting the _LIBRARY variables. In any case, everything in kdelibs/CMakeLists.txt under tier2 will have to go and move within each module, so it makes sense to start going in this direction. Diffs - CMakeLists.txt 17f1b46 tier2/kauth/autotests/CMakeLists.txt ff0feb0 tier2/kauth/src/CMakeLists.txt 31f0f9c tier2/kcrash/src/CMakeLists.txt f340acd Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/ --- Review request for Build System, KDE Frameworks and Stephen Kelly. Description --- move add_subdirectory(tier2) right after add_subdirectory(tier1). Make it compile again. It's good because this simplifies some doubts we've been having lately. Also it didn't do much down there, only right after setting the _LIBRARY variables. In any case, everything in kdelibs/CMakeLists.txt under tier2 will have to go and move within each module, so it makes sense to start going in this direction. Diffs - CMakeLists.txt 17f1b46 tier2/kauth/autotests/CMakeLists.txt ff0feb0 tier2/kauth/src/CMakeLists.txt 31f0f9c tier2/kcrash/src/CMakeLists.txt f340acd Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/#review39918 --- Would this break the superbuild stuff Alex was working on? - Stephen Kelly On Sept. 12, 2013, 5 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/ --- (Updated Sept. 12, 2013, 5 p.m.) Review request for Build System, KDE Frameworks and Stephen Kelly. Description --- move add_subdirectory(tier2) right after add_subdirectory(tier1). Make it compile again. It's good because this simplifies some doubts we've been having lately. Also it didn't do much down there, only right after setting the _LIBRARY variables. In any case, everything in kdelibs/CMakeLists.txt under tier2 will have to go and move within each module, so it makes sense to start going in this direction. Diffs - CMakeLists.txt 17f1b46 tier2/kauth/autotests/CMakeLists.txt ff0feb0 tier2/kauth/src/CMakeLists.txt 31f0f9c tier2/kcrash/src/CMakeLists.txt f340acd Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 112697: Make sure that tier1 and tier2 are built with the same definitions
On Sept. 12, 2013, 8:04 p.m., Stephen Kelly wrote: Would this break the superbuild stuff Alex was working on? I have no idea, I hope not... Where can I learn more about it? - Aleix --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/#review39918 --- On Sept. 12, 2013, 5 p.m., Aleix Pol Gonzalez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/112697/ --- (Updated Sept. 12, 2013, 5 p.m.) Review request for Build System, KDE Frameworks and Stephen Kelly. Description --- move add_subdirectory(tier2) right after add_subdirectory(tier1). Make it compile again. It's good because this simplifies some doubts we've been having lately. Also it didn't do much down there, only right after setting the _LIBRARY variables. In any case, everything in kdelibs/CMakeLists.txt under tier2 will have to go and move within each module, so it makes sense to start going in this direction. Diffs - CMakeLists.txt 17f1b46 tier2/kauth/autotests/CMakeLists.txt ff0feb0 tier2/kauth/src/CMakeLists.txt 31f0f9c tier2/kcrash/src/CMakeLists.txt f340acd Diff: http://git.reviewboard.kde.org/r/112697/diff/ Testing --- Still builds. Thanks, Aleix Pol Gonzalez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
