Re: Review Request 113480: Move KnotifyConfig to tier 3

2013-10-29 Thread Kevin Ottens

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113480/#review42586
---

Ship it!


Ship It!

- Kevin Ottens


On Oct. 28, 2013, 2:21 p.m., David Edmundson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113480/
 ---
 
 (Updated Oct. 28, 2013, 2:21 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 Move KnotifyConfig to tier 3
 
 
 Diffs
 -
 
   staging/CMakeLists.txt 8444b4c 
   staging/knotifyconfig/CMakeLists.txt  
   staging/knotifyconfig/KNotifyConfigConfig.cmake.in  
   staging/knotifyconfig/src/CMakeLists.txt  
   staging/knotifyconfig/src/knotify-config.h.cmake  
   staging/knotifyconfig/src/knotifyconfigactionswidget.h  
   staging/knotifyconfig/src/knotifyconfigactionswidget.cpp  
   staging/knotifyconfig/src/knotifyconfigactionswidgetbase.ui  
   staging/knotifyconfig/src/knotifyconfigelement.h  
   staging/knotifyconfig/src/knotifyconfigelement.cpp  
   staging/knotifyconfig/src/knotifyconfigwidget.h  
   staging/knotifyconfig/src/knotifyconfigwidget.cpp  
   staging/knotifyconfig/src/knotifyeventlist.h  
   staging/knotifyconfig/src/knotifyeventlist.cpp  
   staging/knotifyconfig/tests/CMakeLists.txt  
   staging/knotifyconfig/tests/knotifytest.notifyrc  
   staging/knotifyconfig/tests/knotifytestui.rc  
   staging/knotifyconfig/tests/knotifytestview.ui  
   staging/knotifyconfig/tests/knotifytestwindow.h  
   staging/knotifyconfig/tests/knotifytestwindow.cpp  
   staging/knotifyconfig/tests/main.cpp  
   tier3/CMakeLists.txt 2ad3f61 
 
 Diff: http://git.reviewboard.kde.org/r/113480/diff/
 
 
 Testing
 ---
 
 Went through checklist.
 Builds.
 
 
 Thanks,
 
 David Edmundson
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 113480: Move KnotifyConfig to tier 3

2013-10-29 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113480/
---

(Updated Oct. 29, 2013, 9:44 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Move KnotifyConfig to tier 3


Diffs
-

  staging/CMakeLists.txt 8444b4c 
  staging/knotifyconfig/CMakeLists.txt  
  staging/knotifyconfig/KNotifyConfigConfig.cmake.in  
  staging/knotifyconfig/src/CMakeLists.txt  
  staging/knotifyconfig/src/knotify-config.h.cmake  
  staging/knotifyconfig/src/knotifyconfigactionswidget.h  
  staging/knotifyconfig/src/knotifyconfigactionswidget.cpp  
  staging/knotifyconfig/src/knotifyconfigactionswidgetbase.ui  
  staging/knotifyconfig/src/knotifyconfigelement.h  
  staging/knotifyconfig/src/knotifyconfigelement.cpp  
  staging/knotifyconfig/src/knotifyconfigwidget.h  
  staging/knotifyconfig/src/knotifyconfigwidget.cpp  
  staging/knotifyconfig/src/knotifyeventlist.h  
  staging/knotifyconfig/src/knotifyeventlist.cpp  
  staging/knotifyconfig/tests/CMakeLists.txt  
  staging/knotifyconfig/tests/knotifytest.notifyrc  
  staging/knotifyconfig/tests/knotifytestui.rc  
  staging/knotifyconfig/tests/knotifytestview.ui  
  staging/knotifyconfig/tests/knotifytestwindow.h  
  staging/knotifyconfig/tests/knotifytestwindow.cpp  
  staging/knotifyconfig/tests/main.cpp  
  tier3/CMakeLists.txt 2ad3f61 

Diff: http://git.reviewboard.kde.org/r/113480/diff/


Testing
---

Went through checklist.
Builds.


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 113480: Move KnotifyConfig to tier 3

2013-10-29 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113480/#review42602
---


This review has been submitted with commit 
0689af56dca6b57c580e51f8ef6a9aa3f1fcda98 by David Edmundson to branch 
frameworks.

- Commit Hook


On Oct. 28, 2013, 2:21 p.m., David Edmundson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 http://git.reviewboard.kde.org/r/113480/
 ---
 
 (Updated Oct. 28, 2013, 2:21 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kdelibs
 
 
 Description
 ---
 
 Move KnotifyConfig to tier 3
 
 
 Diffs
 -
 
   staging/CMakeLists.txt 8444b4c 
   staging/knotifyconfig/CMakeLists.txt  
   staging/knotifyconfig/KNotifyConfigConfig.cmake.in  
   staging/knotifyconfig/src/CMakeLists.txt  
   staging/knotifyconfig/src/knotify-config.h.cmake  
   staging/knotifyconfig/src/knotifyconfigactionswidget.h  
   staging/knotifyconfig/src/knotifyconfigactionswidget.cpp  
   staging/knotifyconfig/src/knotifyconfigactionswidgetbase.ui  
   staging/knotifyconfig/src/knotifyconfigelement.h  
   staging/knotifyconfig/src/knotifyconfigelement.cpp  
   staging/knotifyconfig/src/knotifyconfigwidget.h  
   staging/knotifyconfig/src/knotifyconfigwidget.cpp  
   staging/knotifyconfig/src/knotifyeventlist.h  
   staging/knotifyconfig/src/knotifyeventlist.cpp  
   staging/knotifyconfig/tests/CMakeLists.txt  
   staging/knotifyconfig/tests/knotifytest.notifyrc  
   staging/knotifyconfig/tests/knotifytestui.rc  
   staging/knotifyconfig/tests/knotifytestview.ui  
   staging/knotifyconfig/tests/knotifytestwindow.h  
   staging/knotifyconfig/tests/knotifytestwindow.cpp  
   staging/knotifyconfig/tests/main.cpp  
   tier3/CMakeLists.txt 2ad3f61 
 
 Diff: http://git.reviewboard.kde.org/r/113480/diff/
 
 
 Testing
 ---
 
 Went through checklist.
 Builds.
 
 
 Thanks,
 
 David Edmundson
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 113480: Move KnotifyConfig to tier 3

2013-10-28 Thread David Edmundson

---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113480/
---

Review request for KDE Frameworks.


Repository: kdelibs


Description
---

Move KnotifyConfig to tier 3


Diffs
-

  staging/CMakeLists.txt 8444b4c 
  staging/knotifyconfig/CMakeLists.txt  
  staging/knotifyconfig/KNotifyConfigConfig.cmake.in  
  staging/knotifyconfig/src/CMakeLists.txt  
  staging/knotifyconfig/src/knotify-config.h.cmake  
  staging/knotifyconfig/src/knotifyconfigactionswidget.h  
  staging/knotifyconfig/src/knotifyconfigactionswidget.cpp  
  staging/knotifyconfig/src/knotifyconfigactionswidgetbase.ui  
  staging/knotifyconfig/src/knotifyconfigelement.h  
  staging/knotifyconfig/src/knotifyconfigelement.cpp  
  staging/knotifyconfig/src/knotifyconfigwidget.h  
  staging/knotifyconfig/src/knotifyconfigwidget.cpp  
  staging/knotifyconfig/src/knotifyeventlist.h  
  staging/knotifyconfig/src/knotifyeventlist.cpp  
  staging/knotifyconfig/tests/CMakeLists.txt  
  staging/knotifyconfig/tests/knotifytest.notifyrc  
  staging/knotifyconfig/tests/knotifytestui.rc  
  staging/knotifyconfig/tests/knotifytestview.ui  
  staging/knotifyconfig/tests/knotifytestwindow.h  
  staging/knotifyconfig/tests/knotifytestwindow.cpp  
  staging/knotifyconfig/tests/main.cpp  
  tier3/CMakeLists.txt 2ad3f61 

Diff: http://git.reviewboard.kde.org/r/113480/diff/


Testing
---

Went through checklist.
Builds.


Thanks,

David Edmundson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel