Re: Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/#review43362 --- Ship it! Ship It! - Kevin Ottens On Nov. 8, 2013, 12:12 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/ --- (Updated Nov. 8, 2013, 12:12 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Add popup for window with SkipTaskbar set in kpassivepopuptest KPassivePopup should place this next to the window itself. Diffs - tier2/knotifications/tests/kpassivepopuptest.cpp 266842aa336793248663a15e19d4ba22c32ee412 tier2/knotifications/tests/kpassivepopuptest.h c9620b975295be6d59b974824d1cb4e08c860f6f tier2/knotifications/tests/CMakeLists.txt ce87f1752856dcc0b37ef86fb3bfdbdaf4ef5685 tier2/knotifications/src/CMakeLists.txt cf312e028c323521504bd9ccd4c8f3f817e13497 tier2/knotifications/CMakeLists.txt 6df0022536436477cc9cd875e0bccd70e78d32d3 Diff: http://git.reviewboard.kde.org/r/113712/diff/ Testing --- Builds, runs, new test does the right thing. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/#review43372 --- This review has been submitted with commit 7ce144ac99c3f8024314162d2fa2cd428c7328a9 by Alex Merry to branch frameworks. - Commit Hook On Nov. 8, 2013, 12:12 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/ --- (Updated Nov. 8, 2013, 12:12 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Add popup for window with SkipTaskbar set in kpassivepopuptest KPassivePopup should place this next to the window itself. Diffs - tier2/knotifications/tests/kpassivepopuptest.cpp 266842aa336793248663a15e19d4ba22c32ee412 tier2/knotifications/tests/kpassivepopuptest.h c9620b975295be6d59b974824d1cb4e08c860f6f tier2/knotifications/tests/CMakeLists.txt ce87f1752856dcc0b37ef86fb3bfdbdaf4ef5685 tier2/knotifications/src/CMakeLists.txt cf312e028c323521504bd9ccd4c8f3f817e13497 tier2/knotifications/CMakeLists.txt 6df0022536436477cc9cd875e0bccd70e78d32d3 Diff: http://git.reviewboard.kde.org/r/113712/diff/ Testing --- Builds, runs, new test does the right thing. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/ --- (Updated Nov. 10, 2013, 5:23 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Add popup for window with SkipTaskbar set in kpassivepopuptest KPassivePopup should place this next to the window itself. Diffs - tier2/knotifications/tests/kpassivepopuptest.cpp 266842aa336793248663a15e19d4ba22c32ee412 tier2/knotifications/tests/kpassivepopuptest.h c9620b975295be6d59b974824d1cb4e08c860f6f tier2/knotifications/tests/CMakeLists.txt ce87f1752856dcc0b37ef86fb3bfdbdaf4ef5685 tier2/knotifications/src/CMakeLists.txt cf312e028c323521504bd9ccd4c8f3f817e13497 tier2/knotifications/CMakeLists.txt 6df0022536436477cc9cd875e0bccd70e78d32d3 Diff: http://git.reviewboard.kde.org/r/113712/diff/ Testing --- Builds, runs, new test does the right thing. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest
On Nov. 8, 2013, 5:38 a.m., Martin Gräßlin wrote: tier2/knotifications/tests/CMakeLists.txt, line 22 http://git.reviewboard.kde.org/r/113712/diff/1/?file=211813#file211813line22 do you need to link XLib? From the code changes you did it looks like you don't use any XLib call at all. Oh, yes, you're right. I just copied the link arguments from the knotifications library. - Alex --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/#review43247 --- On Nov. 7, 2013, 7:03 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/ --- (Updated Nov. 7, 2013, 7:03 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Add popup for window with SkipTaskbar set in kpassivepopuptest KPassivePopup should place this next to the window itself. Diffs - tier2/knotifications/tests/kpassivepopuptest.cpp 266842aa336793248663a15e19d4ba22c32ee412 tier2/knotifications/tests/kpassivepopuptest.h c9620b975295be6d59b974824d1cb4e08c860f6f tier2/knotifications/tests/CMakeLists.txt ce87f1752856dcc0b37ef86fb3bfdbdaf4ef5685 tier2/knotifications/src/CMakeLists.txt cf312e028c323521504bd9ccd4c8f3f817e13497 tier2/knotifications/CMakeLists.txt 6df0022536436477cc9cd875e0bccd70e78d32d3 Diff: http://git.reviewboard.kde.org/r/113712/diff/ Testing --- Builds, runs, new test does the right thing. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/ --- (Updated Nov. 8, 2013, 12:12 p.m.) Review request for KDE Frameworks. Changes --- Remove X11 libs from target_link_libraries. Repository: kdelibs Description --- Add popup for window with SkipTaskbar set in kpassivepopuptest KPassivePopup should place this next to the window itself. Diffs (updated) - tier2/knotifications/tests/kpassivepopuptest.cpp 266842aa336793248663a15e19d4ba22c32ee412 tier2/knotifications/tests/kpassivepopuptest.h c9620b975295be6d59b974824d1cb4e08c860f6f tier2/knotifications/tests/CMakeLists.txt ce87f1752856dcc0b37ef86fb3bfdbdaf4ef5685 tier2/knotifications/src/CMakeLists.txt cf312e028c323521504bd9ccd4c8f3f817e13497 tier2/knotifications/CMakeLists.txt 6df0022536436477cc9cd875e0bccd70e78d32d3 Diff: http://git.reviewboard.kde.org/r/113712/diff/ Testing --- Builds, runs, new test does the right thing. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Add popup for window with SkipTaskbar set in kpassivepopuptest KPassivePopup should place this next to the window itself. Diffs - tier2/knotifications/tests/kpassivepopuptest.cpp 266842aa336793248663a15e19d4ba22c32ee412 tier2/knotifications/tests/kpassivepopuptest.h c9620b975295be6d59b974824d1cb4e08c860f6f tier2/knotifications/tests/CMakeLists.txt ce87f1752856dcc0b37ef86fb3bfdbdaf4ef5685 tier2/knotifications/src/CMakeLists.txt cf312e028c323521504bd9ccd4c8f3f817e13497 tier2/knotifications/CMakeLists.txt 6df0022536436477cc9cd875e0bccd70e78d32d3 Diff: http://git.reviewboard.kde.org/r/113712/diff/ Testing --- Builds, runs, new test does the right thing. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113712: Add popup for window with SkipTaskbar set in kpassivepopuptest
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/#review43247 --- tier2/knotifications/tests/CMakeLists.txt http://git.reviewboard.kde.org/r/113712/#comment31165 do you need to link XLib? From the code changes you did it looks like you don't use any XLib call at all. - Martin Gräßlin On Nov. 7, 2013, 8:03 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113712/ --- (Updated Nov. 7, 2013, 8:03 p.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Add popup for window with SkipTaskbar set in kpassivepopuptest KPassivePopup should place this next to the window itself. Diffs - tier2/knotifications/tests/kpassivepopuptest.cpp 266842aa336793248663a15e19d4ba22c32ee412 tier2/knotifications/tests/kpassivepopuptest.h c9620b975295be6d59b974824d1cb4e08c860f6f tier2/knotifications/tests/CMakeLists.txt ce87f1752856dcc0b37ef86fb3bfdbdaf4ef5685 tier2/knotifications/src/CMakeLists.txt cf312e028c323521504bd9ccd4c8f3f817e13497 tier2/knotifications/CMakeLists.txt 6df0022536436477cc9cd875e0bccd70e78d32d3 Diff: http://git.reviewboard.kde.org/r/113712/diff/ Testing --- Builds, runs, new test does the right thing. Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
