Re: Review Request 113792: Fix Build of KDNSSD with DNSSD Backend
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113792/#review43628 --- Ship it! Ship It! - Kevin Ottens On Nov. 11, 2013, 1:32 a.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113792/ --- (Updated Nov. 11, 2013, 1:32 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adjusting the code to changes in Qt5. The nature of the changes makes me wonder if this code is maintained at all or if the DNSSD backend should be dropped. Diffs - tier2/dnssd/src/mdnsd-servicebrowser.cpp 37449db tier2/dnssd/src/mdnsd-publicservice.cpp 5da6f97 tier2/dnssd/src/mdnsd-domainbrowser.cpp 21c359e tier2/dnssd/src/CMakeLists.txt c71ade2 tier2/dnssd/CMakeLists.txt 13497d1 Diff: http://git.reviewboard.kde.org/r/113792/diff/ Testing --- 1. Configure KDNSSD with -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 2. Build Builds successfully. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113792: Fix Build of KDNSSD with DNSSD Backend
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113792/#review43639 --- This review has been submitted with commit f79e0f903e0d3aee44c23c1d64b297fb6d31 by David E. Narvaez to branch frameworks. - Commit Hook On Nov. 11, 2013, 1:32 a.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113792/ --- (Updated Nov. 11, 2013, 1:32 a.m.) Review request for KDE Frameworks. Repository: kdelibs Description --- Adjusting the code to changes in Qt5. The nature of the changes makes me wonder if this code is maintained at all or if the DNSSD backend should be dropped. Diffs - tier2/dnssd/src/mdnsd-servicebrowser.cpp 37449db tier2/dnssd/src/mdnsd-publicservice.cpp 5da6f97 tier2/dnssd/src/mdnsd-domainbrowser.cpp 21c359e tier2/dnssd/src/CMakeLists.txt c71ade2 tier2/dnssd/CMakeLists.txt 13497d1 Diff: http://git.reviewboard.kde.org/r/113792/diff/ Testing --- 1. Configure KDNSSD with -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 2. Build Builds successfully. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 113792: Fix Build of KDNSSD with DNSSD Backend
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113792/ --- (Updated Nov. 13, 2013, 10:26 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kdelibs Description --- Adjusting the code to changes in Qt5. The nature of the changes makes me wonder if this code is maintained at all or if the DNSSD backend should be dropped. Diffs - tier2/dnssd/src/mdnsd-servicebrowser.cpp 37449db tier2/dnssd/src/mdnsd-publicservice.cpp 5da6f97 tier2/dnssd/src/mdnsd-domainbrowser.cpp 21c359e tier2/dnssd/src/CMakeLists.txt c71ade2 tier2/dnssd/CMakeLists.txt 13497d1 Diff: http://git.reviewboard.kde.org/r/113792/diff/ Testing --- 1. Configure KDNSSD with -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 2. Build Builds successfully. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 113792: Fix Build of KDNSSD with DNSSD Backend
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113792/ --- Review request for KDE Frameworks. Repository: kdelibs Description --- Adjusting the code to changes in Qt5. The nature of the changes makes me wonder if this code is maintained at all or if the DNSSD backend should be dropped. Diffs - tier2/dnssd/src/mdnsd-servicebrowser.cpp 37449db tier2/dnssd/src/mdnsd-publicservice.cpp 5da6f97 tier2/dnssd/src/mdnsd-domainbrowser.cpp 21c359e tier2/dnssd/src/CMakeLists.txt c71ade2 tier2/dnssd/CMakeLists.txt 13497d1 Diff: http://git.reviewboard.kde.org/r/113792/diff/ Testing --- 1. Configure KDNSSD with -DCMAKE_DISABLE_FIND_PACKAGE_Avahi=1 2. Build Builds successfully. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
