Re: Review Request 115005: Install forwarding headers for plain knewstuff3 headers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115005/#review47371 --- Ship it! Ship It! - David Faure On Jan. 13, 2014, 11:39 p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115005/ --- (Updated Jan. 13, 2014, 11:39 p.m.) Review request for KDE Frameworks, David Faure and Jeremy Whiting. Repository: kde4support Description --- To be seen combined with https://git.reviewboard.kde.org/r/114988/ Installation prefix was changed from knewtuff3/ to kns3/ Also remove no longer needed CamelCase forwarding headers, because they are installed again with the old prefix from the KNewStuff module See also discussion http://lists.kde.org/?l=kde-frameworks-develm=138963692808275w=2 Diffs - src/CMakeLists.txt 241e0c6 src/includes/CMakeLists.txt 8781a9a src/includes/KNS3/DownloadDialog dd7ef3a src/includes/KNS3/Entry cb98675 src/includes/KNS3/KNewStuffAction 48936eb src/includes/KNS3/KNewStuffButton aa033e1 src/knewstuff3/downloaddialog.h PRE-CREATION src/knewstuff3/downloadmanager.h PRE-CREATION src/knewstuff3/downloadwidget.h PRE-CREATION src/knewstuff3/entry.h PRE-CREATION src/knewstuff3/knewstuffaction.h PRE-CREATION src/knewstuff3/knewstuffbutton.h PRE-CREATION src/knewstuff3/uploaddialog.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115005/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115005: Install forwarding headers for plain knewstuff3 headers
On Jan. 14, 2014, 3:30 p.m., David Faure wrote: Ship It! Thanks. To avoid misunderstandings, is that a Ship it for both RRs? Or for now just this? Both depend on each other, otherwise will break things :) (so will have to commit quickly after each other) - Friedrich W. H. --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115005/#review47371 --- On Jan. 13, 2014, 11:39 p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115005/ --- (Updated Jan. 13, 2014, 11:39 p.m.) Review request for KDE Frameworks, David Faure and Jeremy Whiting. Repository: kde4support Description --- To be seen combined with https://git.reviewboard.kde.org/r/114988/ Installation prefix was changed from knewtuff3/ to kns3/ Also remove no longer needed CamelCase forwarding headers, because they are installed again with the old prefix from the KNewStuff module See also discussion http://lists.kde.org/?l=kde-frameworks-develm=138963692808275w=2 Diffs - src/CMakeLists.txt 241e0c6 src/includes/CMakeLists.txt 8781a9a src/includes/KNS3/DownloadDialog dd7ef3a src/includes/KNS3/Entry cb98675 src/includes/KNS3/KNewStuffAction 48936eb src/includes/KNS3/KNewStuffButton aa033e1 src/knewstuff3/downloaddialog.h PRE-CREATION src/knewstuff3/downloadmanager.h PRE-CREATION src/knewstuff3/downloadwidget.h PRE-CREATION src/knewstuff3/entry.h PRE-CREATION src/knewstuff3/knewstuffaction.h PRE-CREATION src/knewstuff3/knewstuffbutton.h PRE-CREATION src/knewstuff3/uploaddialog.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115005/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115005: Install forwarding headers for plain knewstuff3 headers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115005/ --- (Updated Jan. 14, 2014, 6:01 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks, David Faure and Jeremy Whiting. Repository: kde4support Description --- To be seen combined with https://git.reviewboard.kde.org/r/114988/ Installation prefix was changed from knewtuff3/ to kns3/ Also remove no longer needed CamelCase forwarding headers, because they are installed again with the old prefix from the KNewStuff module See also discussion http://lists.kde.org/?l=kde-frameworks-develm=138963692808275w=2 Diffs - src/CMakeLists.txt 241e0c6 src/includes/CMakeLists.txt 8781a9a src/includes/KNS3/DownloadDialog dd7ef3a src/includes/KNS3/Entry cb98675 src/includes/KNS3/KNewStuffAction 48936eb src/includes/KNS3/KNewStuffButton aa033e1 src/knewstuff3/downloaddialog.h PRE-CREATION src/knewstuff3/downloadmanager.h PRE-CREATION src/knewstuff3/downloadwidget.h PRE-CREATION src/knewstuff3/entry.h PRE-CREATION src/knewstuff3/knewstuffaction.h PRE-CREATION src/knewstuff3/knewstuffbutton.h PRE-CREATION src/knewstuff3/uploaddialog.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115005/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115005: Install forwarding headers for plain knewstuff3 headers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115005/#review47387 --- This review has been submitted with commit 978c6f45ab90c9c68cadfa52c514879004a8e212 by Friedrich W. H. Kossebau to branch master. - Commit Hook On Jan. 13, 2014, 11:39 p.m., Friedrich W. H. Kossebau wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115005/ --- (Updated Jan. 13, 2014, 11:39 p.m.) Review request for KDE Frameworks, David Faure and Jeremy Whiting. Repository: kde4support Description --- To be seen combined with https://git.reviewboard.kde.org/r/114988/ Installation prefix was changed from knewtuff3/ to kns3/ Also remove no longer needed CamelCase forwarding headers, because they are installed again with the old prefix from the KNewStuff module See also discussion http://lists.kde.org/?l=kde-frameworks-develm=138963692808275w=2 Diffs - src/CMakeLists.txt 241e0c6 src/includes/CMakeLists.txt 8781a9a src/includes/KNS3/DownloadDialog dd7ef3a src/includes/KNS3/Entry cb98675 src/includes/KNS3/KNewStuffAction 48936eb src/includes/KNS3/KNewStuffButton aa033e1 src/knewstuff3/downloaddialog.h PRE-CREATION src/knewstuff3/downloadmanager.h PRE-CREATION src/knewstuff3/downloadwidget.h PRE-CREATION src/knewstuff3/entry.h PRE-CREATION src/knewstuff3/knewstuffaction.h PRE-CREATION src/knewstuff3/knewstuffbutton.h PRE-CREATION src/knewstuff3/uploaddialog.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115005/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115005: Install forwarding headers for plain knewstuff3 headers
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115005/ --- Review request for KDE Frameworks, David Faure and Jeremy Whiting. Repository: kde4support Description --- To be seen combined with https://git.reviewboard.kde.org/r/114988/ Installation prefix was changed from knewtuff3/ to kns3/ Also remove no longer needed CamelCase forwarding headers, because they are installed again with the old prefix from the KNewStuff module See also discussion http://lists.kde.org/?l=kde-frameworks-develm=138963692808275w=2 Diffs - src/CMakeLists.txt 241e0c6 src/includes/CMakeLists.txt 8781a9a src/includes/KNS3/DownloadDialog dd7ef3a src/includes/KNS3/Entry cb98675 src/includes/KNS3/KNewStuffAction 48936eb src/includes/KNS3/KNewStuffButton aa033e1 src/knewstuff3/downloaddialog.h PRE-CREATION src/knewstuff3/downloadmanager.h PRE-CREATION src/knewstuff3/downloadwidget.h PRE-CREATION src/knewstuff3/entry.h PRE-CREATION src/knewstuff3/knewstuffaction.h PRE-CREATION src/knewstuff3/knewstuffbutton.h PRE-CREATION src/knewstuff3/uploaddialog.h PRE-CREATION Diff: https://git.reviewboard.kde.org/r/115005/diff/ Testing --- Thanks, Friedrich W. H. Kossebau ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
