Re: Review Request 115132: Append 5 to preparetips script manpage

2014-01-21 Thread Alex Merry

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115132/#review47951
---

Ship it!


Seems sensible to me.

- Alex Merry


On Jan. 19, 2014, 10:34 p.m., Hrvoje Senjan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115132/
 ---
 
 (Updated Jan. 19, 2014, 10:34 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kconfigwidgets
 
 
 Description
 ---
 
 Patch to make kconfigwidgets not collide with kdelibs(4) when installed to 
 same prefix.
 I can cleanup whitespaces if needed (they where present in original script). 
 Also, depending on the outcome of r115065, can change kdeoptions man 
 reference.
 
 
 Diffs
 -
 
   docs/preparetips/CMakeLists.txt 4685089 
   docs/preparetips/man-preparetips.1.docbook baf4b6b 
   docs/preparetips/man-preparetips5.1.docbook PRE-CREATION 
   src/CMakeLists.txt baf5295 
   src/ktipdialog.cpp 1b74f55 
   src/preparetips a89d9f1 
   src/preparetips5 PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/115132/diff/
 
 
 Testing
 ---
 
 Builds :)
 
 
 Thanks,
 
 Hrvoje Senjan
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115132: Append 5 to preparetips script manpage

2014-01-21 Thread Hrvoje Senjan

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115132/
---

(Updated Jan. 21, 2014, 11:36 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kconfigwidgets


Description
---

Patch to make kconfigwidgets not collide with kdelibs(4) when installed to same 
prefix.
I can cleanup whitespaces if needed (they where present in original script). 
Also, depending on the outcome of r115065, can change kdeoptions man reference.


Diffs
-

  docs/preparetips/CMakeLists.txt 4685089 
  docs/preparetips/man-preparetips.1.docbook baf4b6b 
  docs/preparetips/man-preparetips5.1.docbook PRE-CREATION 
  src/CMakeLists.txt baf5295 
  src/ktipdialog.cpp 1b74f55 
  src/preparetips a89d9f1 
  src/preparetips5 PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115132/diff/


Testing
---

Builds :)


Thanks,

Hrvoje Senjan

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115132: Append 5 to preparetips script manpage

2014-01-21 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115132/#review47961
---


This review has been submitted with commit 
1ea6262185916ae453db15d325bdad0e27b1e0b3 by Hrvoje Senjan to branch master.

- Commit Hook


On Jan. 19, 2014, 10:34 p.m., Hrvoje Senjan wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115132/
 ---
 
 (Updated Jan. 19, 2014, 10:34 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kconfigwidgets
 
 
 Description
 ---
 
 Patch to make kconfigwidgets not collide with kdelibs(4) when installed to 
 same prefix.
 I can cleanup whitespaces if needed (they where present in original script). 
 Also, depending on the outcome of r115065, can change kdeoptions man 
 reference.
 
 
 Diffs
 -
 
   docs/preparetips/CMakeLists.txt 4685089 
   docs/preparetips/man-preparetips.1.docbook baf4b6b 
   docs/preparetips/man-preparetips5.1.docbook PRE-CREATION 
   src/CMakeLists.txt baf5295 
   src/ktipdialog.cpp 1b74f55 
   src/preparetips a89d9f1 
   src/preparetips5 PRE-CREATION 
 
 Diff: https://git.reviewboard.kde.org/r/115132/diff/
 
 
 Testing
 ---
 
 Builds :)
 
 
 Thanks,
 
 Hrvoje Senjan
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 115132: Append 5 to preparetips script manpage

2014-01-19 Thread Hrvoje Senjan

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115132/
---

Review request for KDE Frameworks.


Repository: kconfigwidgets


Description
---

Patch to make kconfigwidgets not collide with kdelibs(4) when installed to same 
prefix.
I can cleanup whitespaces if needed (they where present in original script). 
Also, depending on the outcome of r115065, can change kdeoptions man reference.


Diffs
-

  docs/preparetips/CMakeLists.txt 4685089 
  docs/preparetips/man-preparetips.1.docbook baf4b6b 
  docs/preparetips/man-preparetips5.1.docbook PRE-CREATION 
  src/CMakeLists.txt baf5295 
  src/ktipdialog.cpp 1b74f55 
  src/preparetips a89d9f1 
  src/preparetips5 PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/115132/diff/


Testing
---

Builds :)


Thanks,

Hrvoje Senjan

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel