Re: Review Request 115141: Add a . at the end of command line option descriptions
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115141/#review47986 --- Ship it! Ship It! - David Faure On Jan. 20, 2014, 10:39 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115141/ --- (Updated Jan. 20, 2014, 10:39 a.m.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- Add a . at the end of command line option descriptions According to the QCommandLineOptions docs, this is customary, so this should make the help for these arguments match the ones Qt provides (like --help and --version), as well as application-provided ones. Diffs - src/lib/kaboutdata.cpp f24006b41524e501dc5e402e784425e99aff9ad2 Diff: https://git.reviewboard.kde.org/r/115141/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115141: Add a . at the end of command line option descriptions
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115141/#review47990 --- This review has been submitted with commit 295193cf8f6cc0d005d5498d6fc236eac2ef4487 by Alex Merry to branch master. - Commit Hook On Jan. 20, 2014, 10:39 a.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115141/ --- (Updated Jan. 20, 2014, 10:39 a.m.) Review request for KDE Frameworks. Repository: kcoreaddons Description --- Add a . at the end of command line option descriptions According to the QCommandLineOptions docs, this is customary, so this should make the help for these arguments match the ones Qt provides (like --help and --version), as well as application-provided ones. Diffs - src/lib/kaboutdata.cpp f24006b41524e501dc5e402e784425e99aff9ad2 Diff: https://git.reviewboard.kde.org/r/115141/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115141: Add a . at the end of command line option descriptions
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115141/ --- (Updated Jan. 22, 2014, 10:23 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kcoreaddons Description --- Add a . at the end of command line option descriptions According to the QCommandLineOptions docs, this is customary, so this should make the help for these arguments match the ones Qt provides (like --help and --version), as well as application-provided ones. Diffs - src/lib/kaboutdata.cpp f24006b41524e501dc5e402e784425e99aff9ad2 Diff: https://git.reviewboard.kde.org/r/115141/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115141: Add a . at the end of command line option descriptions
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115141/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description --- Add a . at the end of command line option descriptions According to the QCommandLineOptions docs, this is customary, so this should make the help for these arguments match the ones Qt provides (like --help and --version), as well as application-provided ones. Diffs - src/lib/kaboutdata.cpp f24006b41524e501dc5e402e784425e99aff9ad2 Diff: https://git.reviewboard.kde.org/r/115141/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
