Re: Review Request 115164: Keep tests together
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/#review48264 --- This review has been submitted with commit 3d69de1b9fe6055b727ee5ff8dd93f49aee8d096 by Michael Palimaka to branch master. - Commit Hook On Jan. 22, 2014, 3:57 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/ --- (Updated Jan. 22, 2014, 3:57 p.m.) Review request for KDE Frameworks and Valentin Rusu. Repository: kio Description --- There are two sets of sets in the middle of the source tree, away from the usual autotests/. This moves them so that they are all together. (I don't know why git didn't recognise certain files as just being moved in the diff) Diffs - src/ioslaves/http/kcookiejar/tests/cookie_rfc.test src/ioslaves/http/kcookiejar/tests/cookie_saving.test src/ioslaves/http/kcookiejar/tests/cookie_session.test src/ioslaves/http/kcookiejar/tests/cookie_settings.test src/ioslaves/http/kcookiejar/tests/kcookiejartest.cpp src/ioslaves/http/tests/CMakeLists.txt src/ioslaves/http/tests/httpauthenticationtest.h src/ioslaves/http/tests/httpauthenticationtest.cpp src/ioslaves/http/tests/httpfiltertest.cpp src/ioslaves/http/tests/httpheaderdispositiontest.h src/ioslaves/http/tests/httpheaderdispositiontest.cpp src/ioslaves/http/tests/httpheadertokenizetest.h src/ioslaves/http/tests/httpheadertokenizetest.cpp src/ioslaves/http/tests/httpobjecttest.h src/ioslaves/http/tests/httpobjecttest.cpp autotests/CMakeLists.txt 5655d45efcfd9455e1745a2ec93e2da30a9b83b2 autotests/http/CMakeLists.txt PRE-CREATION autotests/http/httpfiltertest.cpp PRE-CREATION autotests/http/tests/httpauthenticationtest.h PRE-CREATION autotests/http/tests/httpauthenticationtest.cpp PRE-CREATION autotests/http/tests/httpheaderdispositiontest.h PRE-CREATION autotests/http/tests/httpheaderdispositiontest.cpp PRE-CREATION autotests/http/tests/httpheadertokenizetest.h PRE-CREATION autotests/http/tests/httpheadertokenizetest.cpp PRE-CREATION autotests/http/tests/httpobjecttest.h PRE-CREATION autotests/http/tests/httpobjecttest.cpp PRE-CREATION autotests/kcookiejar/kcookiejartest.cpp PRE-CREATION autotests/kcookiejar/tests/CMakeLists.txt PRE-CREATION autotests/kcookiejar/tests/cookie.test PRE-CREATION autotests/kcookiejar/tests/cookie_rfc.test PRE-CREATION autotests/kcookiejar/tests/cookie_saving.test PRE-CREATION autotests/kcookiejar/tests/cookie_session.test PRE-CREATION autotests/kcookiejar/tests/cookie_settings.test PRE-CREATION src/ioslaves/http/CMakeLists.txt 39fd42f62bd583f92f655739a97a02b09c61 src/ioslaves/http/kcookiejar/CMakeLists.txt 54b1fe0b818f63cd76ac79d5233a3c00da866950 src/ioslaves/http/kcookiejar/tests/CMakeLists.txt src/ioslaves/http/kcookiejar/tests/cookie.test Diff: https://git.reviewboard.kde.org/r/115164/diff/ Testing --- Builds, affected tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115164: Keep tests together
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/ --- (Updated Jan. 25, 2014, 3:44 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Valentin Rusu. Repository: kio Description --- There are two sets of sets in the middle of the source tree, away from the usual autotests/. This moves them so that they are all together. (I don't know why git didn't recognise certain files as just being moved in the diff) Diffs - src/ioslaves/http/kcookiejar/tests/cookie_rfc.test src/ioslaves/http/kcookiejar/tests/cookie_saving.test src/ioslaves/http/kcookiejar/tests/cookie_session.test src/ioslaves/http/kcookiejar/tests/cookie_settings.test src/ioslaves/http/kcookiejar/tests/kcookiejartest.cpp src/ioslaves/http/tests/CMakeLists.txt src/ioslaves/http/tests/httpauthenticationtest.h src/ioslaves/http/tests/httpauthenticationtest.cpp src/ioslaves/http/tests/httpfiltertest.cpp src/ioslaves/http/tests/httpheaderdispositiontest.h src/ioslaves/http/tests/httpheaderdispositiontest.cpp src/ioslaves/http/tests/httpheadertokenizetest.h src/ioslaves/http/tests/httpheadertokenizetest.cpp src/ioslaves/http/tests/httpobjecttest.h src/ioslaves/http/tests/httpobjecttest.cpp autotests/CMakeLists.txt 5655d45efcfd9455e1745a2ec93e2da30a9b83b2 autotests/http/CMakeLists.txt PRE-CREATION autotests/http/httpfiltertest.cpp PRE-CREATION autotests/http/tests/httpauthenticationtest.h PRE-CREATION autotests/http/tests/httpauthenticationtest.cpp PRE-CREATION autotests/http/tests/httpheaderdispositiontest.h PRE-CREATION autotests/http/tests/httpheaderdispositiontest.cpp PRE-CREATION autotests/http/tests/httpheadertokenizetest.h PRE-CREATION autotests/http/tests/httpheadertokenizetest.cpp PRE-CREATION autotests/http/tests/httpobjecttest.h PRE-CREATION autotests/http/tests/httpobjecttest.cpp PRE-CREATION autotests/kcookiejar/kcookiejartest.cpp PRE-CREATION autotests/kcookiejar/tests/CMakeLists.txt PRE-CREATION autotests/kcookiejar/tests/cookie.test PRE-CREATION autotests/kcookiejar/tests/cookie_rfc.test PRE-CREATION autotests/kcookiejar/tests/cookie_saving.test PRE-CREATION autotests/kcookiejar/tests/cookie_session.test PRE-CREATION autotests/kcookiejar/tests/cookie_settings.test PRE-CREATION src/ioslaves/http/CMakeLists.txt 39fd42f62bd583f92f655739a97a02b09c61 src/ioslaves/http/kcookiejar/CMakeLists.txt 54b1fe0b818f63cd76ac79d5233a3c00da866950 src/ioslaves/http/kcookiejar/tests/CMakeLists.txt src/ioslaves/http/kcookiejar/tests/cookie.test Diff: https://git.reviewboard.kde.org/r/115164/diff/ Testing --- Builds, affected tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115164: Keep tests together
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/#review48267 --- Please note that I also committed b0d4f3a86a46da4aed1812e9e8bda5bed5d8aa59 to fix a build failure this introduced when using GSSAPI. It just moves find_package(GSSAPI) to the root CMakeLists.txt - Michael Palimaka On Jan. 25, 2014, 3:44 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/ --- (Updated Jan. 25, 2014, 3:44 p.m.) Review request for KDE Frameworks and Valentin Rusu. Repository: kio Description --- There are two sets of sets in the middle of the source tree, away from the usual autotests/. This moves them so that they are all together. (I don't know why git didn't recognise certain files as just being moved in the diff) Diffs - src/ioslaves/http/kcookiejar/tests/cookie_rfc.test src/ioslaves/http/kcookiejar/tests/cookie_saving.test src/ioslaves/http/kcookiejar/tests/cookie_session.test src/ioslaves/http/kcookiejar/tests/cookie_settings.test src/ioslaves/http/kcookiejar/tests/kcookiejartest.cpp src/ioslaves/http/tests/CMakeLists.txt src/ioslaves/http/tests/httpauthenticationtest.h src/ioslaves/http/tests/httpauthenticationtest.cpp src/ioslaves/http/tests/httpfiltertest.cpp src/ioslaves/http/tests/httpheaderdispositiontest.h src/ioslaves/http/tests/httpheaderdispositiontest.cpp src/ioslaves/http/tests/httpheadertokenizetest.h src/ioslaves/http/tests/httpheadertokenizetest.cpp src/ioslaves/http/tests/httpobjecttest.h src/ioslaves/http/tests/httpobjecttest.cpp autotests/CMakeLists.txt 5655d45efcfd9455e1745a2ec93e2da30a9b83b2 autotests/http/CMakeLists.txt PRE-CREATION autotests/http/httpfiltertest.cpp PRE-CREATION autotests/http/tests/httpauthenticationtest.h PRE-CREATION autotests/http/tests/httpauthenticationtest.cpp PRE-CREATION autotests/http/tests/httpheaderdispositiontest.h PRE-CREATION autotests/http/tests/httpheaderdispositiontest.cpp PRE-CREATION autotests/http/tests/httpheadertokenizetest.h PRE-CREATION autotests/http/tests/httpheadertokenizetest.cpp PRE-CREATION autotests/http/tests/httpobjecttest.h PRE-CREATION autotests/http/tests/httpobjecttest.cpp PRE-CREATION autotests/kcookiejar/kcookiejartest.cpp PRE-CREATION autotests/kcookiejar/tests/CMakeLists.txt PRE-CREATION autotests/kcookiejar/tests/cookie.test PRE-CREATION autotests/kcookiejar/tests/cookie_rfc.test PRE-CREATION autotests/kcookiejar/tests/cookie_saving.test PRE-CREATION autotests/kcookiejar/tests/cookie_session.test PRE-CREATION autotests/kcookiejar/tests/cookie_settings.test PRE-CREATION src/ioslaves/http/CMakeLists.txt 39fd42f62bd583f92f655739a97a02b09c61 src/ioslaves/http/kcookiejar/CMakeLists.txt 54b1fe0b818f63cd76ac79d5233a3c00da866950 src/ioslaves/http/kcookiejar/tests/CMakeLists.txt src/ioslaves/http/kcookiejar/tests/cookie.test Diff: https://git.reviewboard.kde.org/r/115164/diff/ Testing --- Builds, affected tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115164: Keep tests together
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/#review48248 --- Ship it! Looks good to me. - Valentin Rusu On Jan. 22, 2014, 3:57 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/ --- (Updated Jan. 22, 2014, 3:57 p.m.) Review request for KDE Frameworks and Valentin Rusu. Repository: kio Description --- There are two sets of sets in the middle of the source tree, away from the usual autotests/. This moves them so that they are all together. (I don't know why git didn't recognise certain files as just being moved in the diff) Diffs - src/ioslaves/http/kcookiejar/tests/cookie_rfc.test src/ioslaves/http/kcookiejar/tests/cookie_saving.test src/ioslaves/http/kcookiejar/tests/cookie_session.test src/ioslaves/http/kcookiejar/tests/cookie_settings.test src/ioslaves/http/kcookiejar/tests/kcookiejartest.cpp src/ioslaves/http/tests/CMakeLists.txt src/ioslaves/http/tests/httpauthenticationtest.h src/ioslaves/http/tests/httpauthenticationtest.cpp src/ioslaves/http/tests/httpfiltertest.cpp src/ioslaves/http/tests/httpheaderdispositiontest.h src/ioslaves/http/tests/httpheaderdispositiontest.cpp src/ioslaves/http/tests/httpheadertokenizetest.h src/ioslaves/http/tests/httpheadertokenizetest.cpp src/ioslaves/http/tests/httpobjecttest.h src/ioslaves/http/tests/httpobjecttest.cpp autotests/CMakeLists.txt 5655d45efcfd9455e1745a2ec93e2da30a9b83b2 autotests/http/CMakeLists.txt PRE-CREATION autotests/http/httpfiltertest.cpp PRE-CREATION autotests/http/tests/httpauthenticationtest.h PRE-CREATION autotests/http/tests/httpauthenticationtest.cpp PRE-CREATION autotests/http/tests/httpheaderdispositiontest.h PRE-CREATION autotests/http/tests/httpheaderdispositiontest.cpp PRE-CREATION autotests/http/tests/httpheadertokenizetest.h PRE-CREATION autotests/http/tests/httpheadertokenizetest.cpp PRE-CREATION autotests/http/tests/httpobjecttest.h PRE-CREATION autotests/http/tests/httpobjecttest.cpp PRE-CREATION autotests/kcookiejar/kcookiejartest.cpp PRE-CREATION autotests/kcookiejar/tests/CMakeLists.txt PRE-CREATION autotests/kcookiejar/tests/cookie.test PRE-CREATION autotests/kcookiejar/tests/cookie_rfc.test PRE-CREATION autotests/kcookiejar/tests/cookie_saving.test PRE-CREATION autotests/kcookiejar/tests/cookie_session.test PRE-CREATION autotests/kcookiejar/tests/cookie_settings.test PRE-CREATION src/ioslaves/http/CMakeLists.txt 39fd42f62bd583f92f655739a97a02b09c61 src/ioslaves/http/kcookiejar/CMakeLists.txt 54b1fe0b818f63cd76ac79d5233a3c00da866950 src/ioslaves/http/kcookiejar/tests/CMakeLists.txt src/ioslaves/http/kcookiejar/tests/cookie.test Diff: https://git.reviewboard.kde.org/r/115164/diff/ Testing --- Builds, affected tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115164: Keep tests together
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/ --- (Updated Jan. 22, 2014, 3:57 p.m.) Review request for KDE Frameworks and Valentin Rusu. Changes --- Add vrusu as reviewer. Repository: kio Description --- There are two sets of sets in the middle of the source tree, away from the usual autotests/. This moves them so that they are all together. (I don't know why git didn't recognise certain files as just being moved in the diff) Diffs - src/ioslaves/http/kcookiejar/tests/cookie_rfc.test src/ioslaves/http/kcookiejar/tests/cookie_saving.test src/ioslaves/http/kcookiejar/tests/cookie_session.test src/ioslaves/http/kcookiejar/tests/cookie_settings.test src/ioslaves/http/kcookiejar/tests/kcookiejartest.cpp src/ioslaves/http/tests/CMakeLists.txt src/ioslaves/http/tests/httpauthenticationtest.h src/ioslaves/http/tests/httpauthenticationtest.cpp src/ioslaves/http/tests/httpfiltertest.cpp src/ioslaves/http/tests/httpheaderdispositiontest.h src/ioslaves/http/tests/httpheaderdispositiontest.cpp src/ioslaves/http/tests/httpheadertokenizetest.h src/ioslaves/http/tests/httpheadertokenizetest.cpp src/ioslaves/http/tests/httpobjecttest.h src/ioslaves/http/tests/httpobjecttest.cpp autotests/CMakeLists.txt 5655d45efcfd9455e1745a2ec93e2da30a9b83b2 autotests/http/CMakeLists.txt PRE-CREATION autotests/http/httpfiltertest.cpp PRE-CREATION autotests/http/tests/httpauthenticationtest.h PRE-CREATION autotests/http/tests/httpauthenticationtest.cpp PRE-CREATION autotests/http/tests/httpheaderdispositiontest.h PRE-CREATION autotests/http/tests/httpheaderdispositiontest.cpp PRE-CREATION autotests/http/tests/httpheadertokenizetest.h PRE-CREATION autotests/http/tests/httpheadertokenizetest.cpp PRE-CREATION autotests/http/tests/httpobjecttest.h PRE-CREATION autotests/http/tests/httpobjecttest.cpp PRE-CREATION autotests/kcookiejar/kcookiejartest.cpp PRE-CREATION autotests/kcookiejar/tests/CMakeLists.txt PRE-CREATION autotests/kcookiejar/tests/cookie.test PRE-CREATION autotests/kcookiejar/tests/cookie_rfc.test PRE-CREATION autotests/kcookiejar/tests/cookie_saving.test PRE-CREATION autotests/kcookiejar/tests/cookie_session.test PRE-CREATION autotests/kcookiejar/tests/cookie_settings.test PRE-CREATION src/ioslaves/http/CMakeLists.txt 39fd42f62bd583f92f655739a97a02b09c61 src/ioslaves/http/kcookiejar/CMakeLists.txt 54b1fe0b818f63cd76ac79d5233a3c00da866950 src/ioslaves/http/kcookiejar/tests/CMakeLists.txt src/ioslaves/http/kcookiejar/tests/cookie.test Diff: https://git.reviewboard.kde.org/r/115164/diff/ Testing --- Builds, affected tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115164: Keep tests together
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/ --- Review request for KDE Frameworks. Repository: kio Description --- There are two sets of sets in the middle of the source tree, away from the usual autotests/. This moves them so that they are all together. (I don't know why git didn't recognise certain files as just being moved in the diff) Diffs - src/ioslaves/http/kcookiejar/tests/cookie_rfc.test src/ioslaves/http/kcookiejar/tests/cookie_saving.test src/ioslaves/http/kcookiejar/tests/cookie_session.test src/ioslaves/http/kcookiejar/tests/cookie_settings.test src/ioslaves/http/kcookiejar/tests/kcookiejartest.cpp src/ioslaves/http/tests/CMakeLists.txt src/ioslaves/http/tests/httpauthenticationtest.h src/ioslaves/http/tests/httpauthenticationtest.cpp src/ioslaves/http/tests/httpfiltertest.cpp src/ioslaves/http/tests/httpheaderdispositiontest.h src/ioslaves/http/tests/httpheaderdispositiontest.cpp src/ioslaves/http/tests/httpheadertokenizetest.h src/ioslaves/http/tests/httpheadertokenizetest.cpp src/ioslaves/http/tests/httpobjecttest.h src/ioslaves/http/tests/httpobjecttest.cpp autotests/CMakeLists.txt 5655d45efcfd9455e1745a2ec93e2da30a9b83b2 autotests/http/CMakeLists.txt PRE-CREATION autotests/http/httpfiltertest.cpp PRE-CREATION autotests/http/tests/httpauthenticationtest.h PRE-CREATION autotests/http/tests/httpauthenticationtest.cpp PRE-CREATION autotests/http/tests/httpheaderdispositiontest.h PRE-CREATION autotests/http/tests/httpheaderdispositiontest.cpp PRE-CREATION autotests/http/tests/httpheadertokenizetest.h PRE-CREATION autotests/http/tests/httpheadertokenizetest.cpp PRE-CREATION autotests/http/tests/httpobjecttest.h PRE-CREATION autotests/http/tests/httpobjecttest.cpp PRE-CREATION autotests/kcookiejar/kcookiejartest.cpp PRE-CREATION autotests/kcookiejar/tests/CMakeLists.txt PRE-CREATION autotests/kcookiejar/tests/cookie.test PRE-CREATION autotests/kcookiejar/tests/cookie_rfc.test PRE-CREATION autotests/kcookiejar/tests/cookie_saving.test PRE-CREATION autotests/kcookiejar/tests/cookie_session.test PRE-CREATION autotests/kcookiejar/tests/cookie_settings.test PRE-CREATION src/ioslaves/http/CMakeLists.txt 39fd42f62bd583f92f655739a97a02b09c61 src/ioslaves/http/kcookiejar/CMakeLists.txt 54b1fe0b818f63cd76ac79d5233a3c00da866950 src/ioslaves/http/kcookiejar/tests/CMakeLists.txt src/ioslaves/http/kcookiejar/tests/cookie.test Diff: https://git.reviewboard.kde.org/r/115164/diff/ Testing --- Builds, affected tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115164: Keep tests together
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/#review47953 --- Seems sensible to me, but I would add Valentin Rusu to the review. - Alex Merry On Jan. 21, 2014, 10:38 a.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115164/ --- (Updated Jan. 21, 2014, 10:38 a.m.) Review request for KDE Frameworks. Repository: kio Description --- There are two sets of sets in the middle of the source tree, away from the usual autotests/. This moves them so that they are all together. (I don't know why git didn't recognise certain files as just being moved in the diff) Diffs - src/ioslaves/http/kcookiejar/tests/cookie_rfc.test src/ioslaves/http/kcookiejar/tests/cookie_saving.test src/ioslaves/http/kcookiejar/tests/cookie_session.test src/ioslaves/http/kcookiejar/tests/cookie_settings.test src/ioslaves/http/kcookiejar/tests/kcookiejartest.cpp src/ioslaves/http/tests/CMakeLists.txt src/ioslaves/http/tests/httpauthenticationtest.h src/ioslaves/http/tests/httpauthenticationtest.cpp src/ioslaves/http/tests/httpfiltertest.cpp src/ioslaves/http/tests/httpheaderdispositiontest.h src/ioslaves/http/tests/httpheaderdispositiontest.cpp src/ioslaves/http/tests/httpheadertokenizetest.h src/ioslaves/http/tests/httpheadertokenizetest.cpp src/ioslaves/http/tests/httpobjecttest.h src/ioslaves/http/tests/httpobjecttest.cpp autotests/CMakeLists.txt 5655d45efcfd9455e1745a2ec93e2da30a9b83b2 autotests/http/CMakeLists.txt PRE-CREATION autotests/http/httpfiltertest.cpp PRE-CREATION autotests/http/tests/httpauthenticationtest.h PRE-CREATION autotests/http/tests/httpauthenticationtest.cpp PRE-CREATION autotests/http/tests/httpheaderdispositiontest.h PRE-CREATION autotests/http/tests/httpheaderdispositiontest.cpp PRE-CREATION autotests/http/tests/httpheadertokenizetest.h PRE-CREATION autotests/http/tests/httpheadertokenizetest.cpp PRE-CREATION autotests/http/tests/httpobjecttest.h PRE-CREATION autotests/http/tests/httpobjecttest.cpp PRE-CREATION autotests/kcookiejar/kcookiejartest.cpp PRE-CREATION autotests/kcookiejar/tests/CMakeLists.txt PRE-CREATION autotests/kcookiejar/tests/cookie.test PRE-CREATION autotests/kcookiejar/tests/cookie_rfc.test PRE-CREATION autotests/kcookiejar/tests/cookie_saving.test PRE-CREATION autotests/kcookiejar/tests/cookie_session.test PRE-CREATION autotests/kcookiejar/tests/cookie_settings.test PRE-CREATION src/ioslaves/http/CMakeLists.txt 39fd42f62bd583f92f655739a97a02b09c61 src/ioslaves/http/kcookiejar/CMakeLists.txt 54b1fe0b818f63cd76ac79d5233a3c00da866950 src/ioslaves/http/kcookiejar/tests/CMakeLists.txt src/ioslaves/http/kcookiejar/tests/cookie.test Diff: https://git.reviewboard.kde.org/r/115164/diff/ Testing --- Builds, affected tests pass. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
