Re: Review Request 115237: Relocate KDE4_CREATE_HANDBOOK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115237/ --- (Updated Jan. 23, 2014, 4:22 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Luigi Toscano. Repository: kde4support Description --- Moving it from KDocTools, as discussed in Review Request 115077. Defined as a forward to the new command KDOCTOOLS_CREATE_HANDBOOK. Notice that the description of the command changed to document the actual name of the target created. Diffs - cmake/modules/KDE4Macros.cmake a3894ae Diff: https://git.reviewboard.kde.org/r/115237/diff/ Testing --- Tried using this on a Kig build for frameworks. The warning message is displayed and the doc-handbook target is created for folder doc. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115237: Relocate KDE4_CREATE_HANDBOOK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115237/#review48142 --- This review has been submitted with commit c4b6190709eaaf7d5c1100d74ba0f73a1033b990 by David E. Narvaez to branch master. - Commit Hook On Jan. 22, 2014, 9:28 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115237/ --- (Updated Jan. 22, 2014, 9:28 p.m.) Review request for KDE Frameworks and Luigi Toscano. Repository: kde4support Description --- Moving it from KDocTools, as discussed in Review Request 115077. Defined as a forward to the new command KDOCTOOLS_CREATE_HANDBOOK. Notice that the description of the command changed to document the actual name of the target created. Diffs - cmake/modules/KDE4Macros.cmake a3894ae Diff: https://git.reviewboard.kde.org/r/115237/diff/ Testing --- Tried using this on a Kig build for frameworks. The warning message is displayed and the doc-handbook target is created for folder doc. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115237: Relocate KDE4_CREATE_HANDBOOK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115237/ --- Review request for KDE Frameworks and Luigi Toscano. Repository: kde4support Description --- Moving it from KDocTools. Defined as a forward to the new command KDOCTOOLS_CREATE_HANDBOOK. Notice that the description of the command changed to document the actual name of the target created. Diffs - cmake/modules/KDE4Macros.cmake a3894ae Diff: https://git.reviewboard.kde.org/r/115237/diff/ Testing --- Tried using this on a Kig build for frameworks. The warning message is displayed and the doc-handbook target is created for folder doc. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115237: Relocate KDE4_CREATE_HANDBOOK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115237/ --- (Updated Jan. 22, 2014, 9:28 p.m.) Review request for KDE Frameworks and Luigi Toscano. Changes --- Pointing to the original discussion in the description. Repository: kde4support Description (updated) --- Moving it from KDocTools, as discussed in Review Request 115077. Defined as a forward to the new command KDOCTOOLS_CREATE_HANDBOOK. Notice that the description of the command changed to document the actual name of the target created. Diffs - cmake/modules/KDE4Macros.cmake a3894ae Diff: https://git.reviewboard.kde.org/r/115237/diff/ Testing --- Tried using this on a Kig build for frameworks. The warning message is displayed and the doc-handbook target is created for folder doc. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115237: Relocate KDE4_CREATE_HANDBOOK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115237/#review48082 --- Ship it! As I wrote in the original review request, fine with me (other opinions are welcome of course!) - Luigi Toscano On Jan. 22, 2014, 9:28 p.m., David Narváez wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115237/ --- (Updated Jan. 22, 2014, 9:28 p.m.) Review request for KDE Frameworks and Luigi Toscano. Repository: kde4support Description --- Moving it from KDocTools, as discussed in Review Request 115077. Defined as a forward to the new command KDOCTOOLS_CREATE_HANDBOOK. Notice that the description of the command changed to document the actual name of the target created. Diffs - cmake/modules/KDE4Macros.cmake a3894ae Diff: https://git.reviewboard.kde.org/r/115237/diff/ Testing --- Tried using this on a Kig build for frameworks. The warning message is displayed and the doc-handbook target is created for folder doc. Thanks, David Narváez ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
