Review Request 115617: Don't perform XLib calls if we are not on X11

2014-02-10 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115617/
---

Review request for KDE Frameworks.


Repository: kde4support


Description
---

Don't perform XLib calls if we are not on X11

Check whether we are on platform xcb and only perform XLib calls
if we are on this platform.

This makes KApplication based apps to start on Wayland.


Diffs
-

  src/kdeui/kapplication.cpp 9e8acabdabaf40c955e40f92da18f96165ec5355 

Diff: https://git.reviewboard.kde.org/r/115617/diff/


Testing
---

Konsole starts on Wayland.


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115617: Don't perform XLib calls if we are not on X11

2014-02-10 Thread Alexander Richardson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115617/#review49452
---

Ship it!


Ship It!

- Alexander Richardson


On Feb. 10, 2014, 10:17 a.m., Martin Gräßlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115617/
 ---
 
 (Updated Feb. 10, 2014, 10:17 a.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kde4support
 
 
 Description
 ---
 
 Don't perform XLib calls if we are not on X11
 
 Check whether we are on platform xcb and only perform XLib calls
 if we are on this platform.
 
 This makes KApplication based apps to start on Wayland.
 
 
 Diffs
 -
 
   src/kdeui/kapplication.cpp 9e8acabdabaf40c955e40f92da18f96165ec5355 
 
 Diff: https://git.reviewboard.kde.org/r/115617/diff/
 
 
 Testing
 ---
 
 Konsole starts on Wayland.
 
 
 Thanks,
 
 Martin Gräßlin
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115617: Don't perform XLib calls if we are not on X11

2014-02-10 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115617/#review49502
---


This review has been submitted with commit 
d0f36b22cbc510026b9b40ce27d174767c35c49f by Martin Gräßlin to branch master.

- Commit Hook


On Feb. 10, 2014, 9:17 a.m., Martin Gräßlin wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115617/
 ---
 
 (Updated Feb. 10, 2014, 9:17 a.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kde4support
 
 
 Description
 ---
 
 Don't perform XLib calls if we are not on X11
 
 Check whether we are on platform xcb and only perform XLib calls
 if we are on this platform.
 
 This makes KApplication based apps to start on Wayland.
 
 
 Diffs
 -
 
   src/kdeui/kapplication.cpp 9e8acabdabaf40c955e40f92da18f96165ec5355 
 
 Diff: https://git.reviewboard.kde.org/r/115617/diff/
 
 
 Testing
 ---
 
 Konsole starts on Wayland.
 
 
 Thanks,
 
 Martin Gräßlin
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115617: Don't perform XLib calls if we are not on X11

2014-02-10 Thread Martin Gräßlin

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115617/
---

(Updated Feb. 11, 2014, 6:39 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kde4support


Description
---

Don't perform XLib calls if we are not on X11

Check whether we are on platform xcb and only perform XLib calls
if we are on this platform.

This makes KApplication based apps to start on Wayland.


Diffs
-

  src/kdeui/kapplication.cpp 9e8acabdabaf40c955e40f92da18f96165ec5355 

Diff: https://git.reviewboard.kde.org/r/115617/diff/


Testing
---

Konsole starts on Wayland.


Thanks,

Martin Gräßlin

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel