Re: Review Request 115639: Ensure X11 specific code is only called on platform X11
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115639/ --- (Updated Feb. 12, 2014, 7:30 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kde4support Description --- Ensure X11 specific code is only called on platform X11 Global search for HAVE_X11 in kde4support and adjusted the dangerous parts. Diffs - src/kdeui/kcolordialog.cpp 36738fa668dfcbee1f4a2b60b2ceb44c45869c87 src/kdeui/kglobalsettings.cpp 7a1a98aef29a3754de60cff19455cfc37da3f728 src/kdeui/kmenubar.cpp a2d85618b4c1e891f51ca5154a040f5467818936 Diff: https://git.reviewboard.kde.org/r/115639/diff/ Testing --- compiles, kcolordlgtest does no longer crash on Wayland Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115639: Ensure X11 specific code is only called on platform X11
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115639/#review49627 --- This review has been submitted with commit 4346a1e86d6fd2754cd24d798747aca59b233c96 by Martin Gräßlin to branch master. - Commit Hook On Feb. 11, 2014, 7:12 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115639/ > --- > > (Updated Feb. 11, 2014, 7:12 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kde4support > > > Description > --- > > Ensure X11 specific code is only called on platform X11 > > Global search for HAVE_X11 in kde4support and adjusted the > dangerous parts. > > > Diffs > - > > src/kdeui/kcolordialog.cpp 36738fa668dfcbee1f4a2b60b2ceb44c45869c87 > src/kdeui/kglobalsettings.cpp 7a1a98aef29a3754de60cff19455cfc37da3f728 > src/kdeui/kmenubar.cpp a2d85618b4c1e891f51ca5154a040f5467818936 > > Diff: https://git.reviewboard.kde.org/r/115639/diff/ > > > Testing > --- > > compiles, kcolordlgtest does no longer crash on Wayland > > > Thanks, > > Martin Gräßlin > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 115639: Ensure X11 specific code is only called on platform X11
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115639/#review49601 --- Ship it! Ship It! - David Faure On Feb. 11, 2014, 7:12 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/115639/ > --- > > (Updated Feb. 11, 2014, 7:12 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kde4support > > > Description > --- > > Ensure X11 specific code is only called on platform X11 > > Global search for HAVE_X11 in kde4support and adjusted the > dangerous parts. > > > Diffs > - > > src/kdeui/kcolordialog.cpp 36738fa668dfcbee1f4a2b60b2ceb44c45869c87 > src/kdeui/kglobalsettings.cpp 7a1a98aef29a3754de60cff19455cfc37da3f728 > src/kdeui/kmenubar.cpp a2d85618b4c1e891f51ca5154a040f5467818936 > > Diff: https://git.reviewboard.kde.org/r/115639/diff/ > > > Testing > --- > > compiles, kcolordlgtest does no longer crash on Wayland > > > Thanks, > > Martin Gräßlin > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 115639: Ensure X11 specific code is only called on platform X11
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/115639/ --- Review request for KDE Frameworks. Repository: kde4support Description --- Ensure X11 specific code is only called on platform X11 Global search for HAVE_X11 in kde4support and adjusted the dangerous parts. Diffs - src/kdeui/kcolordialog.cpp 36738fa668dfcbee1f4a2b60b2ceb44c45869c87 src/kdeui/kglobalsettings.cpp 7a1a98aef29a3754de60cff19455cfc37da3f728 src/kdeui/kmenubar.cpp a2d85618b4c1e891f51ca5154a040f5467818936 Diff: https://git.reviewboard.kde.org/r/115639/diff/ Testing --- compiles, kcolordlgtest does no longer crash on Wayland Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
