Re: Review Request 115766: Use the new ecm_generate_headers() syntax

2014-02-16 Thread Alex Merry

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115766/
---

(Updated Feb. 16, 2014, 10:55 a.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and David Faure.


Repository: kparts


Description
---

Use the new ecm_generate_headers() syntax


Diffs
-

  src/CMakeLists.txt 3c1f8a498dbd5f8042bf704f555ded25533c65a5 

Diff: https://git.reviewboard.kde.org/r/115766/diff/


Testing
---

Removed `$PREFIX/include/KF5/KParts`, then did configure, build, install.  `ls 
-R $PREFIX/include/KF5/KParts` was the same as before removing the old version. 
 KMediaPlayer still builds afterwards.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115766: Use the new ecm_generate_headers() syntax

2014-02-16 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115766/#review49904
---


This review has been submitted with commit 
61a8b22e0f3ac8e32db159adbca3a433e415ee3b by Alex Merry to branch master.

- Commit Hook


On Feb. 15, 2014, 5:42 p.m., Alex Merry wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115766/
 ---
 
 (Updated Feb. 15, 2014, 5:42 p.m.)
 
 
 Review request for KDE Frameworks and David Faure.
 
 
 Repository: kparts
 
 
 Description
 ---
 
 Use the new ecm_generate_headers() syntax
 
 
 Diffs
 -
 
   src/CMakeLists.txt 3c1f8a498dbd5f8042bf704f555ded25533c65a5 
 
 Diff: https://git.reviewboard.kde.org/r/115766/diff/
 
 
 Testing
 ---
 
 Removed `$PREFIX/include/KF5/KParts`, then did configure, build, install.  
 `ls -R $PREFIX/include/KF5/KParts` was the same as before removing the old 
 version.  KMediaPlayer still builds afterwards.
 
 
 Thanks,
 
 Alex Merry
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 115766: Use the new ecm_generate_headers() syntax

2014-02-15 Thread Alex Merry

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115766/
---

Review request for KDE Frameworks and David Faure.


Repository: kparts


Description
---

Use the new ecm_generate_headers() syntax


Diffs
-

  src/CMakeLists.txt 3c1f8a498dbd5f8042bf704f555ded25533c65a5 

Diff: https://git.reviewboard.kde.org/r/115766/diff/


Testing
---

Removed `$PREFIX/include/KF5/KParts`, then did configure, build, install.  `ls 
-R $PREFIX/include/KF5/KParts` was the same as before removing the old version. 
 KMediaPlayer still builds afterwards.


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 115766: Use the new ecm_generate_headers() syntax

2014-02-15 Thread David Faure

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115766/#review49888
---

Ship it!


Ship It!

- David Faure


On Feb. 15, 2014, 5:42 p.m., Alex Merry wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/115766/
 ---
 
 (Updated Feb. 15, 2014, 5:42 p.m.)
 
 
 Review request for KDE Frameworks and David Faure.
 
 
 Repository: kparts
 
 
 Description
 ---
 
 Use the new ecm_generate_headers() syntax
 
 
 Diffs
 -
 
   src/CMakeLists.txt 3c1f8a498dbd5f8042bf704f555ded25533c65a5 
 
 Diff: https://git.reviewboard.kde.org/r/115766/diff/
 
 
 Testing
 ---
 
 Removed `$PREFIX/include/KF5/KParts`, then did configure, build, install.  
 `ls -R $PREFIX/include/KF5/KParts` was the same as before removing the old 
 version.  KMediaPlayer still builds afterwards.
 
 
 Thanks,
 
 Alex Merry
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel