Review Request 116729: Add a comment explaining the kde4 in the mime type
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116729/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- Add a comment explaining the kde4 in the mime type Matches one in src/lib/io/kurlmimedata.cpp in kcoreaddons. Diffs - src/lineediturldropeventfilter.cpp f7ea7629d108bfb7a42a7a98959cb54a4ac4fab0 Diff: https://git.reviewboard.kde.org/r/116729/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116729: Add a comment explaining the kde4 in the mime type
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116729/#review52671 --- Ship it! Would it make sense to support both kde and kde4 names (if that's even possible)? - Christoph Feck On March 11, 2014, 5 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116729/ --- (Updated March 11, 2014, 5 p.m.) Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- Add a comment explaining the kde4 in the mime type Matches one in src/lib/io/kurlmimedata.cpp in kcoreaddons. Diffs - src/lineediturldropeventfilter.cpp f7ea7629d108bfb7a42a7a98959cb54a4ac4fab0 Diff: https://git.reviewboard.kde.org/r/116729/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116729: Add a comment explaining the kde4 in the mime type
On March 11, 2014, 7:21 p.m., Christoph Feck wrote: Would it make sense to support both kde and kde4 names (if that's even possible)? It should be possible to support them, yes. I would suggest application/x-kio-urilist, though, since that property is really for KIO URIs. Of course, that means duplicating the mime data all the time; the question is whether it is worth it. - Alex --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116729/#review52671 --- On March 11, 2014, 5 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116729/ --- (Updated March 11, 2014, 5 p.m.) Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- Add a comment explaining the kde4 in the mime type Matches one in src/lib/io/kurlmimedata.cpp in kcoreaddons. Diffs - src/lineediturldropeventfilter.cpp f7ea7629d108bfb7a42a7a98959cb54a4ac4fab0 Diff: https://git.reviewboard.kde.org/r/116729/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116729: Add a comment explaining the kde4 in the mime type
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116729/#review52673 --- This review has been submitted with commit a148143b772333d71b338e56b0d030b737ab74a8 by Alex Merry to branch master. - Commit Hook On March 11, 2014, 5 p.m., Alex Merry wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116729/ --- (Updated March 11, 2014, 5 p.m.) Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- Add a comment explaining the kde4 in the mime type Matches one in src/lib/io/kurlmimedata.cpp in kcoreaddons. Diffs - src/lineediturldropeventfilter.cpp f7ea7629d108bfb7a42a7a98959cb54a4ac4fab0 Diff: https://git.reviewboard.kde.org/r/116729/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116729: Add a comment explaining the kde4 in the mime type
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116729/ --- (Updated March 11, 2014, 7:56 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks and Christoph Feck. Repository: kwidgetsaddons Description --- Add a comment explaining the kde4 in the mime type Matches one in src/lib/io/kurlmimedata.cpp in kcoreaddons. Diffs - src/lineediturldropeventfilter.cpp f7ea7629d108bfb7a42a7a98959cb54a4ac4fab0 Diff: https://git.reviewboard.kde.org/r/116729/diff/ Testing --- Thanks, Alex Merry ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
