Re: Review Request 116739: Update commented-out cmake code to new macros

2014-03-12 Thread Kevin Ottens

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116739/#review52797
---

Ship it!


Ship It!

- Kevin Ottens


On March 11, 2014, 7:42 p.m., Alex Merry wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/116739/
 ---
 
 (Updated March 11, 2014, 7:42 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: solid
 
 
 Description
 ---
 
 Update commented-out cmake code to new macros
 
 This test is also disabled in kdelibs4; it appears to use a non-existant
 mock D-Bus service.  At least this way the CMake code is ready to be
 re-enabled if and when the test is fixed up.
 
 
 Diffs
 -
 
   tests/CMakeLists.txt 59337085e005c9ad93f490e269dfcdcae8628d78 
 
 Diff: https://git.reviewboard.kde.org/r/116739/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Alex Merry
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 116739: Update commented-out cmake code to new macros

2014-03-12 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116739/#review52826
---


This review has been submitted with commit 
661971b0564dce58841019fce3fc1ed51984302d by Alex Merry to branch master.

- Commit Hook


On March 11, 2014, 7:42 p.m., Alex Merry wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/116739/
 ---
 
 (Updated March 11, 2014, 7:42 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: solid
 
 
 Description
 ---
 
 Update commented-out cmake code to new macros
 
 This test is also disabled in kdelibs4; it appears to use a non-existant
 mock D-Bus service.  At least this way the CMake code is ready to be
 re-enabled if and when the test is fixed up.
 
 
 Diffs
 -
 
   tests/CMakeLists.txt 59337085e005c9ad93f490e269dfcdcae8628d78 
 
 Diff: https://git.reviewboard.kde.org/r/116739/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Alex Merry
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 116739: Update commented-out cmake code to new macros

2014-03-11 Thread Alex Merry

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116739/
---

Review request for KDE Frameworks.


Repository: solid


Description
---

Update commented-out cmake code to new macros

This test is also disabled in kdelibs4; it appears to use a non-existant
mock D-Bus service.  At least this way the CMake code is ready to be
re-enabled if and when the test is fixed up.


Diffs
-

  tests/CMakeLists.txt 59337085e005c9ad93f490e269dfcdcae8628d78 

Diff: https://git.reviewboard.kde.org/r/116739/diff/


Testing
---


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel