Re: Review Request 116848: Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116848/#review54114 --- This review has been submitted with commit c04277a151710381a1b7451c07f5f58ecfabfe4d by Martin Gräßlin to branch master. - Commit Hook On March 19, 2014, 6:19 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116848/ --- (Updated March 19, 2014, 6:19 a.m.) Review request for KDE Frameworks. Repository: kwindowsystem Description --- Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal This signal replaces the existing signal carrying either just the NET::Properties as an uint or both as an const unsigned long*. Accordingly the previous signal gets deprecated, but is still emitted. Question: what's the correct way of deprecating signals, so that one gets a compile warning? Diffs - src/kwindowsystem.h e10f7c1cdd7b8c1fb1c6472c1f64a2ac71965534 src/kwindowsystem_x11.cpp 8a411008717b27ec8439f6ffebe0113fdad2fd45 Diff: https://git.reviewboard.kde.org/r/116848/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116848: Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116848/ --- (Updated March 25, 2014, 2:22 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kwindowsystem Description --- Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal This signal replaces the existing signal carrying either just the NET::Properties as an uint or both as an const unsigned long*. Accordingly the previous signal gets deprecated, but is still emitted. Question: what's the correct way of deprecating signals, so that one gets a compile warning? Diffs - src/kwindowsystem.h e10f7c1cdd7b8c1fb1c6472c1f64a2ac71965534 src/kwindowsystem_x11.cpp 8a411008717b27ec8439f6ffebe0113fdad2fd45 Diff: https://git.reviewboard.kde.org/r/116848/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116848: Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116848/#review54007 --- Ship it! Ship It! - Kevin Ottens On March 19, 2014, 6:19 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116848/ --- (Updated March 19, 2014, 6:19 a.m.) Review request for KDE Frameworks. Repository: kwindowsystem Description --- Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal This signal replaces the existing signal carrying either just the NET::Properties as an uint or both as an const unsigned long*. Accordingly the previous signal gets deprecated, but is still emitted. Question: what's the correct way of deprecating signals, so that one gets a compile warning? Diffs - src/kwindowsystem.h e10f7c1cdd7b8c1fb1c6472c1f64a2ac71965534 src/kwindowsystem_x11.cpp 8a411008717b27ec8439f6ffebe0113fdad2fd45 Diff: https://git.reviewboard.kde.org/r/116848/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116848: Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116848/ --- (Updated March 19, 2014, 7:19 a.m.) Review request for KDE Frameworks. Changes --- Added QT_MOC_COMPAT to deprecated signals Repository: kwindowsystem Description --- Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal This signal replaces the existing signal carrying either just the NET::Properties as an uint or both as an const unsigned long*. Accordingly the previous signal gets deprecated, but is still emitted. Question: what's the correct way of deprecating signals, so that one gets a compile warning? Diffs (updated) - src/kwindowsystem.h e10f7c1cdd7b8c1fb1c6472c1f64a2ac71965534 src/kwindowsystem_x11.cpp 8a411008717b27ec8439f6ffebe0113fdad2fd45 Diff: https://git.reviewboard.kde.org/r/116848/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116848: Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116848/#review53370 --- Prefixing the signal with QT_MOC_COMPAT should do the trick, at least that's what I found here: https://projects.kde.org/projects/kde/kdelibs/repository/revisions/abf90b0ca648c5f7f5c3d9040006e08817fc618d - Alexander Richardson On March 17, 2014, 10:46 a.m., Martin Gräßlin wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116848/ --- (Updated March 17, 2014, 10:46 a.m.) Review request for KDE Frameworks. Repository: kwindowsystem Description --- Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal This signal replaces the existing signal carrying either just the NET::Properties as an uint or both as an const unsigned long*. Accordingly the previous signal gets deprecated, but is still emitted. Question: what's the correct way of deprecating signals, so that one gets a compile warning? Diffs - src/kwindowsystem.h e10f7c1cdd7b8c1fb1c6472c1f64a2ac71965534 src/kwindowsystem_x11.cpp 8a411008717b27ec8439f6ffebe0113fdad2fd45 Diff: https://git.reviewboard.kde.org/r/116848/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116848: Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116848/ --- Review request for KDE Frameworks. Repository: kwindowsystem Description --- Add KWindowSystem::windowChanged(WId, NET::Properties, NET::Properties2) signal This signal replaces the existing signal carrying either just the NET::Properties as an uint or both as an const unsigned long*. Accordingly the previous signal gets deprecated, but is still emitted. Question: what's the correct way of deprecating signals, so that one gets a compile warning? Diffs - src/kwindowsystem.h e10f7c1cdd7b8c1fb1c6472c1f64a2ac71965534 src/kwindowsystem_x11.cpp 8a411008717b27ec8439f6ffebe0113fdad2fd45 Diff: https://git.reviewboard.kde.org/r/116848/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel