Re: Review Request 116899: Remove unused QtWidgets dependency
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116899/#review53620 --- Ship it! klauncher uses KIOWidgets, but yeah no direct use of QWidget - David Faure On March 19, 2014, 1 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116899/ --- (Updated March 19, 2014, 1 p.m.) Review request for KDE Frameworks. Repository: kinit Description --- It looks to be unused currently, so remove it. Diffs - CMakeLists.txt b5ec044da270bda4536d31e021d11f2a89c838d9 Diff: https://git.reviewboard.kde.org/r/116899/diff/ Testing --- Inspected source. A build test is difficult since some of kinit's dependencies have QtWidgets as a public dependency. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116899: Remove unused QtWidgets dependency
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116899/#review53627 --- This review has been submitted with commit adf0ec5df14b3000858f37f2e054e16b96f33c74 by Michael Palimaka to branch master. - Commit Hook On March 19, 2014, 1 p.m., Michael Palimaka wrote: --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116899/ --- (Updated March 19, 2014, 1 p.m.) Review request for KDE Frameworks. Repository: kinit Description --- It looks to be unused currently, so remove it. Diffs - CMakeLists.txt b5ec044da270bda4536d31e021d11f2a89c838d9 Diff: https://git.reviewboard.kde.org/r/116899/diff/ Testing --- Inspected source. A build test is difficult since some of kinit's dependencies have QtWidgets as a public dependency. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116899: Remove unused QtWidgets dependency
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116899/ --- (Updated March 21, 2014, 2 a.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kinit Description --- It looks to be unused currently, so remove it. Diffs - CMakeLists.txt b5ec044da270bda4536d31e021d11f2a89c838d9 Diff: https://git.reviewboard.kde.org/r/116899/diff/ Testing --- Inspected source. A build test is difficult since some of kinit's dependencies have QtWidgets as a public dependency. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116899: Remove unused QtWidgets dependency
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116899/ --- Review request for KDE Frameworks. Repository: kinit Description --- It looks to be unused currently, so remove it. Diffs - CMakeLists.txt b5ec044da270bda4536d31e021d11f2a89c838d9 Diff: https://git.reviewboard.kde.org/r/116899/diff/ Testing --- Inspected source. A build test is difficult since some of kinit's dependencies have QtWidgets as a public dependency. Thanks, Michael Palimaka ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
