Re: Review Request 116941: Remove deprecation for NET::timestampCompare and NET::timestampDiff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116941/ --- (Updated March 25, 2014, 2:24 p.m.) Status -- This change has been marked as submitted. Review request for KDE Frameworks. Repository: kwindowsystem Description --- Remove deprecation for NET::timestampCompare and NET::timestampDiff The deprecated note recommended to use the methods in KXUtils namespace, but those are in a private header and that's not going to change. As the methods are used by applications (e.g. KWin) it should not get deprecated if there is no replacement. Diffs - src/netwm_def.h 4eb5c2b8ee8e1da4a38eb4d529110d97ccf881e0 Diff: https://git.reviewboard.kde.org/r/116941/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116941: Remove deprecation for NET::timestampCompare and NET::timestampDiff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116941/#review54115 --- This review has been submitted with commit 343853139c72b8f4f4d2739a4ba6ad2bd3b7a050 by Martin Gräßlin to branch master. - Commit Hook On March 21, 2014, 7:15 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116941/ > --- > > (Updated March 21, 2014, 7:15 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kwindowsystem > > > Description > --- > > Remove deprecation for NET::timestampCompare and NET::timestampDiff > > The deprecated note recommended to use the methods in KXUtils namespace, > but those are in a private header and that's not going to change. > > As the methods are used by applications (e.g. KWin) it should not get > deprecated if there is no replacement. > > > Diffs > - > > src/netwm_def.h 4eb5c2b8ee8e1da4a38eb4d529110d97ccf881e0 > > Diff: https://git.reviewboard.kde.org/r/116941/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Re: Review Request 116941: Remove deprecation for NET::timestampCompare and NET::timestampDiff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116941/#review54009 --- Ship it! Ship It! - Kevin Ottens On March 21, 2014, 7:15 a.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/116941/ > --- > > (Updated March 21, 2014, 7:15 a.m.) > > > Review request for KDE Frameworks. > > > Repository: kwindowsystem > > > Description > --- > > Remove deprecation for NET::timestampCompare and NET::timestampDiff > > The deprecated note recommended to use the methods in KXUtils namespace, > but those are in a private header and that's not going to change. > > As the methods are used by applications (e.g. KWin) it should not get > deprecated if there is no replacement. > > > Diffs > - > > src/netwm_def.h 4eb5c2b8ee8e1da4a38eb4d529110d97ccf881e0 > > Diff: https://git.reviewboard.kde.org/r/116941/diff/ > > > Testing > --- > > > Thanks, > > Martin Gräßlin > > ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
Review Request 116941: Remove deprecation for NET::timestampCompare and NET::timestampDiff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116941/ --- Review request for KDE Frameworks. Repository: kwindowsystem Description --- Remove deprecation for NET::timestampCompare and NET::timestampDiff The deprecated note recommended to use the methods in KXUtils namespace, but those are in a private header and that's not going to change. As the methods are used by applications (e.g. KWin) it should not get deprecated if there is no replacement. Diffs - src/netwm_def.h 4eb5c2b8ee8e1da4a38eb4d529110d97ccf881e0 Diff: https://git.reviewboard.kde.org/r/116941/diff/ Testing --- Thanks, Martin Gräßlin ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
