Re: Review Request 116981: Use new terminology in webkit docs.

2014-03-27 Thread Commit Hook 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116981/#review54328
---


This review has been submitted with commit 
5674260f892b633ca69a10c38caa85c1fdffa005 by Alex Merry to branch master.

- Commit Hook


On March 25, 2014, 10:39 a.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116981/
> ---
> 
> (Updated March 25, 2014, 10:39 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdewebkit
> 
> 
> Description
> ---
> 
> Use new terminology in webkit docs.
> 
> "KDE frameworks" intead of KDE, etc.
> 
> 
> Diffs
> -
> 
>   src/kwebwallet.h 1f7643f7195e0993155f1200f77f145b61f84b0e 
>   src/kgraphicswebview.h 7092ee3cabf3f5c5296f9e7db367bed53dbf45c1 
>   src/kwebpage.h 15b3878e7096c254c81d360ab93ca8968d1048ee 
>   src/kwebpluginfactory.h 6dfe2d84f3ba9d2bbe95bb75bb228858f0745225 
>   src/kwebview.h 1d8269f64c7ec265b315474ee46bb2ce4e047eb0 
> 
> Diff: https://git.reviewboard.kde.org/r/116981/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116981: Use new terminology in webkit docs.

2014-03-27 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116981/
---

(Updated March 27, 2014, 4:06 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kdewebkit


Description
---

Use new terminology in webkit docs.

"KDE frameworks" intead of KDE, etc.


Diffs
-

  src/kwebwallet.h 1f7643f7195e0993155f1200f77f145b61f84b0e 
  src/kgraphicswebview.h 7092ee3cabf3f5c5296f9e7db367bed53dbf45c1 
  src/kwebpage.h 15b3878e7096c254c81d360ab93ca8968d1048ee 
  src/kwebpluginfactory.h 6dfe2d84f3ba9d2bbe95bb75bb228858f0745225 
  src/kwebview.h 1d8269f64c7ec265b315474ee46bb2ce4e047eb0 

Diff: https://git.reviewboard.kde.org/r/116981/diff/


Testing
---


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116981: Use new terminology in webkit docs.

2014-03-27 Thread Kevin Ottens 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116981/#review54314
---

Ship it!


Ship It!

- Kevin Ottens


On March 25, 2014, 10:39 a.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116981/
> ---
> 
> (Updated March 25, 2014, 10:39 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdewebkit
> 
> 
> Description
> ---
> 
> Use new terminology in webkit docs.
> 
> "KDE frameworks" intead of KDE, etc.
> 
> 
> Diffs
> -
> 
>   src/kwebwallet.h 1f7643f7195e0993155f1200f77f145b61f84b0e 
>   src/kgraphicswebview.h 7092ee3cabf3f5c5296f9e7db367bed53dbf45c1 
>   src/kwebpage.h 15b3878e7096c254c81d360ab93ca8968d1048ee 
>   src/kwebpluginfactory.h 6dfe2d84f3ba9d2bbe95bb75bb228858f0745225 
>   src/kwebview.h 1d8269f64c7ec265b315474ee46bb2ce4e047eb0 
> 
> Diff: https://git.reviewboard.kde.org/r/116981/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116981: Use new terminology in webkit docs.

2014-03-25 Thread Alex Merry 


> On March 24, 2014, 6:58 p.m., Kevin Ottens wrote:
> > src/kgraphicswebview.h, line 153
> > 
> >
> > Probably need to be checked with the plasma people, but I think they 
> > say just "Plasma" nowadays because of the upcoming generic shell.

This is an inherently desktop interaction (shift-clicking), so I went with 
"Plasma Desktop", after consulting Eike Hein.


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116981/#review54012
---


On March 25, 2014, 10:39 a.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116981/
> ---
> 
> (Updated March 25, 2014, 10:39 a.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdewebkit
> 
> 
> Description
> ---
> 
> Use new terminology in webkit docs.
> 
> "KDE frameworks" intead of KDE, etc.
> 
> 
> Diffs
> -
> 
>   src/kwebwallet.h 1f7643f7195e0993155f1200f77f145b61f84b0e 
>   src/kgraphicswebview.h 7092ee3cabf3f5c5296f9e7db367bed53dbf45c1 
>   src/kwebpage.h 15b3878e7096c254c81d360ab93ca8968d1048ee 
>   src/kwebpluginfactory.h 6dfe2d84f3ba9d2bbe95bb75bb228858f0745225 
>   src/kwebview.h 1d8269f64c7ec265b315474ee46bb2ce4e047eb0 
> 
> Diff: https://git.reviewboard.kde.org/r/116981/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116981: Use new terminology in webkit docs.

2014-03-25 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116981/
---

(Updated March 25, 2014, 10:39 a.m.)


Review request for KDE Frameworks.


Changes
---

Change capitalisation of KDE Frameworks and Plasma Desktop.


Repository: kdewebkit


Description
---

Use new terminology in webkit docs.

"KDE frameworks" intead of KDE, etc.


Diffs (updated)
-

  src/kwebwallet.h 1f7643f7195e0993155f1200f77f145b61f84b0e 
  src/kgraphicswebview.h 7092ee3cabf3f5c5296f9e7db367bed53dbf45c1 
  src/kwebpage.h 15b3878e7096c254c81d360ab93ca8968d1048ee 
  src/kwebpluginfactory.h 6dfe2d84f3ba9d2bbe95bb75bb228858f0745225 
  src/kwebview.h 1d8269f64c7ec265b315474ee46bb2ce4e047eb0 

Diff: https://git.reviewboard.kde.org/r/116981/diff/


Testing
---


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 116981: Use new terminology in webkit docs.

2014-03-24 Thread Kevin Ottens 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116981/#review54012
---



src/kgraphicswebview.h


When used as product name we write "KDE Frameworks" with a capital F.



src/kgraphicswebview.h


Probably need to be checked with the plasma people, but I think they say 
just "Plasma" nowadays because of the upcoming generic shell.


- Kevin Ottens


On March 22, 2014, 6:03 p.m., Alex Merry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116981/
> ---
> 
> (Updated March 22, 2014, 6:03 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kdewebkit
> 
> 
> Description
> ---
> 
> Use new terminology in webkit docs.
> 
> "KDE frameworks" intead of KDE, etc.
> 
> 
> Diffs
> -
> 
>   src/kwebpluginfactory.h 6dfe2d84f3ba9d2bbe95bb75bb228858f0745225 
>   src/kwebview.h 1d8269f64c7ec265b315474ee46bb2ce4e047eb0 
>   src/kwebwallet.h 1f7643f7195e0993155f1200f77f145b61f84b0e 
>   src/kwebpage.h 15b3878e7096c254c81d360ab93ca8968d1048ee 
>   src/kgraphicswebview.h 7092ee3cabf3f5c5296f9e7db367bed53dbf45c1 
> 
> Diff: https://git.reviewboard.kde.org/r/116981/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Merry
> 
>

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 116981: Use new terminology in webkit docs.

2014-03-22 Thread Alex Merry 

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116981/
---

Review request for KDE Frameworks.


Repository: kdewebkit


Description
---

Use new terminology in webkit docs.

"KDE frameworks" intead of KDE, etc.


Diffs
-

  src/kwebpluginfactory.h 6dfe2d84f3ba9d2bbe95bb75bb228858f0745225 
  src/kwebview.h 1d8269f64c7ec265b315474ee46bb2ce4e047eb0 
  src/kwebwallet.h 1f7643f7195e0993155f1200f77f145b61f84b0e 
  src/kwebpage.h 15b3878e7096c254c81d360ab93ca8968d1048ee 
  src/kgraphicswebview.h 7092ee3cabf3f5c5296f9e7db367bed53dbf45c1 

Diff: https://git.reviewboard.kde.org/r/116981/diff/


Testing
---


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel