Re: Review Request 117058: plasma-nm CMake fixes

2014-03-26 Thread Alex Merry

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117058/#review54201
---

Ship it!


Ship It!

- Alex Merry


On March 25, 2014, 3:48 p.m., Alexander Richardson wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117058/
 ---
 
 (Updated March 25, 2014, 3:48 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: plasma-nm
 
 
 Description
 ---
 
 Don't find frameworks that are not required for compilation
 
 --
 
 Also search CMAKE_PREFIX_PATH for the pkgconfig files
 
 This will be the default behaviour when requiring CMake = 3.1
 
 
 Diffs
 -
 
   CMakeLists.txt 3c967e7f58630c1411f2b67e63c9576a36ebcce7 
 
 Diff: https://git.reviewboard.kde.org/r/117058/diff/
 
 
 Testing
 ---
 
 Fixes compilation for me using kdesrc-build. Before it failed because it 
 couldn't find KJS (I don't build it) and libnm-qt (not in the pkgconfig 
 search path)
 
 
 Thanks,
 
 Alexander Richardson
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 117058: plasma-nm CMake fixes

2014-03-25 Thread Alexander Richardson

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117058/
---

Review request for KDE Frameworks.


Repository: plasma-nm


Description
---

Don't find frameworks that are not required for compilation

--

Also search CMAKE_PREFIX_PATH for the pkgconfig files

This will be the default behaviour when requiring CMake = 3.1


Diffs
-

  CMakeLists.txt 3c967e7f58630c1411f2b67e63c9576a36ebcce7 

Diff: https://git.reviewboard.kde.org/r/117058/diff/


Testing
---

Fixes compilation for me using kdesrc-build. Before it failed because it 
couldn't find KJS (I don't build it) and libnm-qt (not in the pkgconfig search 
path)


Thanks,

Alexander Richardson

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel