Re: Review Request 117065: Remove KDE4 TODO

2014-03-27 Thread Kevin Ottens

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117065/#review54316
---

Ship it!


Ship It!

- Kevin Ottens


On March 25, 2014, 6:26 p.m., Alex Merry wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117065/
 ---
 
 (Updated March 25, 2014, 6:26 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kcodecs
 
 
 Description
 ---
 
 Remove KDE4 TODO
 
 This was actually (at least mostly) done for KDE Platform 4.  It's
 probably not worth changing any of the others and risk breaking code.
 
 
 Diffs
 -
 
   src/kcharsets.cpp 6bbbefc47535f38611839464824c6b537426c496 
 
 Diff: https://git.reviewboard.kde.org/r/117065/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Alex Merry
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 117065: Remove KDE4 TODO

2014-03-27 Thread Commit Hook

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117065/#review54335
---


This review has been submitted with commit 
3d170b4a0b9b849e14badaa354430779e0a487d9 by Alex Merry to branch master.

- Commit Hook


On March 25, 2014, 6:26 p.m., Alex Merry wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://git.reviewboard.kde.org/r/117065/
 ---
 
 (Updated March 25, 2014, 6:26 p.m.)
 
 
 Review request for KDE Frameworks.
 
 
 Repository: kcodecs
 
 
 Description
 ---
 
 Remove KDE4 TODO
 
 This was actually (at least mostly) done for KDE Platform 4.  It's
 probably not worth changing any of the others and risk breaking code.
 
 
 Diffs
 -
 
   src/kcharsets.cpp 6bbbefc47535f38611839464824c6b537426c496 
 
 Diff: https://git.reviewboard.kde.org/r/117065/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Alex Merry
 


___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Re: Review Request 117065: Remove KDE4 TODO

2014-03-27 Thread Alex Merry

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117065/
---

(Updated March 27, 2014, 4:10 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks.


Repository: kcodecs


Description
---

Remove KDE4 TODO

This was actually (at least mostly) done for KDE Platform 4.  It's
probably not worth changing any of the others and risk breaking code.


Diffs
-

  src/kcharsets.cpp 6bbbefc47535f38611839464824c6b537426c496 

Diff: https://git.reviewboard.kde.org/r/117065/diff/


Testing
---


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel


Review Request 117065: Remove KDE4 TODO

2014-03-25 Thread Alex Merry

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117065/
---

Review request for KDE Frameworks.


Repository: kcodecs


Description
---

Remove KDE4 TODO

This was actually (at least mostly) done for KDE Platform 4.  It's
probably not worth changing any of the others and risk breaking code.


Diffs
-

  src/kcharsets.cpp 6bbbefc47535f38611839464824c6b537426c496 

Diff: https://git.reviewboard.kde.org/r/117065/diff/


Testing
---


Thanks,

Alex Merry

___
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel